From: Kalle Valo <kvalo@kernel.org>
To: Arend Van Spriel <arend.vanspriel@broadcom.com>
Cc: Dan Carpenter <dan.carpenter@linaro.org>,
Su Hui <suhui@nfschina.com>, <johannes.berg@intel.com>,
<kees@kernel.org>, <a@bayrepo.ru>, <marcan@marcan.st>,
<quic_alokad@quicinc.com>, <zyytlz.wz@163.com>,
<petr.tesarik.ext@huawei.com>, <duoming@zju.edu.cn>,
<colin.i.king@gmail.com>, <frankyl@broadcom.com>,
<meuleman@broadcom.com>, <phaber@broadcom.com>,
<linville@tuxdriver.com>, <linux-wireless@vger.kernel.org>,
<brcm80211@lists.linux.dev>,
<brcm80211-dev-list.pdl@broadcom.com>,
<linux-kernel@vger.kernel.org>,
<kernel-janitors@vger.kernel.org>
Subject: Re: [PATCH wireless 1/9] wifi: cfg80211: avoid garbage value of 'io_type' in brcmf_cfg80211_attach()
Date: Tue, 02 Jul 2024 18:29:20 +0300 [thread overview]
Message-ID: <878qyjg6cv.fsf@kernel.org> (raw)
In-Reply-To: <19073fcc9e8.279b.9b12b7fc0a3841636cfb5e919b41b954@broadcom.com> (Arend Van Spriel's message of "Tue, 02 Jul 2024 17:07:45 +0200")
Arend Van Spriel <arend.vanspriel@broadcom.com> writes:
> On July 2, 2024 3:57:27 PM Dan Carpenter <dan.carpenter@linaro.org> wrote:
>
>> On Tue, Jul 02, 2024 at 08:24:44PM +0800, Su Hui wrote:
>>> brcmf_fil_cmd_int_get() reads the value of 'io_type' and passes it to
>>> brcmf_fil_cmd_data_get(). Initialize 'io_type' to avoid garbage value.
>>
>> Since you're going to be resending anyway, please delete the space char
>> from the start of the line.
>>
>> It's weird that brcmf_fil_cmd_data_get() uses the uninitialized data.
>> It looks like it just goes to great lengths to preserve the original
>> data in io_type... So it likely is harmless enough but still a strange
>> and complicated way write a no-op.
>
> Not sure if it helps, but I tried to explain the reason in response to
> patch 0 (cover letter).
Would it make more sense to have just one patch? It's the same issue
anyway.
--
https://patchwork.kernel.org/project/linux-wireless/list/
https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches
next prev parent reply other threads:[~2024-07-02 15:29 UTC|newest]
Thread overview: 26+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-07-02 12:24 [PATCH wireless 0/9] wifi: cfg80211: avoid some garbage values Su Hui
2024-07-02 12:24 ` [PATCH wireless 1/9] wifi: cfg80211: avoid garbage value of 'io_type' in brcmf_cfg80211_attach() Su Hui
2024-07-02 13:57 ` Dan Carpenter
2024-07-02 15:07 ` Arend Van Spriel
2024-07-02 15:29 ` Kalle Valo [this message]
2024-07-02 15:37 ` Dan Carpenter
2024-07-02 16:26 ` Arend Van Spriel
2024-07-02 16:37 ` Dan Carpenter
2024-07-02 15:39 ` Arend Van Spriel
2024-07-03 1:41 ` Su Hui
2024-07-03 4:42 ` Arend Van Spriel
2024-07-03 7:38 ` Su Hui
2024-07-03 13:23 ` Dan Carpenter
2024-07-02 12:24 ` [PATCH wireless 2/9] wifi: brcmfmac: avoid garbage value of 'status' in brcmf_c_download_blob() Su Hui
2024-07-02 12:24 ` [PATCH wireless 3/9] wifi: cfg80211: avoid garbage value of 'noise' in brcmf_cfg80211_dump_survey() Su Hui
2024-07-02 12:24 ` [PATCH wireless 4/9] wifi: cfg80211: avoid garbage value of 'chanspec' in brcmf_cfg80211_get_channel() Su Hui
2024-07-02 12:24 ` [PATCH wireless 5/9] wifi: cfg80211: avoid garbage value of 'freq' in brcmf_cfg80211_mgmt_tx() Su Hui
2024-07-02 12:24 ` [PATCH wireless 6/9] wifi: cfg80211: avoid garbage value of 'wsec' in brcmf_cfg80211_reconfigure_wep() Su Hui
2024-07-02 12:24 ` [PATCH wireless 7/9] wifi: cfg80211: avoid garbage value of 'wsec' in brcmf_cfg80211_add_key() Su Hui
2024-07-02 12:24 ` [PATCH wireless 8/9] wifi: cfg80211: avoid garbage value of 'val' in brcmf_set_key_mgmt() Su Hui
2024-07-02 12:24 ` [PATCH wireless 9/9] wifi: cfg80211: avoid garbage value of 'wsec' in brcmf_cfg80211_{get,config_default}_key() Su Hui
2024-07-02 12:49 ` [PATCH wireless 0/9] wifi: cfg80211: avoid some garbage values Johannes Berg
2024-07-02 14:41 ` Arend Van Spriel
2024-07-02 14:41 ` Arend Van Spriel
2024-07-02 14:02 ` Jonas Gorski
2024-07-02 15:01 ` Arend Van Spriel
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=878qyjg6cv.fsf@kernel.org \
--to=kvalo@kernel.org \
--cc=a@bayrepo.ru \
--cc=arend.vanspriel@broadcom.com \
--cc=brcm80211-dev-list.pdl@broadcom.com \
--cc=brcm80211@lists.linux.dev \
--cc=colin.i.king@gmail.com \
--cc=dan.carpenter@linaro.org \
--cc=duoming@zju.edu.cn \
--cc=frankyl@broadcom.com \
--cc=johannes.berg@intel.com \
--cc=kees@kernel.org \
--cc=kernel-janitors@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-wireless@vger.kernel.org \
--cc=linville@tuxdriver.com \
--cc=marcan@marcan.st \
--cc=meuleman@broadcom.com \
--cc=petr.tesarik.ext@huawei.com \
--cc=phaber@broadcom.com \
--cc=quic_alokad@quicinc.com \
--cc=suhui@nfschina.com \
--cc=zyytlz.wz@163.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.