From: "Alex Bennée" <alex.bennee@linaro.org>
To: Mostafa Saleh <smostafa@google.com>
Cc: qemu-arm@nongnu.org, eric.auger@redhat.com,
peter.maydell@linaro.org, qemu-devel@nongnu.org,
jean-philippe@linaro.org, maz@kernel.org, nicolinc@nvidia.com,
julien@xen.org, richard.henderson@linaro.org,
marcin.juszkiewicz@linaro.org
Subject: Re: [RFC PATCH v3 04/18] hw/arm/smmu: Use enum for SMMU stage
Date: Wed, 15 May 2024 21:25:59 +0100 [thread overview]
Message-ID: <878r0arfe0.fsf@draig.linaro.org> (raw)
In-Reply-To: <20240429032403.74910-5-smostafa@google.com> (Mostafa Saleh's message of "Mon, 29 Apr 2024 03:23:48 +0000")
Mostafa Saleh <smostafa@google.com> writes:
> Currently, translation stage is represented as an int, where 1 is stage-1 and
> 2 is stage-2, when nested is added, 3 would be confusing to represent nesting,
> so we use an enum instead.
>
> While keeping the same values, this is useful for:
> - Doing tricks with bit masks, where BIT(0) is stage-1 and BIT(1) is
> stage-2 and both is nested.
> - Tracing, as stage is printed as int.
>
> Signed-off-by: Mostafa Saleh <smostafa@google.com>
> Reviewed-by: Eric Auger <eric.auger@redhat.com>
Reviewed-by: Alex Bennée <alex.bennee@linaro.org>
--
Alex Bennée
Virtualisation Tech Lead @ Linaro
next prev parent reply other threads:[~2024-05-15 20:26 UTC|newest]
Thread overview: 57+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-04-29 3:23 [RFC PATCH v3 00/18] SMMUv3 nested translation support Mostafa Saleh
2024-04-29 3:23 ` [RFC PATCH v3 01/18] hw/arm/smmu-common: Add missing size check for stage-1 Mostafa Saleh
2024-05-13 11:30 ` Eric Auger
2024-04-29 3:23 ` [RFC PATCH v3 02/18] hw/arm/smmu: Fix IPA for stage-2 events Mostafa Saleh
2024-05-13 11:47 ` Eric Auger
2024-05-16 14:43 ` Mostafa Saleh
2024-04-29 3:23 ` [RFC PATCH v3 03/18] hw/arm/smmuv3: Fix encoding of CLASS in events Mostafa Saleh
2024-05-15 12:27 ` Eric Auger
2024-05-16 14:50 ` Mostafa Saleh
2024-04-29 3:23 ` [RFC PATCH v3 04/18] hw/arm/smmu: Use enum for SMMU stage Mostafa Saleh
2024-05-15 20:25 ` Alex Bennée [this message]
2024-04-29 3:23 ` [RFC PATCH v3 05/18] hw/arm/smmu: Split smmuv3_translate() Mostafa Saleh
2024-04-29 3:23 ` [RFC PATCH v3 06/18] hw/arm/smmu: Consolidate ASID and VMID types Mostafa Saleh
2024-05-15 12:41 ` Eric Auger
2024-06-17 14:55 ` Mostafa Saleh
2024-04-29 3:23 ` [RFC PATCH v3 07/18] hw/arm/smmuv3: Translate CD and TT using stage-2 table Mostafa Saleh
2024-05-15 13:15 ` Eric Auger
2024-05-16 16:11 ` Mostafa Saleh
2024-04-29 3:23 ` [RFC PATCH v3 08/18] hw/arm/smmu-common: Add support for nested TLB Mostafa Saleh
2024-05-15 13:48 ` Eric Auger
2024-05-16 15:20 ` Mostafa Saleh
2024-05-20 8:20 ` Eric Auger
2024-05-22 12:44 ` Mostafa Saleh
2024-06-17 14:56 ` Mostafa Saleh
2024-04-29 3:23 ` [RFC PATCH v3 09/18] hw/arm/smmu-common: Rework TLB lookup for nesting Mostafa Saleh
2024-05-15 13:54 ` Eric Auger
2024-05-16 15:30 ` Mostafa Saleh
2024-05-20 8:27 ` Eric Auger
2024-05-22 12:47 ` Mostafa Saleh
2024-04-29 3:23 ` [RFC PATCH v3 10/18] hw/arm/smmu-common: Support nested translation Mostafa Saleh
2024-05-20 9:48 ` Eric Auger
2024-06-17 14:57 ` Mostafa Saleh
2024-04-29 3:23 ` [RFC PATCH v3 11/18] hw/arm/smmu: Support nesting in smmuv3_range_inval() Mostafa Saleh
2024-04-29 3:23 ` [RFC PATCH v3 12/18] hw/arm/smmu: Support nesting in the rest of commands Mostafa Saleh
2024-05-20 10:24 ` Eric Auger
2024-06-17 14:58 ` Mostafa Saleh
2024-04-29 3:23 ` [RFC PATCH v3 13/18] hw/arm/smmuv3: Support nested SMMUs in smmuv3_notify_iova() Mostafa Saleh
2024-05-20 10:37 ` Eric Auger
2024-06-17 15:02 ` Mostafa Saleh
2024-04-29 3:23 ` [RFC PATCH v3 14/18] hw/arm/smmuv3: Support and advertise nesting Mostafa Saleh
2024-05-20 13:16 ` Eric Auger
2024-06-17 15:03 ` Mostafa Saleh
2024-04-29 3:23 ` [RFC PATCH v3 15/18] hw/arm/smmuv3: Advertise S2FWB Mostafa Saleh
2024-05-20 13:30 ` Eric Auger
2024-06-17 15:04 ` Mostafa Saleh
2024-04-29 3:24 ` [RFC PATCH v3 16/18] hw/arm/smmu: Refactor SMMU OAS Mostafa Saleh
2024-05-20 13:59 ` Eric Auger
2024-04-29 3:24 ` [RFC PATCH v3 17/18] hw/arm/smmuv3: Add property for OAS Mostafa Saleh
2024-05-21 9:32 ` Eric Auger
2024-06-27 11:50 ` Mostafa Saleh
2024-04-29 3:24 ` [RFC PATCH v3 18/18] hw/arm/virt: Set SMMU OAS based on CPU PARANGE Mostafa Saleh
2024-05-21 9:43 ` Eric Auger
2024-05-24 17:22 ` Julien Grall
2024-06-27 11:44 ` Mostafa Saleh
2024-05-13 13:57 ` [RFC PATCH v3 00/18] SMMUv3 nested translation support Julien Grall
2024-05-21 9:47 ` Eric Auger
2024-05-27 16:12 ` Mostafa Saleh
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=878r0arfe0.fsf@draig.linaro.org \
--to=alex.bennee@linaro.org \
--cc=eric.auger@redhat.com \
--cc=jean-philippe@linaro.org \
--cc=julien@xen.org \
--cc=marcin.juszkiewicz@linaro.org \
--cc=maz@kernel.org \
--cc=nicolinc@nvidia.com \
--cc=peter.maydell@linaro.org \
--cc=qemu-arm@nongnu.org \
--cc=qemu-devel@nongnu.org \
--cc=richard.henderson@linaro.org \
--cc=smostafa@google.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.