All of lore.kernel.org
 help / color / mirror / Atom feed
From: Jonathan Corbet <corbet@lwn.net>
To: Diederik de Haas <didi.debian@cknow.org>,
	Dwaipayan Ray <dwaipayanray1@gmail.com>,
	Lukas Bulwahn <lukas.bulwahn@gmail.com>
Cc: Joe Perches <joe@perches.com>,
	linux-doc@vger.kernel.org, linux-kernel@vger.kernel.org,
	Diederik de Haas <didi.debian@cknow.org>
Subject: Re: [PATCH] docs: dev-tools: checkpatch: Add targets for checkpatch tags
Date: Mon, 13 May 2024 07:13:09 -0600	[thread overview]
Message-ID: <878r0dam8q.fsf@meer.lwn.net> (raw)
In-Reply-To: <20240513102237.112376-1-didi.debian@cknow.org>

Diederik de Haas <didi.debian@cknow.org> writes:

> Make the tags directly linkable by defining targets for them.
>
> Closes: https://lore.kernel.org/r/8090211.0vHzs8tI1a@bagend/
> Signed-off-by: Diederik de Haas <didi.debian@cknow.org>
> ---
>  Documentation/dev-tools/checkpatch.rst | 216 +++++++++++++++++++++++++
>  1 file changed, 216 insertions(+)

In addition to the other comments, I have to add: you have said what you
are doing but not *why*.  All of these labels clutter up the text; what
use will be made of them to justify that?

Thanks,

jon

      parent reply	other threads:[~2024-05-13 13:22 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-05-13 10:22 [PATCH] docs: dev-tools: checkpatch: Add targets for checkpatch tags Diederik de Haas
2024-05-13 11:18 ` Jani Nikula
2024-05-13 11:46   ` Lukas Bulwahn
2024-05-13 13:45     ` Diederik de Haas
2024-05-13 14:48     ` Diederik de Haas
2024-05-13 11:51   ` Akira Yokosawa
2024-05-13 13:13 ` Jonathan Corbet [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=878r0dam8q.fsf@meer.lwn.net \
    --to=corbet@lwn.net \
    --cc=didi.debian@cknow.org \
    --cc=dwaipayanray1@gmail.com \
    --cc=joe@perches.com \
    --cc=linux-doc@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=lukas.bulwahn@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.