From: Jani Nikula <jani.nikula@intel.com>
To: Thomas Zimmermann <tzimmermann@suse.de>, dri-devel@lists.freedesktop.org
Cc: intel-gfx@lists.freedesktop.org, intel-xe@lists.freedesktop.org
Subject: Re: [REBASE 7/7] drm/edid: make drm_edid_are_equal() more convenient for its single user
Date: Wed, 17 Apr 2024 11:21:58 +0300 [thread overview]
Message-ID: <878r1cz9eh.fsf@intel.com> (raw)
In-Reply-To: <deb7918d-03dd-49f4-8a5d-3470ed05800e@suse.de>
On Tue, 16 Apr 2024, Thomas Zimmermann <tzimmermann@suse.de> wrote:
> Hi
>
> Am 16.04.24 um 14:27 schrieb Jani Nikula:
>> On Tue, 16 Apr 2024, Thomas Zimmermann <tzimmermann@suse.de> wrote:
>>> Hi
>>>
>>> Am 16.04.24 um 11:20 schrieb Jani Nikula:
>>>> Repurpose drm_edid_are_equal() to be more helpful for its single user,
>>>> and rename drm_edid_eq(). Functionally deduce the length from the blob
>>>> size, not the blob data, making it more robust against any errors.
>>> Could be squashed into patch 6.
>> Ack.
>>
>> Thanks for the review. I'll hold of on resending these until there are
>> some R-b's... I've send them a few times already with no comments. :(
>
> Feel free to add
>
> Reviewed-by: Thomas Zimmermann <tzimmermann@suse.de>
>
> to the series.
Many thanks! Just to double check, do you want me to move patch 5
earlier and squash patches 6&7?
BR,
Jani.
--
Jani Nikula, Intel
next prev parent reply other threads:[~2024-04-17 8:22 UTC|newest]
Thread overview: 27+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-04-16 9:19 [REBASE 0/7] drm/edid: cleanups, rebase Jani Nikula
2024-04-16 9:19 ` [REBASE 1/7] drm/displayid: move drm_displayid.h to drm_displayd_internal.h Jani Nikula
2024-04-16 9:19 ` [REBASE 2/7] drm/edid: move all internal declarations to drm_crtc_internal.h Jani Nikula
2024-04-16 9:19 ` [REBASE 3/7] drm/edid: group struct drm_edid based declarations together Jani Nikula
2024-04-16 9:19 ` [REBASE 4/7] drm/edid: rename drm_find_edid_extension() to drm_edid_find_extension() Jani Nikula
2024-04-16 9:19 ` [REBASE 5/7] drm/edid: avoid drm_edid_find_extension() internally Jani Nikula
2024-04-16 12:19 ` Thomas Zimmermann
2024-04-16 12:24 ` Jani Nikula
2024-04-16 9:19 ` [REBASE 6/7] drm/edid: make drm_edid_are_equal() static Jani Nikula
2024-04-16 9:20 ` [REBASE 7/7] drm/edid: make drm_edid_are_equal() more convenient for its single user Jani Nikula
2024-04-16 12:21 ` Thomas Zimmermann
2024-04-16 12:27 ` Jani Nikula
2024-04-16 12:47 ` Thomas Zimmermann
2024-04-17 8:21 ` Jani Nikula [this message]
2024-04-17 11:13 ` Thomas Zimmermann
2024-04-17 15:20 ` Jani Nikula
2024-04-16 9:30 ` ✓ CI.Patch_applied: success for drm/edid: cleanups, rebase Patchwork
2024-04-16 9:30 ` ✗ CI.checkpatch: warning " Patchwork
2024-04-16 9:31 ` ✓ CI.KUnit: success " Patchwork
2024-04-16 9:43 ` ✓ CI.Build: " Patchwork
2024-04-16 9:51 ` ✓ CI.Hooks: " Patchwork
2024-04-16 9:52 ` ✗ CI.checksparse: warning " Patchwork
2024-04-16 10:13 ` ✗ Fi.CI.CHECKPATCH: " Patchwork
2024-04-16 10:13 ` ✗ Fi.CI.SPARSE: " Patchwork
2024-04-16 10:21 ` ✗ Fi.CI.BAT: failure " Patchwork
2024-04-16 10:28 ` ✓ CI.BAT: success " Patchwork
2024-04-17 6:32 ` ✗ CI.FULL: failure " Patchwork
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=878r1cz9eh.fsf@intel.com \
--to=jani.nikula@intel.com \
--cc=dri-devel@lists.freedesktop.org \
--cc=intel-gfx@lists.freedesktop.org \
--cc=intel-xe@lists.freedesktop.org \
--cc=tzimmermann@suse.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.