From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 6E485C54791 for ; Wed, 13 Mar 2024 11:48:08 +0000 (UTC) Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id 420BC10E8AD; Wed, 13 Mar 2024 11:48:05 +0000 (UTC) Authentication-Results: gabe.freedesktop.org; dkim=pass (2048-bit key; unprotected) header.d=intel.com header.i=@intel.com header.b="cTKGT8Ol"; dkim-atps=neutral Received: from mgamail.intel.com (mgamail.intel.com [192.198.163.14]) by gabe.freedesktop.org (Postfix) with ESMTPS id B5EBE10E8AD; Wed, 13 Mar 2024 11:47:56 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1710330477; x=1741866477; h=from:to:cc:subject:in-reply-to:references:date: message-id:mime-version; bh=7EL7NBFPSCPiSrkzYeMpOx6tQ6nmjhbSiQuN/1IINc0=; b=cTKGT8Olb0EulTEe3NERfUZblefyJ426JW3nMWZXOZk1sxGl8z7tD4dF GNhKA4jkEzSRq6mltUbfukZ6bmEoZFDPRnqNaiib2a5MsfikjfqvR68uS 6fwLqmGiYa6k5XF9k1dnDMHh72oyOOBdpVblIHkWcLk4AJqbWaM7XxI3B eeliyZl3cZWjL8Z+bzDEsf1GhfuBTOqYXYOKgXKDri0TBIWqUvgCJxTra lQZszELgQKOPtyEvw0imrkqkuqJ5Sl/SorTcOVxbVLHC7i/6QSnx6BKjc +z+xUGQEddShFesk3yoQSyiBllO7w6rVYWVS79FyUJex71DqQyZgWrThg w==; X-IronPort-AV: E=McAfee;i="6600,9927,11011"; a="5270071" X-IronPort-AV: E=Sophos;i="6.07,122,1708416000"; d="scan'208";a="5270071" Received: from orviesa003.jf.intel.com ([10.64.159.143]) by fmvoesa108.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 13 Mar 2024 04:47:56 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="6.07,122,1708416000"; d="scan'208";a="16551865" Received: from jbakowsk-mobl.ger.corp.intel.com (HELO localhost) ([10.252.53.28]) by ORVIESA003-auth.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 13 Mar 2024 04:47:55 -0700 From: Jani Nikula To: Thomas Zimmermann , dri-devel@lists.freedesktop.org Cc: intel-gfx@lists.freedesktop.org Subject: Re: [PATCH 0/8] drm: fix .get_modes() return values In-Reply-To: Organization: Intel Finland Oy - BIC 0357606-4 - Westendinkatu 7, 02160 Espoo References: Date: Wed, 13 Mar 2024 13:47:51 +0200 Message-ID: <878r2ms68o.fsf@intel.com> MIME-Version: 1.0 Content-Type: text/plain X-BeenThere: intel-gfx@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Intel graphics driver community testing & development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: intel-gfx-bounces@lists.freedesktop.org Sender: "Intel-gfx" On Fri, 08 Mar 2024, Thomas Zimmermann wrote: > Acked-by: Thomas Zimmermann > > for the series. Thanks, pushed the lot to drm-misc-next-fixes. > Do you plan to make the return type an unsigned int eventually? Not really. The hooks could still return -ENOMEM or something, with no compiler warnings, and you'd be screwed because you wouldn't even have a way of checking. You'd just get 4294967284 modes. BR, Jani. -- Jani Nikula, Intel