From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 4C5CCC48BF6 for ; Thu, 29 Feb 2024 10:29:16 +0000 (UTC) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1rfdej-00081W-3H; Thu, 29 Feb 2024 05:28:49 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1rfdeh-00080m-D8 for qemu-devel@nongnu.org; Thu, 29 Feb 2024 05:28:47 -0500 Received: from us-smtp-delivery-124.mimecast.com ([170.10.129.124]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1rfdee-00060S-SB for qemu-devel@nongnu.org; Thu, 29 Feb 2024 05:28:47 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1709202523; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=HtqRuQDmPfgmre07UmI+p3vIpcwBb+PrvgxlEr5p1sk=; b=i3nSqyJQMEWw2tQ+xIkYRSsTcCpieCEhFG5vi6Q0I3GvBGV4Ea4sj21dsVRUdG1gfnG4GE cdCP+Ov0qv48C4IoqJgWR5gbCtW6toC+cio3v9ALPNgT/mKW3+hg7Znon2F39yS72OaC38 J1rVLbBpOc6smQHffWAv4PjSMQHUG78= Received: from mimecast-mx02.redhat.com (mimecast-mx02.redhat.com [66.187.233.88]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-107-1-0laT3dMpS655ZqShuehg-1; Thu, 29 Feb 2024 05:28:38 -0500 X-MC-Unique: 1-0laT3dMpS655ZqShuehg-1 Received: from smtp.corp.redhat.com (int-mx09.intmail.prod.int.rdu2.redhat.com [10.11.54.9]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by mimecast-mx02.redhat.com (Postfix) with ESMTPS id 7316B891F22; Thu, 29 Feb 2024 10:28:38 +0000 (UTC) Received: from blackfin.pond.sub.org (unknown [10.39.193.4]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 4659F492BC8; Thu, 29 Feb 2024 10:28:38 +0000 (UTC) Received: by blackfin.pond.sub.org (Postfix, from userid 1000) id 425D421E66D0; Thu, 29 Feb 2024 11:28:37 +0100 (CET) From: Markus Armbruster To: Stefano Garzarella Cc: qemu-devel@nongnu.org, Paolo Bonzini , qemu-block@nongnu.org, Daniel P. =?utf-8?Q?Berrang=C3=A9?= , Thomas Huth , "Michael S. Tsirkin" , Jason Wang , Philippe =?utf-8?Q?Mathieu-Daud=C3=A9?= , =?utf-8?Q?Marc-Andr=C3=A9?= Lureau , Eric Blake , Coiby Xu , slp@redhat.com, Eduardo Habkost , Hanna Reitz , Igor Mammedov , Raphael Norwitz , Kevin Wolf , David Hildenbrand , stefanha@redhat.com, gmaglione@redhat.com Subject: Re: [PATCH 9/9] hostmem-file: support POSIX shm_open() In-Reply-To: (Stefano Garzarella's message of "Thu, 29 Feb 2024 09:57:22 +0100") References: <20240228114759.44758-1-sgarzare@redhat.com> <20240228114759.44758-10-sgarzare@redhat.com> <874jdswyzy.fsf@pond.sub.org> Date: Thu, 29 Feb 2024 11:28:37 +0100 Message-ID: <878r33zhre.fsf@pond.sub.org> User-Agent: Gnus/5.13 (Gnus v5.13) MIME-Version: 1.0 Content-Type: text/plain X-Scanned-By: MIMEDefang 3.4.1 on 10.11.54.9 Received-SPF: pass client-ip=170.10.129.124; envelope-from=armbru@redhat.com; helo=us-smtp-delivery-124.mimecast.com X-Spam_score_int: -21 X-Spam_score: -2.2 X-Spam_bar: -- X-Spam_report: (-2.2 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.102, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, RCVD_IN_MSPIKE_H2=-0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001, T_SCC_BODY_TEXT_LINE=-0.01 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Sender: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Stefano Garzarella writes: > On Wed, Feb 28, 2024 at 01:32:17PM +0100, Markus Armbruster wrote: >>Stefano Garzarella writes: [...] >>> +# @shm: if true, shm_open(3) is used to create/open POSIX shared memory >>> +# object; if false, an open(2) is used. (default: false) (since 9.0) >>> +# >> >>Please format like this for consistency: > > Sure. > >> >># @shm: if true, shm_open(3) is used to create/open POSIX shared memory >># object; if false, an open(2) is used (default: false) (since 9.0) > > I just noticed that I followed the property just above (@rom). Should we fix that one? Yes, please. See commit a937b6aa739 (qapi: Reformat doc comments to conform to current conventions).