From mboxrd@z Thu Jan 1 00:00:00 1970 Received: by 2002:a17:906:e92:b0:a3e:79c1:d636 with SMTP id p18csp1902483ejf; Sun, 25 Feb 2024 23:41:21 -0800 (PST) X-Forwarded-Encrypted: i=2; AJvYcCXNFxnY28xE7cW5qrXI6gLE8noUQvsg29dOqqkQnfRRgebKEOb3K1/LpfWViWq325r05ZgF4e+1ajVPsnxbF6ib51qA5Jpj X-Google-Smtp-Source: AGHT+IGEeL7zx9ejQB5Qv4zdkofu2tC18SH5+OitLLBPHShAiRxXFB/6c1GMz5Ln2zFr5plGuPDV X-Received: by 2002:a05:6102:c4f:b0:470:3eff:bdd8 with SMTP id y15-20020a0561020c4f00b004703effbdd8mr4651563vss.24.1708933281605; Sun, 25 Feb 2024 23:41:21 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1708933281; cv=none; d=google.com; s=arc-20160816; b=aR3/O7xq5g+VxUQwPYW2nrvPITf9SfPBJtHpLSpI4qzpfeOpmxBjclfsW+EBxfYbFk nPLUOvFYJS9ktKYc12fh9R/2Tj0uGhUoxh/cOOUJI3xCExyJBhTBvVIDQQgMVl8py1i+ I0V1DjZnHZZMbjC+B+LkWQ03N3wRRSbj1AxOur+78yyXZfuctBVXqaAZR/3MFnO/yGNi E8TaJp+HRKsidw/XQWwqwS8MYI0CzhGatBuTv9iEEZkHkUvCX6rrsk0v6JypYXfvL+eS Sqr9yyHF7Q44MgXWoJ2m1P1NrZJF4t2HKTsJtIe6uBjLJEPLhBThU1YpEXp2u3xOQjb7 wGWA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=sender:errors-to:list-subscribe:list-help:list-post:list-archive :list-unsubscribe:list-id:precedence:content-transfer-encoding :mime-version:user-agent:message-id:date:references:in-reply-to :subject:cc:to:from:dkim-signature; bh=5JOeOXEbmI6wBwhZ1IWRAD5hq6bI9ex93IjpEZdKhyE=; fh=Or9Y+MqXyDNJGUd/Ic3vJHkmFcFijXRl3Xn5uJV7WUk=; b=KJR16cs6tBkhpzGvWlaR6CjXX65FQNwNg8+W6sRBTrSK0Ut57DhWLzz7XSUzMreWcf RBj4HTqkE2wZ6hWVmsiyeHJ7OjPbAULWy1TJdpk+fkoql5r6SVKhCRrpChgQt3JhHxIO olc1xsjQmiz1pHGJV/mioqC31GuSC9xWDPqhefgeM2hCOREKo+ogGd0gSAkSV4ds/000 wz8SRThthwpjiM4ku6IpfsatZklXq+dFdAGrqpRJx1kmZqyO7PwHqexF1oy9q76OolB8 r6zgdO0CS884QYnd7LaLlhvido3E9Xgm68IqYQsJSaOe+TUxzcgBv7zDoCd4wdj312Ad qasg==; dara=google.com ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@redhat.com header.s=mimecast20190719 header.b=NupR1qUk; spf=pass (google.com: domain of qemu-devel-bounces+alex.bennee=linaro.org@nongnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom="qemu-devel-bounces+alex.bennee=linaro.org@nongnu.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=redhat.com Return-Path: Received: from lists.gnu.org (lists.gnu.org. [209.51.188.17]) by mx.google.com with ESMTPS id yf4-20020a05620a3bc400b00787da0c1af4si270969qkn.331.2024.02.25.23.41.21 for (version=TLS1_2 cipher=ECDHE-ECDSA-CHACHA20-POLY1305 bits=256/256); Sun, 25 Feb 2024 23:41:21 -0800 (PST) Received-SPF: pass (google.com: domain of qemu-devel-bounces+alex.bennee=linaro.org@nongnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; Authentication-Results: mx.google.com; dkim=pass header.i=@redhat.com header.s=mimecast20190719 header.b=NupR1qUk; spf=pass (google.com: domain of qemu-devel-bounces+alex.bennee=linaro.org@nongnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom="qemu-devel-bounces+alex.bennee=linaro.org@nongnu.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=redhat.com Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1reVbR-0007MA-Q0; Mon, 26 Feb 2024 02:40:45 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1reVbQ-0007M1-UE for qemu-devel@nongnu.org; Mon, 26 Feb 2024 02:40:44 -0500 Received: from us-smtp-delivery-124.mimecast.com ([170.10.133.124]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1reVbP-00057D-C1 for qemu-devel@nongnu.org; Mon, 26 Feb 2024 02:40:44 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1708933242; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=5JOeOXEbmI6wBwhZ1IWRAD5hq6bI9ex93IjpEZdKhyE=; b=NupR1qUkT3UMeAOWGfyCJ4V858Qo/2tWfebNWeaCS4FTyle+MkeZ4bbPAs0+ts354MsS+M sfN9QHvM//sGcSRVLKl4TMFqfZ23GxyzXjmJQysnpk6agU7eKZBnsZ2NLauDIJt8yw/OVg rkui++jOXTsljWebudigQCJc+GnPoIk= Received: from mimecast-mx02.redhat.com (mimecast-mx02.redhat.com [66.187.233.88]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-462-14rTLr1UMq20bpj6A_354Q-1; Mon, 26 Feb 2024 02:40:40 -0500 X-MC-Unique: 14rTLr1UMq20bpj6A_354Q-1 Received: from smtp.corp.redhat.com (int-mx05.intmail.prod.int.rdu2.redhat.com [10.11.54.5]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by mimecast-mx02.redhat.com (Postfix) with ESMTPS id E078B108C065; Mon, 26 Feb 2024 07:40:39 +0000 (UTC) Received: from blackfin.pond.sub.org (unknown [10.39.193.4]) by smtp.corp.redhat.com (Postfix) with ESMTPS id B19928CEC; Mon, 26 Feb 2024 07:40:39 +0000 (UTC) Received: by blackfin.pond.sub.org (Postfix, from userid 1000) id 9175221E6767; Mon, 26 Feb 2024 08:40:37 +0100 (CET) From: Markus Armbruster To: BALATON Zoltan Cc: Philippe =?utf-8?Q?Mathieu-Daud=C3=A9?= , qemu-devel@nongnu.org, qemu-ppc@nongnu.org, Leif Lindholm , Marcin Juszkiewicz , Radoslaw Biernacki , qemu-arm@nongnu.org, Peter Maydell , qemu-block@nongnu.org, John Snow , Mark Cave-Ayland Subject: Re: [PATCH v2 3/3] hw/ide: Include 'ide_internal.h' from current path In-Reply-To: (BALATON Zoltan's message of "Sun, 25 Feb 2024 21:28:33 +0100 (CET)") References: <20240225171637.4709-1-philmd@linaro.org> <20240225171637.4709-4-philmd@linaro.org> Date: Mon, 26 Feb 2024 08:40:37 +0100 Message-ID: <878r37lll6.fsf@pond.sub.org> User-Agent: Gnus/5.13 (Gnus v5.13) MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-Scanned-By: MIMEDefang 3.4.1 on 10.11.54.5 Received-SPF: pass client-ip=170.10.133.124; envelope-from=armbru@redhat.com; helo=us-smtp-delivery-124.mimecast.com X-Spam_score_int: -21 X-Spam_score: -2.2 X-Spam_bar: -- X-Spam_report: (-2.2 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.097, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, RCVD_IN_MSPIKE_H4=-0.01, RCVD_IN_MSPIKE_WL=-0.01, SPF_HELO_NONE=0.001, SPF_PASS=-0.001, T_SCC_BODY_TEXT_LINE=-0.01 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+alex.bennee=linaro.org@nongnu.org Sender: qemu-devel-bounces+alex.bennee=linaro.org@nongnu.org X-TUID: JqYkKqNoQzmX BALATON Zoltan writes: > On Sun, 25 Feb 2024, Philippe Mathieu-Daud=C3=A9 wrote: >> Rename "internal.h" as "ide_internal.h", and include > > Is there a convention about using underscore or dash in file names? The h= eaders Thomas added are using - as well as ahci-allwinner.c, only ahci_inte= rnal.h has _ (but there are others elsewhere such as pci_device.h). Maybe w= e should be consistent at least within IDE and this series is now a good op= portunity for renaming these headers to match. But it's just a small nit, t= hanks for picking this up. This is one of the many unnecessary inconsistencies we're inflicting on ourselves. We have more than 3600 file names containing '-', and more almost 2700 containing '_'. Bizarrely, 68 of them contain both. I strongly prefer '_' myself. Zoltan is making a local consistency argument for '-'. Let's use '-' here.