From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id B26D3C5478C for ; Mon, 26 Feb 2024 15:35:57 +0000 (UTC) Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id 3782F10E26B; Mon, 26 Feb 2024 15:35:57 +0000 (UTC) Authentication-Results: gabe.freedesktop.org; dkim=pass (2048-bit key; unprotected) header.d=intel.com header.i=@intel.com header.b="GEv905fr"; dkim-atps=neutral Received: from mgamail.intel.com (mgamail.intel.com [192.198.163.14]) by gabe.freedesktop.org (Postfix) with ESMTPS id BB46910E493 for ; Mon, 26 Feb 2024 15:35:54 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1708961755; x=1740497755; h=from:to:cc:subject:in-reply-to:references:date: message-id:mime-version:content-transfer-encoding; bh=DEFsTQYOxQB1RzK8jxBp8lvN1PzPps/TqPk/AWNcRnQ=; b=GEv905freVQyNS3OtTO3sWblzDzOpjUUiu1x0r/jLcUTQA44sAl+4DrY gO1/yM0B9YEvEC+U+LX76V0UHwjv4yRr0GPTC+cuMNYW0bJL/qsNikV8Z GYAJfhE46VmIiVCKv4hC6TF8DznMMGIib9AZTvkRdpB2+2tdKFxu1QXLa 9rjYOWtBk/OR3nZHQMXcNIQBsPfHRWqlyaz4MwGBA+68AvhGxcXsb13vm SudWFqBjqOFTD49Thd4l7KeGVMfQHMA0aIQvujf0lLCn3w5xw0n5V+Lh5 GS20wiCv+PHVhZ3INkum2mLw/Z7iqGf7YkFju+5gf49yESI4XFd4EweMl g==; X-IronPort-AV: E=McAfee;i="6600,9927,10996"; a="3417047" X-IronPort-AV: E=Sophos;i="6.06,185,1705392000"; d="scan'208";a="3417047" Received: from fmviesa007.fm.intel.com ([10.60.135.147]) by fmvoesa108.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 26 Feb 2024 07:35:54 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="6.06,185,1705392000"; d="scan'208";a="6579940" Received: from hibeid-mobl.amr.corp.intel.com (HELO localhost) ([10.252.46.254]) by fmviesa007-auth.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 26 Feb 2024 07:35:51 -0800 From: Jani Nikula To: Andy Shevchenko Cc: Ville =?utf-8?B?U3lyasOkbMOk?= , Rodrigo Vivi , intel-gfx@lists.freedesktop.org, Petr Mladek , Steven Rostedt , Rasmus Villemoes , Sergey Senozhatsky , linux-kernel@vger.kernel.org Subject: Re: [PATCH 01/12] drm/i915: Indicate which pipe failed the fastset check overall In-Reply-To: Organization: Intel Finland Oy - BIC 0357606-4 - Westendinkatu 7, 02160 Espoo References: <20240215164055.30585-1-ville.syrjala@linux.intel.com> <20240215164055.30585-2-ville.syrjala@linux.intel.com> <87bk83mfwp.fsf@intel.com> Date: Mon, 26 Feb 2024 17:35:51 +0200 Message-ID: <878r37me5k.fsf@intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-BeenThere: intel-gfx@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Intel graphics driver community testing & development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: intel-gfx-bounces@lists.freedesktop.org Sender: "Intel-gfx" On Mon, 26 Feb 2024, Andy Shevchenko wr= ote: > On Mon, Feb 26, 2024 at 04:57:58PM +0200, Jani Nikula wrote: >> On Fri, 23 Feb 2024, Ville Syrj=C3=A4l=C3=A4 wrote: >> > On Thu, Feb 22, 2024 at 04:46:12PM -0500, Rodrigo Vivi wrote: > > ... > >> > I think the proper solution would be to have actually >> > sensible conversion specifiers in the format string. >> > So instead of % we'd have something >> > more like %{drm_crtc} (or whatever color you want to throw >> > on that particular bikeshed). >>=20 >> Personally I suck at remembering even the standard printf conversion >> specifiers, let alone all the kernel extensions. I basically have to >> look them up every time. I'd really love some %{name} format for named >> pointer things. And indeed preferrably without the %p. Just %{name}. > > It will become something like %{name[:subextensions]}, where subextensions > is what we now have with different letters/numbers after %pX (X is a lett= er > which you proposed to have written as name AFAIU). Thanks, I appreciate it, a lot! But could you perhaps try to go with just clean %{name} only instead of adding [:subextensions] right away, please? I presume the suggestion comes from an implementation detail, and I guess it would be handy to reuse the current implementation for subextension. For example, %pb -> %{bitmap} and %pbl -> %{bitmap:l}. But really I think the better option would be for the latter to become, say, %{bitmap-list}. The goal here is to make them easy to remember and understand, without resorting to looking up the documentation! BR, Jani. > >> And then we could discuss adding support for drm specific things. I >> guess one downside is that the functions to do this would have to be in >> vsprintf.c instead of drm. Unless we add some code in drm for this >> that's always built-in. --=20 Jani Nikula, Intel