All of lore.kernel.org
 help / color / mirror / Atom feed
From: Mathieu Othacehe <m.othacehe@gmail.com>
To: Primoz Fiser <primoz.fiser@norik.com>
Cc: Peng Fan <peng.fan@nxp.com>,  Tom Rini <trini@konsulko.com>,
	 Stefano Babic <sbabic@denx.de>,
	 Fabio Estevam <festevam@gmail.com>,
	 "NXP i . MX U-Boot Team" <uboot-imx@nxp.com>,
	 Christoph Stoidner <c.stoidner@phytec.de>,
	 Wadim Egorov <w.egorov@phytec.de>,
	 Yannic Moog <Y.Moog@phytec.de>,
	 u-boot@lists.denx.de,  upstream@lists.phytec.de
Subject: Re: [PATCH v3] board: phytec: phycore-imx93: Add phyBOARD-Segin-i.MX93 support
Date: Tue, 30 Jan 2024 10:43:28 +0100	[thread overview]
Message-ID: <878r472m2n.fsf@gmail.com> (raw)
In-Reply-To: <9f20708a-eefb-4a27-a413-8a9f5a472788@norik.com> (Primoz Fiser's message of "Mon, 29 Jan 2024 11:24:38 +0100")


Hello,

> Please remove findfdt script.
>
> Not needed when you set fdt_file to CONFIG_DEFAULT_FDT_FILE above.

The reason I used findfdt is that CONFIG_DEFAULT_FDT_FILE is a string
so, we end up with:

--8<---------------cut here---------------start------------->8---
fdt_file="oftree"
--8<---------------cut here---------------end--------------->8---

which gives:

--8<---------------cut here---------------start------------->8---
u-boot=> run loadfdt
Failed to load '"oftree"'
--8<---------------cut here---------------end--------------->8---

whereas, if I set:

--8<---------------cut here---------------start------------->8---
u-boot=> setenv fdt_file oftree
u-boot=> run loadfdt           
24579 bytes read in 5 ms (4.7 MiB/s)
--8<---------------cut here---------------end--------------->8---

I then see three options: introduce an unstrigify macro, hardcode
fdt_file=oftree in the env file, or use the findfdt hack.

I'm not sure which one is the better?

I will fix all the other remarks in the v4.

Thanks,

Mathieu

  reply	other threads:[~2024-01-30 12:54 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-01-25 16:45 [PATCH v3] board: phytec: phycore-imx93: Add phyBOARD-Segin-i.MX93 support Mathieu Othacehe
2024-01-25 19:09 ` Fabio Estevam
2024-01-29 10:24 ` Primoz Fiser
2024-01-30  9:43   ` Mathieu Othacehe [this message]
2024-01-30 12:25     ` Primoz Fiser
2024-01-30 12:49       ` Mathieu Othacehe
2024-01-30 12:57         ` Tom Rini
2024-01-30 13:07           ` Mathieu Othacehe
2024-01-30 13:06         ` Primoz Fiser
2024-01-30 13:37           ` Mathieu Othacehe
2024-01-30 13:42             ` Primoz Fiser
2024-01-30 14:16               ` Mathieu Othacehe

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=878r472m2n.fsf@gmail.com \
    --to=m.othacehe@gmail.com \
    --cc=Y.Moog@phytec.de \
    --cc=c.stoidner@phytec.de \
    --cc=festevam@gmail.com \
    --cc=peng.fan@nxp.com \
    --cc=primoz.fiser@norik.com \
    --cc=sbabic@denx.de \
    --cc=trini@konsulko.com \
    --cc=u-boot@lists.denx.de \
    --cc=uboot-imx@nxp.com \
    --cc=upstream@lists.phytec.de \
    --cc=w.egorov@phytec.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.