From: Juan Quintela <quintela@redhat.com>
To: Tejus GK <tejus.gk@nutanix.com>
Cc: qemu-devel@nongnu.org, peterx@redhat.com, leobras@redhat.com
Subject: Re: [PATCH v5 1/2] migration/vmstate: Introduce vmstate_save_state_with_err
Date: Tue, 03 Oct 2023 14:39:55 +0200 [thread overview]
Message-ID: <878r8j7uck.fsf@secure.mitica> (raw)
In-Reply-To: <20231003065538.244752-2-tejus.gk@nutanix.com> (Tejus GK's message of "Tue, 3 Oct 2023 06:55:37 +0000")
Tejus GK <tejus.gk@nutanix.com> wrote:
> Currently, a few code paths exist in the function vmstate_save_state_v,
> which ultimately leads to a migration failure. However, an update in the
> current MigrationState for the error description is never done.
>
> vmstate.c somehow doesn't seem to allow the use of migrate_set_error due
> to some dependencies for unit tests. Hence, this patch introduces a new
> function vmstate_save_state_with_err, which will eventually propagate
> the error message to savevm.c where a migrate_set_error call can be
> eventually done.
>
> Acked-by: Peter Xu <peterx@redhat.com>
> Signed-off-by: Tejus GK <tejus.gk@nutanix.com>
Reviewed-by: Juan Quintela <quintela@redhat.com>
next prev parent reply other threads:[~2023-10-03 12:41 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-10-03 6:55 [PATCH v5 0/2] migration: Update error description outside migration.c Tejus GK
2023-10-03 6:55 ` [PATCH v5 1/2] migration/vmstate: Introduce vmstate_save_state_with_err Tejus GK
2023-10-03 12:39 ` Juan Quintela [this message]
2023-10-03 6:55 ` [PATCH v5 2/2] migration: Update error description outside migration.c Tejus GK
2023-10-03 12:44 ` Juan Quintela
2023-10-04 4:28 ` Tejus GK
2023-10-04 8:23 ` Juan Quintela
2023-10-04 12:15 ` Tejus GK
2023-10-04 12:43 ` Juan Quintela
2023-10-04 13:37 ` Juan Quintela
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=878r8j7uck.fsf@secure.mitica \
--to=quintela@redhat.com \
--cc=leobras@redhat.com \
--cc=peterx@redhat.com \
--cc=qemu-devel@nongnu.org \
--cc=tejus.gk@nutanix.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.