All of lore.kernel.org
 help / color / mirror / Atom feed
From: Peter Korsgaard <peter@korsgaard.com>
To: "Yann E. MORIN" <yann.morin.1998@free.fr>
Cc: Michael Hacker <mh@superbox.one>, buildroot@buildroot.org
Subject: Re: [Buildroot] opkg-utils binaries did not installed with make install-utils
Date: Sat, 30 Sep 2023 21:03:16 +0200	[thread overview]
Message-ID: <878r8n8owb.fsf@48ers.dk> (raw)
In-Reply-To: <20230423130519.GH2696@scaer> (Yann E. MORIN's message of "Sun, 23 Apr 2023 15:05:19 +0200")

>>>>> "Yann" == Yann E MORIN <yann.morin.1998@free.fr> writes:

 > Michael, All,
 > On 2023-04-19 05:22 +0200, Michael Hacker spake thusly:
 >> There seems to be something wrong in the
 >> opkg-utils.mk. install-utils does not run correctly and some tools
 >> are missing, e.g. opkg-utils.
 >> 
 >> I have a patch for it and after that everything is installed correctly:
 >> 
 >> diff --git a/package/opkg-utils/opkg-utils.mk b/package/opkg-utils/opkg-utils.mk
 >> index ad267c5c94..384a7323ee 100644
 >> --- a/buildroot/package/opkg-utils/opkg-utils.mk
 >> +++ b/buildroot/package/opkg-utils/opkg-utils.mk
 >> @@ -16.7 +16.7 @@ HOST_OPKG_UTILS_DEPENDENCIES = \
 >> host-xz
 >> 
 >> # Nothing to build; only scripts to install.
 >> -define OPKG_UTILS_INSTALL_CMDS
 >> +define OPKG_UTILS_INSTALL_TARGET_CMDS

 > Eh, good catch! ;-)

 > Can you please resend with a proper commit log, and your sign-off:

 >     package/opkg-utils: actually install to target

 >     Commit b9bf1c6535cb (package/opkg-utils: add opkg-utils as target
 >     pkg) mis-spelled the macro to install to target, most probably as a
 >     bad copy-paste from the host macro.

 >     Fix that.

 >     Signed-off-by: You Real Name <your-email>

That never happened, so I've pushed a fix myself.

-- 
Bye, Peter Korsgaard
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot

  reply	other threads:[~2023-09-30 19:03 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-04-19  3:22 [Buildroot] opkg-utils binaries did not installed with make install-utils Michael Hacker
2023-04-23 13:05 ` Yann E. MORIN
2023-09-30 19:03   ` Peter Korsgaard [this message]
2023-04-23 13:07 ` Yann E. MORIN

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=878r8n8owb.fsf@48ers.dk \
    --to=peter@korsgaard.com \
    --cc=buildroot@buildroot.org \
    --cc=mh@superbox.one \
    --cc=yann.morin.1998@free.fr \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.