From: Markus Armbruster <armbru@redhat.com>
To: "Cédric Le Goater" <clg@kaod.org>
Cc: Michael Tokarev <mjt@tls.msk.ru>,
qemu-ppc@nongnu.org, qemu-devel@nongnu.org,
Daniel Henrique Barboza <danielhb413@gmail.com>,
Nicholas Piggin <npiggin@gmail.com>
Subject: Re: [PATCH] target/ppc: Rename variables to avoid local variable shadowing in VUPKPX
Date: Fri, 29 Sep 2023 10:00:15 +0200 [thread overview]
Message-ID: <878r8pflyo.fsf@pond.sub.org> (raw)
In-Reply-To: <f74e6a0a-b78f-8924-6abf-42cbad6c69eb@kaod.org> ("Cédric Le Goater"'s message of "Sat, 23 Sep 2023 17:59:35 +0200")
Cédric Le Goater <clg@kaod.org> writes:
> On 9/23/23 10:25, Michael Tokarev wrote:
>> 23.09.2023 10:12, Cédric Le Goater:
>>
>>> --- a/target/ppc/int_helper.c
>>> +++ b/target/ppc/int_helper.c
>>> @@ -2022,11 +2022,11 @@ void helper_vsum4ubs(CPUPPCState *env, ppc_avr_t *r, ppc_avr_t *a, ppc_avr_t *b)
>>> for (i = 0; i < ARRAY_SIZE(r->u32); i++) { \
>>> uint16_t e = b->u16[hi ? i : i + 4]; \
>>> uint8_t a = (e >> 15) ? 0xff : 0; \
>>> - uint8_t r = (e >> 10) & 0x1f; \
>>> + uint8_t _r = (e >> 10) & 0x1f; \
>>> uint8_t g = (e >> 5) & 0x1f; \
>>> - uint8_t b = e & 0x1f; \
>>> + uint8_t _b = e & 0x1f; \
>> I'd suggest to rename all of them here to have the same pattern. Maybe.. :)
>
> or maybe use the field names from the ISA : VRT,VRA,VRB ?
Should I expect a respin?
If not, anyone ready to give an R-by as is?
next prev parent reply other threads:[~2023-09-29 8:01 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-09-23 7:12 [PATCH] target/ppc: Rename variables to avoid local variable shadowing in VUPKPX Cédric Le Goater
2023-09-23 8:25 ` Michael Tokarev
2023-09-23 15:59 ` Cédric Le Goater
2023-09-29 8:00 ` Markus Armbruster [this message]
2023-09-29 8:28 ` Cédric Le Goater
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=878r8pflyo.fsf@pond.sub.org \
--to=armbru@redhat.com \
--cc=clg@kaod.org \
--cc=danielhb413@gmail.com \
--cc=mjt@tls.msk.ru \
--cc=npiggin@gmail.com \
--cc=qemu-devel@nongnu.org \
--cc=qemu-ppc@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.