From: Peter Korsgaard <peter@korsgaard.com>
To: Thomas Petazzoni via buildroot <buildroot@buildroot.org>
Cc: Thomas Petazzoni <thomas.petazzoni@bootlin.com>
Subject: Re: [Buildroot] [PATCH] package/ne10: install shared libraries only when built
Date: Mon, 25 Sep 2023 15:49:59 +0200 [thread overview]
Message-ID: <878r8ucqgo.fsf@48ers.dk> (raw)
In-Reply-To: <20230921102857.375294-1-thomas.petazzoni@bootlin.com> (Thomas Petazzoni via buildroot's message of "Thu, 21 Sep 2023 12:28:56 +0200")
>>>>> "Thomas" == Thomas Petazzoni via buildroot <buildroot@buildroot.org> writes:
> The install to staging commands of the ne10 package are careful to
> install the shared libraries only if they are built, but we forgot to
> use the same care for the install to target commands, causing a build
> failure on BR2_STATIC_LIBS=y configurations as no shared library was
> built:
> cp: cannot stat '/home/autobuild/autobuild/instance-15/output-1/build/ne10-1.2.1/modules/libNE10*.so*': No such file or directory
> This commit fixes this by guarding the target installation commands to
> BR2_STATIC_LIBS being empty.
> The problem exists since the package was introduced in commit
> 318f3db0dcc052aa770ca57c143b5f7bc40cdaf3 ("ne10: new package"), a good
> 10 years ago. Most likely it was not seen for many years as this
> package is only available for ARM with NEON and AArch64, and we were
> not testing fully static builds, except for ARMv5 that don't have
> NEON. Now that we are doing more random testing, the problem started
> being visible.
> Fixes:
> http://autobuild.buildroot.net/results/45b2c1af052271bc2f1bb96544f138d29e4f7dfd/
> Signed-off-by: Thomas Petazzoni <thomas.petazzoni@bootlin.com>
Committed to 2023.02.x, 2023.05.x and 2023.08.x, thanks.
--
Bye, Peter Korsgaard
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot
prev parent reply other threads:[~2023-09-25 13:50 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-09-21 10:28 [Buildroot] [PATCH] package/ne10: install shared libraries only when built Thomas Petazzoni via buildroot
2023-09-21 18:26 ` Arnout Vandecappelle via buildroot
2023-09-25 13:49 ` Peter Korsgaard [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=878r8ucqgo.fsf@48ers.dk \
--to=peter@korsgaard.com \
--cc=buildroot@buildroot.org \
--cc=thomas.petazzoni@bootlin.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.