From: Olivier Dion via lttng-dev <lttng-dev@lists.lttng.org>
To: "Ondřej Surý" <ondrej@sury.org>, lttng-dev <lttng-dev@lists.lttng.org>
Subject: Re: [lttng-dev] TSAN build broken on master branch
Date: Thu, 21 Sep 2023 16:21:12 -0400 [thread overview]
Message-ID: <878r8zgtvr.fsf@laura> (raw)
In-Reply-To: <FA4E40F7-C16C-4872-9829-0643AA974B30@sury.org>
On Thu, 21 Sep 2023, Ondřej Surý via lttng-dev <lttng-dev@lists.lttng.org> wrote:
[...]
> It fails with:
>
> rculfhash.c:1189:2: error: address argument to atomic operation must be a pointer to integer ('typeof (node_next)' (aka 'struct cds_lfht_node **') invalid)
> uatomic_or_mo(node_next, REMOVED_FLAG, CMM_RELEASE);
> ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
> ../include/urcu/uatomic/builtins-generic.h:123:10: note: expanded from macro 'uatomic_or_mo'
> (void) __atomic_or_fetch(cmm_cast_volatile(addr), mask, \
> ^ ~~~~~~~~~~~~~~~~~~~~~~~
> rculfhash.c:1440:3: error: address argument to atomic operation must be a pointer to integer ('typeof (fini_bucket_next)' (aka 'struct cds_lfht_node **') invalid)
> uatomic_or(fini_bucket_next, REMOVED_FLAG);
> ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
> ../include/urcu/uatomic/builtins-generic.h:130:2: note: expanded from macro 'uatomic_or'
> uatomic_or_mo(addr, mask, CMM_RELAXED)
> ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
> ../include/urcu/uatomic/builtins-generic.h:123:10: note: expanded from macro 'uatomic_or_mo'
> (void) __atomic_or_fetch(cmm_cast_volatile(addr), mask, \
> ^ ~~~~~~~~~~~~~~~~~~~~~~~
Eh I thought we fixed that. Clang is very strict about these things.
You can apply the following
<https://review.lttng.org/c/userspace-rcu/+/10911/1>. That ought to fix
the issue until we merge the patch.
--
Olivier Dion
EfficiOS Inc.
https://www.efficios.com
_______________________________________________
lttng-dev mailing list
lttng-dev@lists.lttng.org
https://lists.lttng.org/cgi-bin/mailman/listinfo/lttng-dev
next prev parent reply other threads:[~2023-09-21 20:21 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-09-21 18:34 [lttng-dev] TSAN build broken on master branch Ondřej Surý via lttng-dev
2023-09-21 20:21 ` Olivier Dion via lttng-dev [this message]
2023-09-23 6:03 ` Mathieu Desnoyers via lttng-dev
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=878r8zgtvr.fsf@laura \
--to=lttng-dev@lists.lttng.org \
--cc=odion@efficios.com \
--cc=ondrej@sury.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.