From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from alsa0.perex.cz (alsa0.perex.cz [77.48.224.243]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 0D762EE4993 for ; Sun, 20 Aug 2023 09:34:05 +0000 (UTC) Received: from alsa1.perex.cz (alsa1.perex.cz [207.180.221.201]) (using TLSv1.2 with cipher ADH-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by alsa0.perex.cz (Postfix) with ESMTPS id B856220C; Sun, 20 Aug 2023 11:33:12 +0200 (CEST) DKIM-Filter: OpenDKIM Filter v2.11.0 alsa0.perex.cz B856220C DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=alsa-project.org; s=default; t=1692524042; bh=kDnTcqSTQdlLHPpQOf5RRj+TVFls2LmJQQQrfzPriCk=; h=From:To:Cc:Subject:In-Reply-To:References:Date:List-Id: List-Archive:List-Help:List-Owner:List-Post:List-Subscribe: List-Unsubscribe:From; b=kwhZjWJiTOifqEpi/+NJlt60A+Ktjta4QjtFYHpH9qJwfnRY6cy1dLdVt3Qm6Ip7R OnyjX8NKY1E/S+ruRLtbtScQTZGMXuO7wkyg3rf3z2oIG3pux6G6r9f93KSWTzHamf e4LvU7hLx4/6jYAKDBPJEh3Cmr9saOli5G6r10YA= Received: by alsa1.perex.cz (Postfix, from userid 50401) id 3F46EF80199; Sun, 20 Aug 2023 11:33:12 +0200 (CEST) Received: from mailman-core.alsa-project.org (mailman-core.alsa-project.org [10.254.200.10]) by alsa1.perex.cz (Postfix) with ESMTP id 8FACAF80199; Sun, 20 Aug 2023 11:33:11 +0200 (CEST) Received: by alsa1.perex.cz (Postfix, from userid 50401) id CD072F80199; Sun, 20 Aug 2023 11:33:03 +0200 (CEST) Received: from mail.mutex.one (mail.mutex.one [62.77.152.124]) (using TLSv1.2 with cipher ADH-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by alsa1.perex.cz (Postfix) with ESMTPS id 61CAEF80027 for ; Sun, 20 Aug 2023 11:32:57 +0200 (CEST) DKIM-Filter: OpenDKIM Filter v2.11.0 alsa1.perex.cz 61CAEF80027 Authentication-Results: alsa1.perex.cz; dkim=pass (1024-bit key, unprotected) header.d=mutex.one header.i=@mutex.one header.a=rsa-sha256 header.s=default header.b=fViGGRzX Received: from localhost (localhost.localdomain [127.0.0.1]) by mail.mutex.one (Postfix) with ESMTP id 8074516C004A; Sun, 20 Aug 2023 12:32:56 +0300 (EEST) X-Virus-Scanned: Debian amavisd-new at mail.mutex.one Received: from mail.mutex.one ([127.0.0.1]) by localhost (mail.mutex.one [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id zVhDgEjmY7wN; Sun, 20 Aug 2023 12:32:55 +0300 (EEST) From: Marian Postevca DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=mutex.one; s=default; t=1692523975; bh=kDnTcqSTQdlLHPpQOf5RRj+TVFls2LmJQQQrfzPriCk=; h=From:To:Cc:Subject:In-Reply-To:References:Date:From; b=fViGGRzXCd7v5DsOstN+pqTrYAkAg0Mae2L6QgAcM8zUeelBB64Kq3LLNCcKY4Wug 0J76mfBHwpyBXU44E7hTzxipE58kkhGkXBYd3SrC6pbpx3UQvB2QJ9VjBK9cWkVxAs 469J+R8h41J5X1jKqxUaS3ayCd0HVWWhGc3EboUA= To: Mark Brown Cc: =?utf-8?B?5rKI5LiA6LaF?= , yangxiaohua , Zhu Ning , Takashi Iwai , Liam Girdwood , Jaroslav Kysela , linux-kernel@vger.kernel.org, alsa-devel@alsa-project.org Subject: Re: [PATCH 3/4] ASoC: amd: acp: Add machine driver that enables sound for systems with a ES8336 codec In-Reply-To: <8cddbe1c-20d7-4b8f-ba02-f86bbb5a54c5@sirena.org.uk> References: <141a3320-ff65-459f-9d00-c8bed691dcfc@sirena.org.uk> <87lejpwxzf.fsf@mutex.one> <87ttycjyw3.fsf@mutex.one> <87r0t9uc08.fsf@mutex.one> <87zg2pxtog.fsf@mutex.one> <87o7j5b9bd.fsf@mutex.one> <8cddbe1c-20d7-4b8f-ba02-f86bbb5a54c5@sirena.org.uk> Date: Sun, 20 Aug 2023 12:32:52 +0300 Message-ID: <878ra683ej.fsf@mutex.one> MIME-Version: 1.0 Content-Type: text/plain Message-ID-Hash: TIIAZMB3EV73LHGHY2YBRN23A2DTBWWH X-Message-ID-Hash: TIIAZMB3EV73LHGHY2YBRN23A2DTBWWH X-MailFrom: posteuca@mutex.one X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; emergency; loop; banned-address; member-moderation; header-match-alsa-devel.alsa-project.org-0; header-match-alsa-devel.alsa-project.org-1; nonmember-moderation; administrivia; implicit-dest; max-recipients; max-size; news-moderation; no-subject; digests; suspicious-header X-Mailman-Version: 3.3.8 Precedence: list List-Id: "Alsa-devel mailing list for ALSA developers - http://www.alsa-project.org" Archived-At: List-Archive: List-Help: List-Owner: List-Post: List-Subscribe: List-Unsubscribe: Mark Brown writes: > You'd need to pull the relevant supplies out of DAPM and handle them in > the CODEC suspend/resume callback. Can you please suggest an approach that would be acceptable to you? In the original patch series I sent, you didn't agree to the approach to disable the jack detection in the machine driver suspend callback and re-enable it in the resume callback. You suggested to do it in the CODEC suspend/resume callbacks. As I explained previously (and Zhu Ning confirmed in his email) this wouldn't work, since as long as the jack detection is enabled, the CODEC suspend/resume callbacks do not get called. The second option (which you also do not seem to agree) is to enable idle_bias_on. So I don't know how to continue with this and merge this new machine driver.