From: Vinicius Costa Gomes <vinicius.gomes@intel.com>
To: Tony Nguyen <anthony.l.nguyen@intel.com>,
intel-wired-lan@lists.osuosl.org
Cc: vladimir.oltean@nxp.com, richardcochran@gmail.com,
kurt@linutronix.de, jesse.brandeburg@intel.com
Subject: Re: [Intel-wired-lan] [PATCH iwl-next v2] igc: Add support for multiple in-flight TX timestamps
Date: Fri, 28 Jul 2023 15:22:10 -0700 [thread overview]
Message-ID: <878raz3cdp.fsf@intel.com> (raw)
In-Reply-To: <0433cc77-a922-abd7-5cdb-e35c4fb57c76@intel.com>
Tony Nguyen <anthony.l.nguyen@intel.com> writes:
> On 7/26/2023 5:06 PM, Vinicius Costa Gomes wrote:
>
> ...
>
>> /**
>> * igc_ptp_tx_hwtstamp - utility function which checks for TX time stamp
>> * @adapter: Board private structure
>> + * @mask: bitmask of which timestamp registers are ready
>
> Probably a remnant of previous work but...
>
> igc_ptp.c:761: warning: Excess function parameter 'mask' description in
> 'igc_ptp_tx_hwtstamp'
>
Will fix.
>> *
>> - * If we were asked to do hardware stamping and such a time stamp is
>> - * available, then it must have been for this skb here because we only
>> - * allow only one such packet into the queue.
>> + * Check against the ready mask for which of the timestamp register
>> + * sets are ready to be retrieved, then retrieve that and notify the
>> + * rest of the stack.
>> *
>> * Context: Expects adapter->ptp_tx_lock to be held by caller.
>> */
>> static void igc_ptp_tx_hwtstamp(struct igc_adapter *adapter)
Cheers,
--
Vinicius
_______________________________________________
Intel-wired-lan mailing list
Intel-wired-lan@osuosl.org
https://lists.osuosl.org/mailman/listinfo/intel-wired-lan
prev parent reply other threads:[~2023-07-28 22:29 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-07-27 0:06 [Intel-wired-lan] [PATCH iwl-next v2] igc: Add support for multiple in-flight TX timestamps Vinicius Costa Gomes
2023-07-28 22:01 ` Tony Nguyen
2023-07-28 22:22 ` Vinicius Costa Gomes [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=878raz3cdp.fsf@intel.com \
--to=vinicius.gomes@intel.com \
--cc=anthony.l.nguyen@intel.com \
--cc=intel-wired-lan@lists.osuosl.org \
--cc=jesse.brandeburg@intel.com \
--cc=kurt@linutronix.de \
--cc=richardcochran@gmail.com \
--cc=vladimir.oltean@nxp.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.