From: Mattijs Korpershoek <mkorpershoek@baylibre.com>
To: Simon Glass <sjg@chromium.org>,
U-Boot Mailing List <u-boot@lists.denx.de>
Cc: Bin Meng <bmeng.cn@gmail.com>, Simon Glass <sjg@chromium.org>
Subject: Re: [PATCH 4/8] bootstd: Correct creating of bootdev sibling
Date: Fri, 28 Jul 2023 09:56:08 +0200 [thread overview]
Message-ID: <878rb04gh3.fsf@baylibre.com> (raw)
In-Reply-To: <20230728023755.680278-5-sjg@chromium.org>
On jeu., juil. 27, 2023 at 20:37, Simon Glass <sjg@chromium.org> wrote:
> Use the correct function here, since there may be multiple IDE devices
> available.
>
> Signed-off-by: Simon Glass <sjg@chromium.org>
Reviewed-by: Mattijs Korpershoek <mkorpershoek@baylibre.com>
> ---
>
> drivers/block/ide.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/block/ide.c b/drivers/block/ide.c
> index 89201dd4d229..c698f9cbd558 100644
> --- a/drivers/block/ide.c
> +++ b/drivers/block/ide.c
> @@ -1059,9 +1059,9 @@ static int ide_probe(struct udevice *udev)
> desc->lba48 = pdesc.lba48;
> desc->type = pdesc.type;
>
> - ret = bootdev_setup_for_dev(udev, "ide_bootdev");
> + ret = bootdev_setup_for_sibling_blk(blk, "ide_bootdev");
> if (ret)
> - return log_msg_ret("bootdev", ret);
> + return log_msg_ret("bd", ret);
> }
>
> return 0;
> --
> 2.41.0.487.g6d72f3e995-goog
next prev parent reply other threads:[~2023-07-28 7:56 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-07-28 2:37 [PATCH 0/8] x86: Improve bootstd support Simon Glass
2023-07-28 2:37 ` [PATCH 1/8] usb: Return -ENOENT when no devices are found Simon Glass
2023-07-28 2:37 ` [PATCH 2/8] lib: Suppress E when writing error-string output Simon Glass
2023-07-28 2:37 ` [PATCH 3/8] bootstd: Rename bootdev_setup_sibling_blk() Simon Glass
2023-07-28 8:00 ` Mattijs Korpershoek
2023-07-31 17:08 ` Simon Glass
2023-07-28 2:37 ` [PATCH 4/8] bootstd: Correct creating of bootdev sibling Simon Glass
2023-07-28 7:56 ` Mattijs Korpershoek [this message]
2023-07-28 2:37 ` [PATCH 5/8] bootstd: Add some more debugging in the bootdev uclass Simon Glass
2023-07-28 2:37 ` [PATCH 6/8] x86: coreboot: Add IDE and SATA Simon Glass
2023-07-28 2:37 ` [PATCH 7/8] x86: coreboot: Enable standard boot Simon Glass
2023-07-28 2:37 ` [PATCH 8/8] x86: coreboot: Enable support for CBFS Simon Glass
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=878rb04gh3.fsf@baylibre.com \
--to=mkorpershoek@baylibre.com \
--cc=bmeng.cn@gmail.com \
--cc=sjg@chromium.org \
--cc=u-boot@lists.denx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.