From: Kalle Valo <kvalo@kernel.org>
To: Neal Sidhwaney <nealsid@gmail.com>
Cc: linux-wireless@vger.kernel.org, brcm80211-dev-list.pdl@broadcom.com
Subject: Re: [PATCH v2] wifi: brcmfmac: Detect corner error case earlier with log
Date: Fri, 02 Jun 2023 08:32:07 +0300 [thread overview]
Message-ID: <878rd2jup4.fsf@kernel.org> (raw)
In-Reply-To: <20230601054034.43692-1-nealsid@gmail.com> (Neal Sidhwaney's message of "Thu, 1 Jun 2023 01:40:36 -0400")
Neal Sidhwaney <nealsid@gmail.com> writes:
> In some corner cases, an I/O read can fail and return -1, and this
> patch detects this slightly earlier than is done today and logs an
> appropriate message.
>
> Signed-off-by: Neal Sidhwaney <nealsid@gmail.com>
The formatting seems to be correct now, at least patchwork looks ok:
https://patchwork.kernel.org/project/linux-wireless/patch/20230601054034.43692-1-nealsid@gmail.com/
But the commit log should always answer to the question "why?". Is there
a specific reason why you want to do it earlier?
> @@ -980,6 +981,11 @@ static int brcmf_chip_recognition(struct brcmf_chip_priv *ci)
> */
> regdata = ci->ops->read32(ci->ctx,
> CORE_CC_REG(ci->pub.enum_base, chipid));
> + if (regdata == READ_FAILED) {
> + brcmf_err("MMIO read failed: 0x%08x\n", regdata);
> + return -ENODEV;
> + }
Indentation here does not look correct, did you run checkpatch?
--
https://patchwork.kernel.org/project/linux-wireless/list/
https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches
next prev parent reply other threads:[~2023-06-02 5:32 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-06-01 5:40 [PATCH v2] wifi: brcmfmac: Detect corner error case earlier with log Neal Sidhwaney
2023-06-02 5:32 ` Kalle Valo [this message]
2023-06-03 6:07 ` Neal Sidhwaney
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=878rd2jup4.fsf@kernel.org \
--to=kvalo@kernel.org \
--cc=brcm80211-dev-list.pdl@broadcom.com \
--cc=linux-wireless@vger.kernel.org \
--cc=nealsid@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.