From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from smtp1.osuosl.org (smtp1.osuosl.org [140.211.166.138]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id BB599C77B7A for ; Tue, 30 May 2023 22:33:10 +0000 (UTC) Received: from localhost (localhost [127.0.0.1]) by smtp1.osuosl.org (Postfix) with ESMTP id 3EFCC81F4E; Tue, 30 May 2023 22:33:10 +0000 (UTC) DKIM-Filter: OpenDKIM Filter v2.11.0 smtp1.osuosl.org 3EFCC81F4E DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=osuosl.org; s=default; t=1685485990; bh=XqaOyFJts6dosrYToEzrmzUOaAsy793IQ53drKjtAzI=; h=From:To:In-Reply-To:References:Date:Subject:List-Id: List-Unsubscribe:List-Archive:List-Post:List-Help:List-Subscribe: Cc:From; b=b31rtESV7ovHPImnKWQmp3StjA8GN9odKtm3pAVSW5i5VbxAAyDcRx+V9b32LUz4f 4k214m4CSHNKG23OeLAMOu5pwUeJhjemFZ3iMY1mS/amPOf/v5iATzmGLhO/ZOI9Fj cENX/MkoN2VurmDkqY3O+MdaPdNzhEyx/O7tw83Dji1jm5ECEFxTNVnYuy3vOktPca 0e7eT2Q1S5HIIe2ZIHIXKu3sPkD/8QiROS3XlFoPlDGz1tDunc7bMrAkwr1aogXc2L 56espwD/DF/0N7WTwoujYQKpL+IbdQsNuGD8pRGL5ji/DbAZdq8lVYAlP1SUF8sF5D jnUCWMiCOnuqg== X-Virus-Scanned: amavisd-new at osuosl.org Received: from smtp1.osuosl.org ([127.0.0.1]) by localhost (smtp1.osuosl.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id jfKqZfAbIgD4; Tue, 30 May 2023 22:33:09 +0000 (UTC) Received: from ash.osuosl.org (ash.osuosl.org [140.211.166.34]) by smtp1.osuosl.org (Postfix) with ESMTP id 5BF4B81B3E; Tue, 30 May 2023 22:33:09 +0000 (UTC) DKIM-Filter: OpenDKIM Filter v2.11.0 smtp1.osuosl.org 5BF4B81B3E Received: from smtp3.osuosl.org (smtp3.osuosl.org [140.211.166.136]) by ash.osuosl.org (Postfix) with ESMTP id C6D341BF35C for ; Tue, 30 May 2023 22:33:07 +0000 (UTC) Received: from localhost (localhost [127.0.0.1]) by smtp3.osuosl.org (Postfix) with ESMTP id AAB3660FB1 for ; Tue, 30 May 2023 22:33:07 +0000 (UTC) DKIM-Filter: OpenDKIM Filter v2.11.0 smtp3.osuosl.org AAB3660FB1 X-Virus-Scanned: amavisd-new at osuosl.org Received: from smtp3.osuosl.org ([127.0.0.1]) by localhost (smtp3.osuosl.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id Y8mS1ayh-zIg for ; Tue, 30 May 2023 22:33:05 +0000 (UTC) X-Greylist: domain auto-whitelisted by SQLgrey-1.8.0 DKIM-Filter: OpenDKIM Filter v2.11.0 smtp3.osuosl.org 2D08560F97 Received: from mga03.intel.com (mga03.intel.com [134.134.136.65]) by smtp3.osuosl.org (Postfix) with ESMTPS id 2D08560F97 for ; Tue, 30 May 2023 22:33:04 +0000 (UTC) X-IronPort-AV: E=McAfee;i="6600,9927,10726"; a="358322061" X-IronPort-AV: E=Sophos;i="6.00,205,1681196400"; d="scan'208";a="358322061" Received: from orsmga005.jf.intel.com ([10.7.209.41]) by orsmga103.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 30 May 2023 15:33:03 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=McAfee;i="6600,9927,10726"; a="880914492" X-IronPort-AV: E=Sophos;i="6.00,205,1681196400"; d="scan'208";a="880914492" Received: from vcostago-desk1.jf.intel.com (HELO vcostago-desk1) ([10.54.70.17]) by orsmga005-auth.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 30 May 2023 15:33:02 -0700 From: Vinicius Costa Gomes To: Vladimir Oltean In-Reply-To: <20230530213252.pddrmwgppneawmht@skbuf> References: <20230530091948.1408477-1-vladimir.oltean@nxp.com> <20230530091948.1408477-2-vladimir.oltean@nxp.com> <87edmxv7x2.fsf@intel.com> <20230530213252.pddrmwgppneawmht@skbuf> Date: Tue, 30 May 2023 15:33:02 -0700 Message-ID: <878rd5v49t.fsf@intel.com> MIME-Version: 1.0 X-Mailman-Original-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1685485985; x=1717021985; h=from:to:cc:subject:in-reply-to:references:date: message-id:mime-version; bh=VABDFdCJy0Ud+Ks8o/SFbThuZCncKrRivw4ObAAYIR8=; b=P+kkw8dYQD+M0bIFBD1IBW+RdX870JA2uZdwRybdWDIMrH9HK+Ct3hPV 6bN3e9PR06zpcBztXTt8X5llR7CR5uJ/D3bDapn9dLMkjQq6hC/gBvIsH 1kalHg4bCQW6xbbvpGZaeZLuydg7NDweUxAvMIKZkb6h0xqpAuVfnkpkZ Uu8+gZJMwrkR1yOkXfbURBFMBszeihhHx0xrUaioXwEzwko4179P846Dx EYdQTjtx5YOZVLEktoyllgFVyHKKQ0cnrQnsmE4IrOtXTv/IZZdBJUZeM w0aCavBOI5t6JOyj69uN4WCpNHbgCx9CgkqdOB5DvWKW573gRvYgkMLSx Q==; X-Mailman-Original-Authentication-Results: smtp3.osuosl.org; dkim=pass (2048-bit key) header.d=intel.com header.i=@intel.com header.a=rsa-sha256 header.s=Intel header.b=P+kkw8dY Subject: Re: [Intel-wired-lan] [PATCH net-next 1/5] net/sched: taprio: don't overwrite "sch" variable in taprio_dump_class_stats() X-BeenThere: intel-wired-lan@osuosl.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Intel Wired Ethernet Linux Kernel Driver Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Andrew Lunn , Alexandre Belloni , Ferenc Fejes , Kurt Kanzenbach , Alexandre Torgue , Eric Dumazet , Tony Nguyen , Cong Wang , Gerhard Engleder , UNGLinuxDriver@microchip.com, Horatiu Vultur , Florian Fainelli , Xiaoliang Yang , Jesse Brandeburg , Mohammad Athari Bin Ismail , intel-wired-lan@lists.osuosl.org, Jakub Kicinski , Paolo Abeni , Pranavi Somisetty , Jiri Pirko , Jamal Hadi Salim , Roger Quadros , Claudiu Manoil , Giuseppe Cavallaro , Michael Sit Wei Hong , Harini Katakam , netdev@vger.kernel.org, linux-kernel@vger.kernel.org, Jose Abreu , Oleksij Rempel , Maxime Coquelin , "David S. Miller" Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: intel-wired-lan-bounces@osuosl.org Sender: "Intel-wired-lan" Vladimir Oltean writes: > On Tue, May 30, 2023 at 02:14:17PM -0700, Vinicius Costa Gomes wrote: >> But I have a suggestion, this "taprio_queue_get() -> >> dev_queue->qdisc_sleeping()" dance should have the same result as >> calling 'taprio_leaf()'. >> >> I am thinking of using taprio_leaf() here and in taprio_dump_class(). >> Could be a separate commit. > > Got it, you want to consolidate the dev_queue->qdisc_sleeping pattern. > Since taprio_dump_class() could benefit from the consolidation too, they > could really be both converted separately. Or I could also handle that > in this patch set, if I need to resend it. Exactly. Both options sound great. Cheers, -- Vinicius _______________________________________________ Intel-wired-lan mailing list Intel-wired-lan@osuosl.org https://lists.osuosl.org/mailman/listinfo/intel-wired-lan From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id B3F4EC7EE23 for ; Tue, 30 May 2023 22:33:09 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S233643AbjE3WdI (ORCPT ); Tue, 30 May 2023 18:33:08 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:50380 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229946AbjE3WdG (ORCPT ); Tue, 30 May 2023 18:33:06 -0400 Received: from mga03.intel.com (mga03.intel.com [134.134.136.65]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 2D91093; Tue, 30 May 2023 15:33:05 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1685485985; x=1717021985; h=from:to:cc:subject:in-reply-to:references:date: message-id:mime-version; bh=VABDFdCJy0Ud+Ks8o/SFbThuZCncKrRivw4ObAAYIR8=; b=P+kkw8dYQD+M0bIFBD1IBW+RdX870JA2uZdwRybdWDIMrH9HK+Ct3hPV 6bN3e9PR06zpcBztXTt8X5llR7CR5uJ/D3bDapn9dLMkjQq6hC/gBvIsH 1kalHg4bCQW6xbbvpGZaeZLuydg7NDweUxAvMIKZkb6h0xqpAuVfnkpkZ Uu8+gZJMwrkR1yOkXfbURBFMBszeihhHx0xrUaioXwEzwko4179P846Dx EYdQTjtx5YOZVLEktoyllgFVyHKKQ0cnrQnsmE4IrOtXTv/IZZdBJUZeM w0aCavBOI5t6JOyj69uN4WCpNHbgCx9CgkqdOB5DvWKW573gRvYgkMLSx Q==; X-IronPort-AV: E=McAfee;i="6600,9927,10726"; a="358322047" X-IronPort-AV: E=Sophos;i="6.00,205,1681196400"; d="scan'208";a="358322047" Received: from orsmga005.jf.intel.com ([10.7.209.41]) by orsmga103.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 30 May 2023 15:33:03 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=McAfee;i="6600,9927,10726"; a="880914492" X-IronPort-AV: E=Sophos;i="6.00,205,1681196400"; d="scan'208";a="880914492" Received: from vcostago-desk1.jf.intel.com (HELO vcostago-desk1) ([10.54.70.17]) by orsmga005-auth.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 30 May 2023 15:33:02 -0700 From: Vinicius Costa Gomes To: Vladimir Oltean Cc: netdev@vger.kernel.org, "David S. Miller" , Eric Dumazet , Jakub Kicinski , Paolo Abeni , Jamal Hadi Salim , Cong Wang , Jiri Pirko , Kurt Kanzenbach , Gerhard Engleder , Amritha Nambiar , Ferenc Fejes , Xiaoliang Yang , Roger Quadros , Pranavi Somisetty , Harini Katakam , Giuseppe Cavallaro , Alexandre Torgue , Michael Sit Wei Hong , Mohammad Athari Bin Ismail , Oleksij Rempel , Jacob Keller , linux-kernel@vger.kernel.org, Andrew Lunn , Florian Fainelli , Claudiu Manoil , Alexandre Belloni , UNGLinuxDriver@microchip.com, Jesse Brandeburg , Tony Nguyen , Horatiu Vultur , Jose Abreu , Maxime Coquelin , intel-wired-lan@lists.osuosl.org, Muhammad Husaini Zulkifli Subject: Re: [PATCH net-next 1/5] net/sched: taprio: don't overwrite "sch" variable in taprio_dump_class_stats() In-Reply-To: <20230530213252.pddrmwgppneawmht@skbuf> References: <20230530091948.1408477-1-vladimir.oltean@nxp.com> <20230530091948.1408477-2-vladimir.oltean@nxp.com> <87edmxv7x2.fsf@intel.com> <20230530213252.pddrmwgppneawmht@skbuf> Date: Tue, 30 May 2023 15:33:02 -0700 Message-ID: <878rd5v49t.fsf@intel.com> MIME-Version: 1.0 Content-Type: text/plain Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Vladimir Oltean writes: > On Tue, May 30, 2023 at 02:14:17PM -0700, Vinicius Costa Gomes wrote: >> But I have a suggestion, this "taprio_queue_get() -> >> dev_queue->qdisc_sleeping()" dance should have the same result as >> calling 'taprio_leaf()'. >> >> I am thinking of using taprio_leaf() here and in taprio_dump_class(). >> Could be a separate commit. > > Got it, you want to consolidate the dev_queue->qdisc_sleeping pattern. > Since taprio_dump_class() could benefit from the consolidation too, they > could really be both converted separately. Or I could also handle that > in this patch set, if I need to resend it. Exactly. Both options sound great. Cheers, -- Vinicius