Re: [RFC PATCH v2 2/5] virtio-balloon: device has Working Set Reporting

[Markus Armbruster <armbru@redhat.com>]

"T.J. Alumbaugh" <talumbau@google.com> writes:

>  - working_set_vq to receive Working Set reports from guest
>  - notification_vq to send config or request to guest
>  - add working set as object property on device
>
> Signed-off-by: T.J. Alumbaugh <talumbau@google.com>

[...]

> diff --git a/qapi/misc.json b/qapi/misc.json
> index ff070ec828..4ba8c74b64 100644
> --- a/qapi/misc.json
> +++ b/qapi/misc.json
> @@ -550,6 +550,32 @@
>   'returns': ['CommandLineOptionInfo'],
>   'allow-preconfig': true}
>  
> +##
> +# @MemoryBin:
> +#
> +# A bin of memory with a size in bytes. File-backed and
> +# anonymous memory are tracked separately.
> +#
> +# @anon: number of bytes of anonymous memory
> +# @file: number of bytes of file-backed memory

Please format like

   # A bin of memory with a size in bytes.  File-backed and anonymous
   # memory are tracked separately.
   #
   # @anon: number of bytes of anonymous memory
   #
   # @file: number of bytes of file-backed memory

to blend in with recent commit a937b6aa739 (qapi: Reformat doc comments
to conform to current conventions).

Separating member sections with blank lines helps with catching certain
errors.  rST loves to surprise...

> +##
> +{ 'struct': 'MemoryBin',
> +  'data': { 'anon': 'uint64',
> +            'file': 'uint64' } }
> +

[...]