From: Takashi Iwai <tiwai@suse.de>
To: Oswald Buddenhagen <oswald.buddenhagen@gmx.de>
Cc: alsa-devel@alsa-project.org, Jaroslav Kysela <perex@perex.cz>
Subject: Re: [PATCH v2 1/4] ALSA: emu10k1: automate encoding of sub-register definitions
Date: Mon, 15 May 2023 22:01:25 +0200 [thread overview]
Message-ID: <878rdppdnu.wl-tiwai@suse.de> (raw)
In-Reply-To: <20230514170323.3408798-1-oswald.buddenhagen@gmx.de>
On Sun, 14 May 2023 19:03:20 +0200,
Oswald Buddenhagen wrote:
>
> The idea to encode the bitfield manipulation in the register address is
> quite clever, but doing that by hand is ugly and error-prone. So derive
> it automatically from the mask instead.
>
> Macros cannot #define other macros, so we now declare enums instead.
>
> This also adds macros for decoding the register definitions. These will
> be used by later commits.
>
> Signed-off-by: Oswald Buddenhagen <oswald.buddenhagen@gmx.de>
> ---
> v2: added comments
Applied all four patches now. Thanks.
Takashi
prev parent reply other threads:[~2023-05-15 20:02 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-05-14 17:03 [PATCH v2 1/4] ALSA: emu10k1: automate encoding of sub-register definitions Oswald Buddenhagen
2023-05-14 17:03 ` [PATCH v2 2/4] ALSA: emu10k1: validate parameters of snd_emu10k1_ptr_{read,write}() Oswald Buddenhagen
2023-05-14 17:03 ` [PATCH v2 3/4] ALSA: emu10k1: merge common paths in snd_emu10k1_ptr_{read,write}() Oswald Buddenhagen
2023-05-14 17:03 ` [PATCH v2 4/4] ALSA: emu10k1: optimize mask calculation in snd_emu10k1_ptr_read() Oswald Buddenhagen
2023-05-15 20:01 ` Takashi Iwai [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=878rdppdnu.wl-tiwai@suse.de \
--to=tiwai@suse.de \
--cc=alsa-devel@alsa-project.org \
--cc=oswald.buddenhagen@gmx.de \
--cc=perex@perex.cz \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.