From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from alsa0.perex.cz (alsa0.perex.cz [77.48.224.243]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 290E9C77B7F for ; Fri, 12 May 2023 07:23:31 +0000 (UTC) Received: from alsa1.perex.cz (alsa1.perex.cz [207.180.221.201]) (using TLSv1.2 with cipher ADH-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by alsa0.perex.cz (Postfix) with ESMTPS id 8A09F14E; Fri, 12 May 2023 09:22:38 +0200 (CEST) DKIM-Filter: OpenDKIM Filter v2.11.0 alsa0.perex.cz 8A09F14E DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=alsa-project.org; s=default; t=1683876208; bh=11Zcu5ahC1bCnQseZYgyt0ODSbBgTr0bpG96NembgH0=; h=Date:From:To:Cc:Subject:In-Reply-To:References:List-Id: List-Archive:List-Help:List-Owner:List-Post:List-Subscribe: List-Unsubscribe:From; b=QhaAWg9lgR6ZIqrmAeLXAvRdgxtCW7fZikhgbMwQKiZ4HA0G9xNse0/30/MZmSDU4 ZpU/jUhEa2BtNZy7fYbk8yoiYtXsN5rCfB9wvTonAPRgQsl3ESDOukc0GlZ1moPpAA Umi1jUBM+sdXUuhUy2Q2H2qnFaP28oU3F8LfQB98= Received: by alsa1.perex.cz (Postfix, from userid 50401) id 96B16F8014C; Fri, 12 May 2023 09:22:06 +0200 (CEST) Received: from mailman-core.alsa-project.org (mailman-core.alsa-project.org [10.254.200.10]) by alsa1.perex.cz (Postfix) with ESMTP id 39FD5F80542; Fri, 12 May 2023 09:22:06 +0200 (CEST) Received: by alsa1.perex.cz (Postfix, from userid 50401) id 3B02AF8052E; Fri, 12 May 2023 09:22:03 +0200 (CEST) Received: from smtp-out2.suse.de (smtp-out2.suse.de [IPv6:2001:67c:2178:6::1d]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by alsa1.perex.cz (Postfix) with ESMTPS id 890A4F802E8 for ; Fri, 12 May 2023 09:21:58 +0200 (CEST) DKIM-Filter: OpenDKIM Filter v2.11.0 alsa1.perex.cz 890A4F802E8 Authentication-Results: alsa1.perex.cz; dkim=pass (1024-bit key, unprotected) header.d=suse.de header.i=@suse.de header.a=rsa-sha256 header.s=susede2_rsa header.b=yN3M/1Xh; dkim=pass header.d=suse.de header.i=@suse.de header.a=ed25519-sha256 header.s=susede2_ed25519 header.b=hCYtK2+B Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by smtp-out2.suse.de (Postfix) with ESMTPS id 6D801201CC; Fri, 12 May 2023 07:21:58 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_rsa; t=1683876118; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=jdzbRtLu6HiRNn5fEWD6aU9FI03WtYjGLgllHdhFobY=; b=yN3M/1XhCFIAAt/HN45f0XAAliUIaORMMNS5Me69oWKkueJmlTExw35IFETIYEYjJg+sB/ rsnnT1Qvsj3ZxnUwndgtSK81dAdKEhliYrP6PrUpAjU85cWr6OxtEM7Cux53RnJ4AkS9tc bw50scl+cXw4trcQOmXkZ/bNTb5KxpU= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_ed25519; t=1683876118; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=jdzbRtLu6HiRNn5fEWD6aU9FI03WtYjGLgllHdhFobY=; b=hCYtK2+Bq2NjdY9NehYvw0xc3Rbtzq4Ergvx/7ps04jRDyTBLvAQR3gI1ACPp0VKp1H8BJ 7xVVFqkbs4+kYwAA== Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by imap2.suse-dmz.suse.de (Postfix) with ESMTPS id 4D14313499; Fri, 12 May 2023 07:21:58 +0000 (UTC) Received: from dovecot-director2.suse.de ([192.168.254.65]) by imap2.suse-dmz.suse.de with ESMTPSA id wvW+ERbpXWTMAQAAMHmgww (envelope-from ); Fri, 12 May 2023 07:21:58 +0000 Date: Fri, 12 May 2023 09:21:57 +0200 Message-ID: <878rduauay.wl-tiwai@suse.de> From: Takashi Iwai To: Oswald Buddenhagen Cc: alsa-devel@alsa-project.org, Jaroslav Kysela Subject: Re: [PATCH 00/14] ALSA: emu10k1: various improvements to the DSP-based mixer code In-Reply-To: <20230510173917.3073107-1-oswald.buddenhagen@gmx.de> References: <20230510173917.3073107-1-oswald.buddenhagen@gmx.de> User-Agent: Wanderlust/2.15.9 (Almost Unreal) Emacs/27.2 Mule/6.0 MIME-Version: 1.0 (generated by SEMI-EPG 1.14.7 - "Harue") Content-Type: text/plain; charset=US-ASCII Message-ID-Hash: KSPZXJEOOFKQNSZVVMISWOIB4YXRPGTP X-Message-ID-Hash: KSPZXJEOOFKQNSZVVMISWOIB4YXRPGTP X-MailFrom: tiwai@suse.de X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; emergency; loop; banned-address; member-moderation; header-match-alsa-devel.alsa-project.org-0; header-match-alsa-devel.alsa-project.org-1; nonmember-moderation; administrivia; implicit-dest; max-recipients; max-size; news-moderation; no-subject; digests; suspicious-header X-Mailman-Version: 3.3.8 Precedence: list List-Id: "Alsa-devel mailing list for ALSA developers - http://www.alsa-project.org" Archived-At: List-Archive: List-Help: List-Owner: List-Post: List-Subscribe: List-Unsubscribe: On Wed, 10 May 2023 19:39:03 +0200, Oswald Buddenhagen wrote: > > > Oswald Buddenhagen (14): > ALSA: emu10k1: make tone control switch mono > ALSA: emu10k1: roll up loops in DSP setup code for Audigy > ALSA: emu10k1: fix+optimize E-MU stereo capture DSP code > ALSA: emu10k1: simplify snd_emu10k1_audigy_dsp_convert_32_to_2x16() > ALSA: emu10k1: apply channel delay hack to all E-MU cards > ALSA: emu10k1: simplify tone control switch DSP code > ALSA: emu10k1: properly assert DSP init constraints > ALSA: emu10k1: polish audigy GPR allocation > ALSA: emu10k1: fix non-zero mixer control defaults in highres mode > ALSA: emu10k1: validate min/max values of translated controls > ALSA: emu10k1: omit non-applicable mixer controls for E-MU cards > ALSA: emu10k1: skip mic capture PCM for cards without AC97 codec > ALSA: emu10k1: enable bit-exact playback, part 1: DSP attenuation > ALSA: emu10k1: enable bit-exact playback, part 2: voice attenuation So I applied partially, only the patches from 1 to 6 for now. Except for the patch 7, it looks good and I'll happily apply after resubmission. thanks, Takashi