From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 8747DC6FD1D for ; Mon, 20 Mar 2023 18:27:25 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231378AbjCTS1Y (ORCPT ); Mon, 20 Mar 2023 14:27:24 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:39726 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231383AbjCTS1G (ORCPT ); Mon, 20 Mar 2023 14:27:06 -0400 Received: from markus.defensec.nl (markus.defensec.nl [IPv6:2a10:3781:2099::123]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 144B57D89 for ; Mon, 20 Mar 2023 11:19:59 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=defensec.nl; s=default; t=1679336387; bh=tM0PlMThFfuUauqXEt/JlFZdidPp2bElLx+8S6NkT3g=; h=From:To:Cc:Subject:References:Date:In-Reply-To:From; b=UqXd7kA9n4ZMlXjjxHYjASR3smVroi4DlHlxL/ZiGGptiFnQItG/TPj6u/ir9wlML LLQ5inVem29VcQRfNDSJVXYLprHhUqSqva6WpylJcHhkTtVGdH02mmuI/8PbXYYscM sWLvIlux5zNMs1oVP8njq8ibluork3QQtHHxu1XE= Received: from paulus (paulus.lan [IPv6:2a10:3781:2099::515]) by markus.defensec.nl (Postfix) with ESMTPSA id 48D173CC; Mon, 20 Mar 2023 19:19:47 +0100 (CET) From: Dominick Grift To: Stephen Smalley Cc: Ondrej Mosnacek , Paul Moore , selinux@vger.kernel.org Subject: Re: cgroup2 labeling question References: <87mt47ga29.fsf@defensec.nl> <871qljfrtz.fsf@defensec.nl> <87wn3bec97.fsf@defensec.nl> <87lejre9b2.fsf@defensec.nl> <87h6ufe5um.fsf@defensec.nl> Date: Mon, 20 Mar 2023 19:19:47 +0100 In-Reply-To: (Stephen Smalley's message of "Mon, 20 Mar 2023 14:15:40 -0400") Message-ID: <878rfre14s.fsf@defensec.nl> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.2 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Precedence: bulk List-ID: X-Mailing-List: selinux@vger.kernel.org Stephen Smalley writes: > On Mon, Mar 20, 2023 at 1:53=E2=80=AFPM Stephen Smalley > wrote: >> >> On Mon, Mar 20, 2023 at 1:28=E2=80=AFPM Stephen Smalley >> wrote: >> > Hmm...that's interesting. I just tried in Fedora using one of the >> > type_transitions already defined in the default policy and although it >> > appears to use the type_transition to compute the new SID for the >> > create check, ls -Z of the file after creation showed it labeled >> > cgroup_t instead. So it doesn't appear to be working or I am doing it >> > wrong. >> >> Reproducer, on F34, >> $ sudo mkdir /sys/fs/cgroup/system.slice/.snapshots >> mkdir: cannot create directory >> =E2=80=98/sys/fs/cgroup/system.slice/.snapshots=E2=80=99: Permission den= ied >> $ sudo ausearch -m AVC -ts recent -i >> ---- >> type=3DAVC msg=3Daudit(03/20/2023 13:00:04.699:47156) : avc: denied { >> associate } for pid=3D152325 comm=3Dmkdir name=3D.snapshots >> scontext=3Dunconfined_u:object_r:snapperd_data_t:s0 >> tcontext=3Dsystem_u:object_r:cgroup_t:s0 tclass=3Dfilesystem permissive= =3D0 >> $ seinfo --fs_use | grep cgroup >> $ seinfo --genfscon | grep cgroup >> genfscon cgroup / system_u:object_r:cgroup_t:s0 >> genfscon cgroup2 / system_u:object_r:cgroup_t:s0 >> $ sesearch -T -s unconfined_t -t cgroup_t -c dir >> type_transition unconfined_t cgroup_t:dir snapperd_data_t .snapshots >> $ sudo setenforce 0 >> $ sudo mkdir /sys/fs/cgroup/system.slice/.snapshots >> $ ls -Zd /sys/fs/cgroup/system.slice/.snapshots >> system_u:object_r:cgroup_t:s0 /sys/fs/cgroup/system.slice/.snapshots > > Unless systemd is coming along after file creation and relabeling it > to cgroup_t at that time. That wouldnt make sense to me, but yes i considered that as well. Ruled it out without actually confirming it. I actually added a rule: auditallow domain cgroup_t:dir create; and that also does not show grants for all the dirs in /sys/fs/cgroup (just some) voodoo --=20 gpg --locate-keys dominick.grift@defensec.nl Key fingerprint =3D FCD2 3660 5D6B 9D27 7FC6 E0FF DA7E 521F 10F6 4098 Dominick Grift