From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201])
	(using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits))
	(No client certificate requested)
	by smtp.subspace.kernel.org (Postfix) with ESMTPS id E44A61FA3
	for <kvmarm@lists.linux.dev>; Sun, 12 Mar 2023 11:39:56 +0000 (UTC)
Received: by smtp.kernel.org (Postfix) with ESMTPSA id 878F4C433EF;
	Sun, 12 Mar 2023 11:39:56 +0000 (UTC)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org;
	s=k20201202; t=1678621196;
	bh=nTQEFaXwPHlcQkPCQVZJvftVD07EvgyZH7LOw0V8qaI=;
	h=Date:From:To:Cc:Subject:In-Reply-To:References:From;
	b=caFKuMY4xztGtrCaXjHGbCtE5UcafIkjkgYzpViYmgeRD6PvbHt/+B5eXdWOYudez
	 sjz5aBgMJ8upatQpj3xDeIAP7zLXQFQsxFslD1Haeo4nra74tjGzQIiZeM3IEcNdYS
	 7Sl3VlLhPnJXOYVIPX+N5Hh2p/O6c5w62DEqVy1ZH4mph3/7ofJCfrjqYJnXZ7KroY
	 H+qBnpRzVoQ0JVaZcnIReQOZwPX5qc7SECnFoSzIev6pNT8BXiLkX7gRBtpIoZN/bU
	 rUMvW+HbV5LMLh+wt2mgipkqVttGHO3DhFOMP8F7HbNy1BT/vfkmxUEbE3TzBm29jp
	 yctxtREV1zUfA==
Received: from sofa.misterjones.org ([185.219.108.64] helo=wait-a-minute.misterjones.org)
	by disco-boy.misterjones.org with esmtpsa  (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384
	(Exim 4.95)
	(envelope-from <maz@kernel.org>)
	id 1pbK3O-00Gyw6-2q;
	Sun, 12 Mar 2023 11:39:54 +0000
Date: Sun, 12 Mar 2023 11:39:53 +0000
Message-ID: <878rg25hbq.wl-maz@kernel.org>
From: Marc Zyngier <maz@kernel.org>
To: Ricardo Koller <ricarkol@google.com>
Cc: pbonzini@redhat.com,
	oupton@google.com,
	yuzenghui@huawei.com,
	dmatlack@google.com,
	kvm@vger.kernel.org,
	kvmarm@lists.linux.dev,
	qperret@google.com,
	catalin.marinas@arm.com,
	andrew.jones@linux.dev,
	seanjc@google.com,
	alexandru.elisei@arm.com,
	suzuki.poulose@arm.com,
	eric.auger@redhat.com,
	gshan@redhat.com,
	reijiw@google.com,
	rananta@google.com,
	bgardon@google.com,
	ricarkol@gmail.com,
	Shaoqin Huang <shahuang@redhat.com>
Subject: Re: [PATCH v6 07/12] KVM: arm64: Export kvm_are_all_memslots_empty()
In-Reply-To: <20230307034555.39733-8-ricarkol@google.com>
References: <20230307034555.39733-1-ricarkol@google.com>
	<20230307034555.39733-8-ricarkol@google.com>
User-Agent: Wanderlust/2.15.9 (Almost Unreal) SEMI-EPG/1.14.7 (Harue)
 FLIM-LB/1.14.9 (=?UTF-8?B?R29qxY0=?=) APEL-LB/10.8 EasyPG/1.0.0 Emacs/27.1
 (x86_64-pc-linux-gnu) MULE/6.0 (HANACHIRUSATO)
Precedence: bulk
X-Mailing-List: kvmarm@lists.linux.dev
List-Id: <kvmarm.lists.linux.dev>
List-Subscribe: <mailto:kvmarm+subscribe@lists.linux.dev>
List-Unsubscribe: <mailto:kvmarm+unsubscribe@lists.linux.dev>
MIME-Version: 1.0 (generated by SEMI-EPG 1.14.7 - "Harue")
Content-Type: text/plain; charset=US-ASCII
X-SA-Exim-Connect-IP: 185.219.108.64
X-SA-Exim-Rcpt-To: ricarkol@google.com, pbonzini@redhat.com, oupton@google.com, yuzenghui@huawei.com, dmatlack@google.com, kvm@vger.kernel.org, kvmarm@lists.linux.dev, qperret@google.com, catalin.marinas@arm.com, andrew.jones@linux.dev, seanjc@google.com, alexandru.elisei@arm.com, suzuki.poulose@arm.com, eric.auger@redhat.com, gshan@redhat.com, reijiw@google.com, rananta@google.com, bgardon@google.com, ricarkol@gmail.com, shahuang@redhat.com
X-SA-Exim-Mail-From: maz@kernel.org
X-SA-Exim-Scanned: No (on disco-boy.misterjones.org); SAEximRunCond expanded to false

On Tue, 07 Mar 2023 03:45:50 +0000,
Ricardo Koller <ricarkol@google.com> wrote:
> 
> Export kvm_are_all_memslots_empty(). This will be used by a future
> commit when checking before setting a capability.

You're not exporting this function, you  are making it globally
visible, which is a very different things. Please keep "export"
description for symbols that are actually exported to modules.

> 
> No functional change intended.

I wish people stopped adding this pointless sentence to commit
messages. All changes have a functional change one way or another,
unless you are only changing a comment. Yes, I've been guilty of
writing that too, and I wish I didn't.

Thanks,

	M.

-- 
Without deviation from the norm, progress is not possible.