Re: [bitbake-devel] [PATCH] fetch2/tests: Add parameter to recipe_uri

[Pavel Zhukov <pavel@zhukoff.net>]

Pavel Zhukov <pavel@zhukoff.net> writes:

> Quentin Schulz <quentin.schulz@theobroma-systems.com> writes:
>
>> Hi Pavel,
> Hi Quentin!
>>
>> On 1/18/23 08:28, Pavel Zhukov wrote:
>>> While the parameter is not required it allows testing of possible
>>
>> I was convinced it was required for a year already but no :)
>>
>> I see Richard added a warning in Bitbake when the branch parameter is
>> missing and nobranch is not set to 1,
>> c.f. https://git.openembedded.org/bitbake/commit/?id=86a9c26828479be55865bcce72bcc7e12b93caa7
> Right, I saw this warning in the past but not this time... Anyway at the
> scope of this patch branch parameter can be changed with any other
> (rebaseable,bareclone etc) parameter git fetcher accpes.
> branch one is just first that came into my mind
> :) . 
Well. The warning is there but it's diplayed only if test failed:
Stdout:
URL: git://git.fake.repo/bitbake does not set any branch parameter. The future default branch used by tools and repositories is uncertain and we will therefore soon require this is set in all git urls.

So yes, we don't fail test if it's missed. And even more, test will fail
if it's specified and premirror is used in current bitbake

>>
>> Maybe it's time we make this a fail?
>>
>> Cheers,
>> Quentin