From: Kalle Valo <kvalo@kernel.org>
To: Johannes Berg <johannes@sipsolutions.net>
Cc: Arend van Spriel <arend.vanspriel@broadcom.com>,
Stefan Wahren <stefan.wahren@i2se.com>,
Arend van Spriel <aspriel@gmail.com>,
Franky Lin <franky.lin@broadcom.com>,
Hante Meuleman <hante.meuleman@broadcom.com>,
linux-wireless@vger.kernel.org,
brcm80211-dev-list.pdl@broadcom.com,
SHA-cyfmac-dev-list@infineon.com
Subject: Re: brcmfmac: Unexpected cfg80211_set_channel: set chanspec ... fail, reason -52
Date: Fri, 13 Jan 2023 15:35:51 +0200 [thread overview]
Message-ID: <878ri6d0aw.fsf@kernel.org> (raw)
In-Reply-To: <ee24c4eda8d389ac7197b6296944e168ccc6b602.camel@sipsolutions.net> (Johannes Berg's message of "Tue, 03 Jan 2023 08:07:41 +0100")
Johannes Berg <johannes@sipsolutions.net> writes:
>> > [ 104.897615] brcmfmac: cfg80211_set_channel: set chanspec 0x100e fail,
>> > reason -52
>
> [...]
>
>>
>> > All of these 10 errors are repeated every 60 sec.
>>
>> Catching up after the holidays ;-) Above chanspec values are invalid.
>> 0x100e = channel 14/bw 20MHz. The 'iw list' output shows all these
>> channels are disabled. So who/what is trying to set these channels.
>> Scanning sets the channel in firmware. Is this initiated from hostapd?
>
> Yeah, what userspace is running here? Looks like cfg80211_set_channel()
> is only used for survey?
>
> Couple of observations on the side:
> * might be nice to have some "brcm" indication in that name :P
Indeed, having a function cfg80211_set_channel() in brcmfmac/cfg80211.c
is VERY misleading. I first though that is a cfg80211 function and
didn't understand Johannes' comment until I started grepping :) Can
someone fix that, please?
--
https://patchwork.kernel.org/project/linux-wireless/list/
https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches
next prev parent reply other threads:[~2023-01-13 13:42 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-12-30 17:39 brcmfmac: Unexpected cfg80211_set_channel: set chanspec ... fail, reason -52 Stefan Wahren
2023-01-02 19:23 ` Arend van Spriel
2023-01-03 7:07 ` Johannes Berg
2023-01-03 9:57 ` Arend van Spriel
2023-01-03 11:46 ` Stefan Wahren
2023-01-13 13:35 ` Kalle Valo [this message]
2023-01-13 15:14 ` Arend Van Spriel
2023-01-13 15:54 ` Kalle Valo
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=878ri6d0aw.fsf@kernel.org \
--to=kvalo@kernel.org \
--cc=SHA-cyfmac-dev-list@infineon.com \
--cc=arend.vanspriel@broadcom.com \
--cc=aspriel@gmail.com \
--cc=brcm80211-dev-list.pdl@broadcom.com \
--cc=franky.lin@broadcom.com \
--cc=hante.meuleman@broadcom.com \
--cc=johannes@sipsolutions.net \
--cc=linux-wireless@vger.kernel.org \
--cc=stefan.wahren@i2se.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.