All of lore.kernel.org
 help / color / mirror / Atom feed
From: Markus Armbruster <armbru@redhat.com>
To: Stefan Hajnoczi <stefanha@gmail.com>
Cc: qemu-devel@nongnu.org,  stefanha@redhat.com,  kwolf@redhat.com
Subject: Re: [PATCH 1/4] coroutine: Clean up superfluous inclusion of qemu/coroutine.h
Date: Thu, 08 Dec 2022 18:56:30 +0100	[thread overview]
Message-ID: <878rjhixtd.fsf@pond.sub.org> (raw)
In-Reply-To: <CAJSP0QXUCDU2kW7WwqQGWQbiv34vUL4F=7capUi8Uj54_YHKig@mail.gmail.com> (Stefan Hajnoczi's message of "Thu, 8 Dec 2022 09:59:45 -0500")

Stefan Hajnoczi <stefanha@gmail.com> writes:

> Probably because block layer, aio.h, and coroutine_int.h header files
> already include "qemu/coroutine.h"?

Mostly, but not always.  For instance, crypto/block-luks-priv.h compiles
fine without it, and doesn't include it after this patch.

> Reviewed-by: Stefan Hajnoczi <stefanha@redhat.com>

Thanks!



  reply	other threads:[~2022-12-08 17:57 UTC|newest]

Thread overview: 15+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-12-08 14:23 [PATCH 0/4] coroutine: Clean up includes Markus Armbruster
2022-12-08 14:23 ` [PATCH 1/4] coroutine: Clean up superfluous inclusion of qemu/coroutine.h Markus Armbruster
2022-12-08 14:59   ` Stefan Hajnoczi
2022-12-08 17:56     ` Markus Armbruster [this message]
2022-12-08 14:23 ` [PATCH 2/4] coroutine: Move coroutine_fn to qemu/osdep.h, trim includes Markus Armbruster
2022-12-08 15:03   ` Stefan Hajnoczi
2022-12-08 14:23 ` [PATCH 3/4] coroutine: Clean up superfluous inclusion of qemu/lockable.h Markus Armbruster
2022-12-08 15:05   ` Stefan Hajnoczi
2022-12-08 14:23 ` [PATCH 4/4] coroutine: Break inclusion loop Markus Armbruster
2022-12-08 15:07   ` Stefan Hajnoczi
     [not found]   ` <2ac0daae-da25-0a31-9a73-8f186cc510e9@redhat.com>
2022-12-13  0:34     ` Paolo Bonzini
2022-12-15  6:49       ` Markus Armbruster
2022-12-17 12:42         ` Paolo Bonzini
2022-12-19  4:23           ` Markus Armbruster
2022-12-17 17:23       ` Philippe Mathieu-Daudé

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=878rjhixtd.fsf@pond.sub.org \
    --to=armbru@redhat.com \
    --cc=kwolf@redhat.com \
    --cc=qemu-devel@nongnu.org \
    --cc=stefanha@gmail.com \
    --cc=stefanha@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.