From: Fabiano Rosas <farosas@suse.de>
To: "Philippe Mathieu-Daudé" <philmd@linaro.org>, qemu-devel@nongnu.org
Cc: "Eduardo Habkost" <eduardo@habkost.net>,
"Richard Henderson" <richard.henderson@linaro.org>,
"Philippe Mathieu-Daudé" <philmd@linaro.org>,
"Thomas Huth" <thuth@redhat.com>,
"Yanan Wang" <wangyanan55@huawei.com>,
"Paolo Bonzini" <pbonzini@redhat.com>,
"Marcel Apfelbaum" <marcel.apfelbaum@gmail.com>
Subject: Re: [PATCH-for-8.0 2/2] hw: Reduce "qemu/accel.h" inclusion
Date: Wed, 30 Nov 2022 12:17:16 -0300 [thread overview]
Message-ID: <878rjs4glf.fsf@suse.de> (raw)
In-Reply-To: <20221130135641.85328-3-philmd@linaro.org>
Philippe Mathieu-Daudé <philmd@linaro.org> writes:
> Move "qemu/accel.h" include from the heavily included
> "hw/boards.h" to hw/core/machine.c, the single file using
> the AccelState definition.
Do you mean accel_init_interfaces() and ACCEL_GET_CLASS? I don't see
AccelState explicitly.
Anyway,
Reviewed-by: Fabiano Rosas <farosas@suse.de>
> Signed-off-by: Philippe Mathieu-Daudé <philmd@linaro.org>
> ---
> hw/core/machine.c | 1 +
> include/hw/boards.h | 1 -
> 2 files changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/hw/core/machine.c b/hw/core/machine.c
> index 8d34caa31d..42fc6f1e84 100644
> --- a/hw/core/machine.c
> +++ b/hw/core/machine.c
> @@ -12,6 +12,7 @@
>
> #include "qemu/osdep.h"
> #include "qemu/option.h"
> +#include "qemu/accel.h"
> #include "qapi/qmp/qerror.h"
> #include "sysemu/replay.h"
> #include "qemu/units.h"
> diff --git a/include/hw/boards.h b/include/hw/boards.h
> index 90f1dd3aeb..f00f74c5f4 100644
> --- a/include/hw/boards.h
> +++ b/include/hw/boards.h
> @@ -6,7 +6,6 @@
> #include "exec/memory.h"
> #include "sysemu/hostmem.h"
> #include "sysemu/blockdev.h"
> -#include "qemu/accel.h"
> #include "qapi/qapi-types-machine.h"
> #include "qemu/module.h"
> #include "qom/object.h"
next prev parent reply other threads:[~2022-11-30 15:18 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-11-30 13:56 [PATCH-for-8.0 0/2] hw: Reduce "qemu/accel.h" inclusion Philippe Mathieu-Daudé
2022-11-30 13:56 ` [PATCH-for-8.0 1/2] typedefs: Forward-declare AccelState Philippe Mathieu-Daudé
2022-11-30 14:26 ` Fabiano Rosas
2022-11-30 22:22 ` Richard Henderson
2022-11-30 13:56 ` [PATCH-for-8.0 2/2] hw: Reduce "qemu/accel.h" inclusion Philippe Mathieu-Daudé
2022-11-30 15:17 ` Fabiano Rosas [this message]
2022-11-30 15:43 ` Philippe Mathieu-Daudé
2022-11-30 15:44 ` Paolo Bonzini
2022-11-30 23:38 ` Wilfred Mallawa
2022-11-30 15:35 ` [PATCH-for-8.0 0/2] " Paolo Bonzini
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=878rjs4glf.fsf@suse.de \
--to=farosas@suse.de \
--cc=eduardo@habkost.net \
--cc=marcel.apfelbaum@gmail.com \
--cc=pbonzini@redhat.com \
--cc=philmd@linaro.org \
--cc=qemu-devel@nongnu.org \
--cc=richard.henderson@linaro.org \
--cc=thuth@redhat.com \
--cc=wangyanan55@huawei.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.