From: Richard Palethorpe <rpalethorpe@suse.de>
To: Yang Xu <xuyang2018.jy@fujitsu.com>
Cc: ltp@lists.linux.it
Subject: Re: [LTP] [PATCH] syscalls/setfsuid: Use SETFSUID instead of setfsuid to check 32bit syscall
Date: Mon, 28 Nov 2022 15:16:09 +0000 [thread overview]
Message-ID: <878rjvun26.fsf@suse.de> (raw)
In-Reply-To: <1668999635-2018-1-git-send-email-xuyang2018.jy@fujitsu.com>
Hello,
Merged, Thanks!
Yang Xu <xuyang2018.jy@fujitsu.com> writes:
> Signed-off-by: Yang Xu <xuyang2018.jy@fujitsu.com>
> ---
> testcases/kernel/syscalls/setfsuid/setfsuid01.c | 4 ++--
> testcases/kernel/syscalls/setfsuid/setfsuid03.c | 4 ++--
> 2 files changed, 4 insertions(+), 4 deletions(-)
>
> diff --git a/testcases/kernel/syscalls/setfsuid/setfsuid01.c b/testcases/kernel/syscalls/setfsuid/setfsuid01.c
> index 0cbf101ee..9805e38b6 100644
> --- a/testcases/kernel/syscalls/setfsuid/setfsuid01.c
> +++ b/testcases/kernel/syscalls/setfsuid/setfsuid01.c
> @@ -34,8 +34,8 @@ static void run(void)
> UID16_CHECK(uid, setfsuid);
>
> SAFE_SETEUID(0);
> - TST_EXP_VAL(setfsuid(nobody_uid), uid, "setfsuid(%d)", nobody_uid);
> - TST_EXP_VAL(setfsuid(-1), nobody_uid);
> + TST_EXP_VAL(SETFSUID(nobody_uid), uid, "setfsuid(%d)", nobody_uid);
> + TST_EXP_VAL(SETFSUID(-1), nobody_uid);
> }
>
> static struct tst_test test = {
> diff --git a/testcases/kernel/syscalls/setfsuid/setfsuid03.c b/testcases/kernel/syscalls/setfsuid/setfsuid03.c
> index 02698f7cf..ee06e9376 100644
> --- a/testcases/kernel/syscalls/setfsuid/setfsuid03.c
> +++ b/testcases/kernel/syscalls/setfsuid/setfsuid03.c
> @@ -36,8 +36,8 @@ static void run(void)
> SAFE_SETEUID(nobody_uid);
> UID16_CHECK(ruid, setfsuid);
>
> - TST_EXP_VAL_SILENT(setfsuid(ruid), nobody_uid);
> - TST_EXP_VAL(setfsuid(-1), ruid, "setfsuid(fsuid) by non-root user:");
> + TST_EXP_VAL_SILENT(SETFSUID(ruid), nobody_uid);
> + TST_EXP_VAL(SETFSUID(-1), ruid, "setfsuid(fsuid) by non-root user:");
> }
>
> static struct tst_test test = {
> --
> 2.27.0
--
Thank you,
Richard.
--
Mailing list info: https://lists.linux.it/listinfo/ltp
prev parent reply other threads:[~2022-11-28 15:16 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-11-21 3:00 [LTP] [PATCH] syscalls/setfsuid: Use SETFSUID instead of setfsuid to check 32bit syscall Yang Xu
2022-11-28 15:16 ` Richard Palethorpe [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=878rjvun26.fsf@suse.de \
--to=rpalethorpe@suse.de \
--cc=ltp@lists.linux.it \
--cc=xuyang2018.jy@fujitsu.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.