From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 20705C54EE9 for ; Tue, 27 Sep 2022 08:15:57 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231546AbiI0IP4 (ORCPT ); Tue, 27 Sep 2022 04:15:56 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:57158 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229889AbiI0IPc (ORCPT ); Tue, 27 Sep 2022 04:15:32 -0400 Received: from mail-wm1-x32c.google.com (mail-wm1-x32c.google.com [IPv6:2a00:1450:4864:20::32c]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 178ABAFAC1 for ; Tue, 27 Sep 2022 01:12:52 -0700 (PDT) Received: by mail-wm1-x32c.google.com with SMTP id i203-20020a1c3bd4000000b003b3df9a5ecbso8935127wma.1 for ; Tue, 27 Sep 2022 01:12:52 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=baylibre-com.20210112.gappssmtp.com; s=20210112; h=mime-version:message-id:date:references:in-reply-to:subject:cc:to :from:from:to:cc:subject:date; bh=ZWYEuc1YfYOK9SsTFoMGj0wBsGs5m9ZmF0vJ407XFBM=; b=ge+r2o1aLvQ3NraoYpGfE9LaaLj8GTbgeo8UCuCv7CTBVGwwNBSx4nXgAizxZ7ALxV 6LJuCbJlRGPTcOpi+KMQ2oShJHhJlMRCQLJwQt++Hgo7lY+JGn/e01GF7BonGw0v9/ee EnQ/s8lQRWhUPGTF8JXv7UmvjjmZi+yYXOZ7gHxBjZgQQpWLBjObA0YkNb5dLxgXzOsL X0FZFUwrW57Uj+Sy6iX2SpAhn9G/8wDq/T5gvHSE7yzpPQsQeT867lVvpLXn4MgfY6BP vZ9IxV9m01PBy4/BT3aW5haLcKpE5XIJGZ7k0fj0q8QE4qW3JWkwxxW7NkrbZZc9jkOz eOSA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=mime-version:message-id:date:references:in-reply-to:subject:cc:to :from:x-gm-message-state:from:to:cc:subject:date; bh=ZWYEuc1YfYOK9SsTFoMGj0wBsGs5m9ZmF0vJ407XFBM=; b=LBH2QwvqNsTRP4daQnaDd8XyLMzy97xzKvMKp3mxLNbT35XvHeOzkO7DgXGDh1Gx8v /ofV2meHXlt1Vx74EknX2aApwX0fZJzwzHQatULwdBmIZz9KmoQ3GpxYDYKzJh4acbPv kkNHk0+ZlsTSvydEg7ewFuaul+jzdJ+bajD+lcG86grVc3qjmqw53YCYzIIvluroopKz 3JtbGHgqFl5rvLmPADZQTGyzWN+f+fztRP3raZPdnxZ7Uhka+ryFiQXV1iaVn+v4L4/D KRF/R5AxH088VHR1TahRxD/OvSCYpftNsAzxhsgMBXuSyWYEvzlhn5w9CpS+HxMSO5// QCOg== X-Gm-Message-State: ACrzQf1FnCR/QD++JoWv/AcZF22w5BA/xRW2jJudqK8gqDeOO5VeZ4UU oqWxZ5WpodISKwIuMYyGm3QqKA== X-Google-Smtp-Source: AMsMyM5fZUz2xa/hcrWWxqrOvsBz+AH+lsifruKQKHHg23rc/e8c/HXHXvB4Vt/cvu1g/rxAAWCE/w== X-Received: by 2002:a05:600c:3cd:b0:3b4:8372:294c with SMTP id z13-20020a05600c03cd00b003b48372294cmr1656061wmd.191.1664266370088; Tue, 27 Sep 2022 01:12:50 -0700 (PDT) Received: from localhost ([82.66.159.240]) by smtp.gmail.com with ESMTPSA id f10-20020adff58a000000b002285f73f11dsm1298734wro.81.2022.09.27.01.12.49 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 27 Sep 2022 01:12:49 -0700 (PDT) From: Mattijs Korpershoek To: Sebastian Krzyszkowiak , Dmitry Torokhov , linux-input@vger.kernel.org Cc: Sebastian Krzyszkowiak , Robin van der Gracht , linux-kernel@vger.kernel.org, kernel@puri.sm, Uwe =?utf-8?Q?Kleine-K=C3=B6nig?= , stable@vger.kernel.org, Martin Kepplinger Subject: Re: [PATCH v2 RESEND] input: keyboard: snvs_pwrkey: Fix SNVS_HPVIDR1 register address In-Reply-To: <4599101.ElGaqSPkdT@pliszka> References: <4599101.ElGaqSPkdT@pliszka> Date: Tue, 27 Sep 2022 10:12:48 +0200 Message-ID: <878rm5nslb.fsf@baylibre.com> MIME-Version: 1.0 Content-Type: text/plain Precedence: bulk List-ID: X-Mailing-List: linux-input@vger.kernel.org On Tue, Sep 27, 2022 at 08:25, Sebastian Krzyszkowiak wrote: > Both i.MX6 and i.MX8 reference manuals list 0xBF8 as SNVS_HPVIDR1 > (chapters 57.9 and 6.4.5 respectively). > > Without this, trying to read the revision number results in 0 on > all revisions, causing the i.MX6 quirk to apply on all platforms, > which in turn causes the driver to synthesise power button release > events instead of passing the real one as they happen even on > platforms like i.MX8 where that's not wanted. > > Fixes: 1a26c920717a ("Input: snvs_pwrkey - send key events for i.MX6 S, DL and Q") > Cc: > Tested-by: Martin Kepplinger > Signed-off-by: Sebastian Krzyszkowiak Reviewed-by: Mattijs Korpershoek > --- > Resent <20220321171755.656750-1-sebastian.krzyszkowiak@puri.sm> > v2: augmented commit message; added cc: stable and tested-by > --- > drivers/input/keyboard/snvs_pwrkey.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/input/keyboard/snvs_pwrkey.c b/drivers/input/keyboard/snvs_pwrkey.c > index 65286762b02a..ad8660be0127 100644 > --- a/drivers/input/keyboard/snvs_pwrkey.c > +++ b/drivers/input/keyboard/snvs_pwrkey.c > @@ -20,7 +20,7 @@ > #include > #include > > -#define SNVS_HPVIDR1_REG 0xF8 > +#define SNVS_HPVIDR1_REG 0xBF8 > #define SNVS_LPSR_REG 0x4C /* LP Status Register */ > #define SNVS_LPCR_REG 0x38 /* LP Control Register */ > #define SNVS_HPSR_REG 0x14 > -- > 2.35.1