From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 67BDFC6FA82 for ; Mon, 26 Sep 2022 08:02:02 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S234104AbiIZIB6 (ORCPT ); Mon, 26 Sep 2022 04:01:58 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:49940 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S233727AbiIZIBa (ORCPT ); Mon, 26 Sep 2022 04:01:30 -0400 Received: from dfw.source.kernel.org (dfw.source.kernel.org [139.178.84.217]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 02614C27; Mon, 26 Sep 2022 00:58:52 -0700 (PDT) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id 8F8A36179F; Mon, 26 Sep 2022 07:58:51 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 85251C433C1; Mon, 26 Sep 2022 07:58:47 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1664179131; bh=jfuwhFd5PczoIXgvji7jNDdS65hU/TTDtOFWvgEpYkI=; h=From:To:Cc:Subject:References:Date:In-Reply-To:From; b=GCIatT1Gc/erxM3rdkI/8g7syX2EzY43d6RY9O+fWQUdcXRuyiUDtbvpnl60m7dE+ 2hHqu72oyFVsX4ntX4wXxY+UDRxa8AzF24r8pQDDmoqhG/pdyMDuzLPD8O4VauEEUl 2XSuoHx8i7aA0x3Uj8Z3QMBfujxRHshTsS1sRVRluCpBkAN3MltLOp8V0a/pNOmEqY vAT7RtTC2bIb0/ClWsmnnclQtV2Im5Dl85mLrfXyuZ0Dbjt+i4BqX/ve4Hd2AbJdJ1 0tfGBkzPGfZm8pNH/aTWBqPL4AJ/rT8cq1qQTCqdVHwvl0uR2DQiL0spjUkMyiThdb ZMl452H4brgTQ== From: Kalle Valo To: Ruan Jinjie Cc: Franky Lin , , , , , , , , , , , , , , , Subject: Re: [PATCH -next] wifi: brcmfmac: pcie: add missing pci_disable_device() in brcmf_pcie_get_resource() References: <20220923093806.3108119-1-ruanjinjie@huawei.com> Date: Mon, 26 Sep 2022 10:58:45 +0300 In-Reply-To: (Ruan Jinjie's message of "Sat, 24 Sep 2022 09:00:12 +0800") Message-ID: <878rm64le2.fsf@kernel.org> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/26.1 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain Precedence: bulk List-ID: X-Mailing-List: linux-wireless@vger.kernel.org Ruan Jinjie writes: > On 2022/9/24 0:50, Franky Lin wrote: >> On Fri, Sep 23, 2022 at 2:42 AM ruanjinjie wrote: >>> >>> Add missing pci_disable_device() if brcmf_pcie_get_resource() fails. >> >> Did you encounter any issue because of the absensent >> pci_disable_device? A bit more context will be very helpful. >> > > We use static analysis via coccinelle to find the above issue. The > command we use is below: > > spatch -I include -timeout 60 -very_quiet -sp_file > pci_disable_device_missing.cocci > drivers/net/wireless/broadcom/brcm80211/brcmfmac/pcie.c Please include this information to the commit log, it helps to understand the background of the fix. -- https://patchwork.kernel.org/project/linux-wireless/list/ https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches