From: Peter Korsgaard <peter@korsgaard.com>
To: Adrian Perez de Castro <aperez@igalia.com>
Cc: buildroot@buildroot.org
Subject: Re: [Buildroot] [PATCH] package/webkitgtk: bump to version 2.38.0
Date: Wed, 21 Sep 2022 19:44:39 +0200 [thread overview]
Message-ID: <878rmcei60.fsf@dell.be.48ers.dk> (raw)
In-Reply-To: <20220919142007.1967434-1-aperez@igalia.com> (Adrian Perez de Castro's message of "Mon, 19 Sep 2022 17:20:07 +0300")
>>>>> "Adrian" == Adrian Perez de Castro <aperez@igalia.com> writes:
> Update to a new major release which brings in improvements and a few
> new features. Release notes:
> https://webkitgtk.org/2022/09/16/webkitgtk2.38.0-released.html
> This release also includes security fixes for CVE-2022-32886,
> CVE-2022-32891, and CVE-2022-32912. Accompanying security advisory:
> https://webkitgtk.org/security/WSA-2022-0009.html
> The CMake option to build the documentation has been renamed from
> ENABLE_GTK_DOC to ENABLE_DOCUMENTATION, therefore update the build
> recipe accordingly. Option USE_LIBNOTIFY is no longer available, as
> WebKit now uses the notification portal D-Bus API directly without
> relying on libnotify. Lastly, version 2.38.0 introduces a new WebRTC
> implementation based on GstWebRTC which is left disabled for now to
> keep the existing status quo (WebRTC not available), and adding an
> option to enable it can be done in a follow-up patch.
> Signed-off-by: Adrian Perez de Castro <aperez@igalia.com>
As mentioned elsewhere, this breaks on systems with cmake 3.18.x /
3.19.x (E.G. Debian stable, ..) as this version requires cmake 3.20:
CMake Error at Source/cmake/OptionsGTK.cmake:11 (message):
Building with Makefiles requires CMake 3.20 or newer. Either enable Ninja
by passing -GNinja, or upgrade CMake.
Given how long it takes to build webkit, perhaps building it with ninja
makes more sense? Ideally we would extend pkg-cmake.mk so that you can
define per-package if it should build with ninja or make rather than
having custom logic in webkitgtk.mk.
Alternatively we will need to bump the minimal cmake version to 3.20,
but given that E.G. what is is Debian is older than that, this isn't
really a great option.
--
Bye, Peter Korsgaard
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot
prev parent reply other threads:[~2022-09-21 17:44 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-09-19 14:20 [Buildroot] [PATCH] package/webkitgtk: bump to version 2.38.0 Adrian Perez de Castro
2022-09-19 19:41 ` Yann E. MORIN
2022-09-21 17:44 ` Peter Korsgaard [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=878rmcei60.fsf@dell.be.48ers.dk \
--to=peter@korsgaard.com \
--cc=aperez@igalia.com \
--cc=buildroot@buildroot.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.