From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 2A7A4C19F2D for ; Thu, 11 Aug 2022 05:46:40 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S233563AbiHKFqj (ORCPT ); Thu, 11 Aug 2022 01:46:39 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:34092 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229786AbiHKFqj (ORCPT ); Thu, 11 Aug 2022 01:46:39 -0400 Received: from smtp-out2.suse.de (smtp-out2.suse.de [IPv6:2001:67c:2178:6::1d]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 438E586C30; Wed, 10 Aug 2022 22:46:38 -0700 (PDT) Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by smtp-out2.suse.de (Postfix) with ESMTPS id 71BB920918; Thu, 11 Aug 2022 05:46:36 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_rsa; t=1660196796; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=MHWsdm7A1UB6Q4i/Kz812FkXvTmeysFvQrvj3IQ/9q0=; b=zlmldstwOt6wGvsJT89M2+I7MDumNYEjlRifDoG9FuKYk2EC0Tri1FUh7aNtGU31OotOQ9 Cs807JGRudTKO9Ev+wOHhzvOuoSG+fIRL1LEQykfNr1ewcAd5IZXBbicGaMRc4T8D0ZxrI /6wXdPHvTtU5zcstr+RtnS+bwHMEGvc= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_ed25519; t=1660196796; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=MHWsdm7A1UB6Q4i/Kz812FkXvTmeysFvQrvj3IQ/9q0=; b=2JYNoLsfG7RHkNgw4CjJ4vGvLhtPv7Ql1YfvjDAbLOyYp7wnvFUY8/ck7OnehNLJ7sXGCs /+Vc90NefAQ5m3Bg== Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by imap2.suse-dmz.suse.de (Postfix) with ESMTPS id 1994B13A89; Thu, 11 Aug 2022 05:46:36 +0000 (UTC) Received: from dovecot-director2.suse.de ([192.168.254.65]) by imap2.suse-dmz.suse.de with ESMTPSA id 1ONrBbyX9GI4EAAAMHmgww (envelope-from ); Thu, 11 Aug 2022 05:46:36 +0000 Date: Thu, 11 Aug 2022 07:46:35 +0200 Message-ID: <878rnvuybo.wl-tiwai@suse.de> From: Takashi Iwai To: Mohan Kumar Cc: , , , , , , , Subject: Re: [PATCH] ALSA: hda: Fix crash due to jack poll in suspend In-Reply-To: <20220811052704.2944-1-mkumard@nvidia.com> References: <20220811052704.2944-1-mkumard@nvidia.com> User-Agent: Wanderlust/2.15.9 (Almost Unreal) Emacs/27.2 Mule/6.0 MIME-Version: 1.0 (generated by SEMI-EPG 1.14.7 - "Harue") Content-Type: text/plain; charset=US-ASCII Precedence: bulk List-ID: X-Mailing-List: linux-tegra@vger.kernel.org On Thu, 11 Aug 2022 07:27:04 +0200, Mohan Kumar wrote: > > With jackpoll_in_suspend flag set, there is a possibility that > jack poll worker thread will run even after system suspend was > completed. Any register access after system pm callback flow > will result in kernel crash as still jack poll worker thread > tries to access registers. > > To fix the crash issue during system flow, cancel the jack poll > worker thread during system pm prepare callback and cancel the > worker thread at start of runtime suspend callback and re-schedule > at last to avoid any unwarranted access of register by worker thread > during suspend flow. > > Signed-off-by: Mohan Kumar Thanks, applied now with Fixes tag. Takashi