From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 713FBC433EF for ; Wed, 11 May 2022 12:52:18 +0000 (UTC) Received: from localhost ([::1]:49278 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1nolpB-0006TS-D7 for qemu-devel@archiver.kernel.org; Wed, 11 May 2022 08:52:17 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:46310) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1nolkJ-0001dU-5i for qemu-devel@nongnu.org; Wed, 11 May 2022 08:47:16 -0400 Received: from us-smtp-delivery-124.mimecast.com ([170.10.129.124]:51729) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1nolkG-0004vh-8k for qemu-devel@nongnu.org; Wed, 11 May 2022 08:47:13 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1652273230; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=o/znsElYoQsfYb42qI4xbwkpqGBnGkDp9BrMEIrzqps=; b=bDyinr7F6jggdU3tmG7KJ5HQTlFBpsaLBhXWGBf5Ok9IzytJU/rqMRoFpzYrgz021SBvWv j4jjAB60LEjrMmw0ZjS+jFq60FaJ72raAxgONu1S8mjNiQCFHbRM9d20OlOimk590dZqfi JNqTMjPVEWcioZLjdSAQQruFD8Z6FQA= Received: from mimecast-mx02.redhat.com (mimecast-mx02.redhat.com [66.187.233.88]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id us-mta-647-y23rlfsxOlusN-GR917p9A-1; Wed, 11 May 2022 08:47:07 -0400 X-MC-Unique: y23rlfsxOlusN-GR917p9A-1 Received: from smtp.corp.redhat.com (int-mx04.intmail.prod.int.rdu2.redhat.com [10.11.54.4]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx02.redhat.com (Postfix) with ESMTPS id 35BD410726B3; Wed, 11 May 2022 12:46:53 +0000 (UTC) Received: from blackfin.pond.sub.org (unknown [10.36.112.3]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 6BE292026D6A; Wed, 11 May 2022 12:46:50 +0000 (UTC) Received: by blackfin.pond.sub.org (Postfix, from userid 1000) id 439F421E6880; Wed, 11 May 2022 14:46:49 +0200 (CEST) From: Markus Armbruster To: Jason Wang Cc: Andrew Melnichenko , Peter Maydell , Paolo Bonzini , qemu-devel , Yuri Benditovich , Yan Vugenfirer Subject: Re: ebpf/rss.bpf.skeleton.h generated by what? References: <87a6bulueg.fsf@pond.sub.org> <8a8b144a-c9d6-41b0-71fd-c7850dce9c93@redhat.com> <87bkw7e0mc.fsf@pond.sub.org> Date: Wed, 11 May 2022 14:46:49 +0200 In-Reply-To: (Jason Wang's message of "Wed, 11 May 2022 16:53:23 +0800") Message-ID: <878rr8grt2.fsf@pond.sub.org> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.2 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-Scanned-By: MIMEDefang 2.78 on 10.11.54.4 Received-SPF: pass client-ip=170.10.129.124; envelope-from=armbru@redhat.com; helo=us-smtp-delivery-124.mimecast.com X-Spam_score_int: -28 X-Spam_score: -2.9 X-Spam_bar: -- X-Spam_report: (-2.9 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.082, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_LOW=-0.7, SPF_HELO_NONE=0.001, SPF_PASS=-0.001, T_SCC_BODY_TEXT_LINE=-0.01 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Sender: "Qemu-devel" Jason Wang writes: > On Tue, May 10, 2022 at 8:24 PM Andrew Melnichenko wrote: >> >> Hi all, >> The ebpf/rss.bpf.skeleton.h is generetad by bpftool from tools/ebpf/rss.bpf.c. >> To generate the skeleton - would require dependencies of llvm and bpftool. >> RSS eBPF solution, for now, is only for Linux hosts. >> >> > Andrew, want to post a patch to explain this? >> I am all in for clarification. And will prepare a new patch if required. >> Please advise, what those patches should be? Documentation update? > > It looks to me the doc are fine: > > """ > RSS eBPF program > ---------------- > > RSS program located in ebpf/rss.bpf.skeleton.h generated by bpftool. > So the program is part of the qemu binary. > Initially, the eBPF program was compiled by clang and source code > located at tools/ebpf/rss.bpf.c. > """ Agreed. > It was too late to fix the changelog but we probably don't have anything to do. Next time :) > Or we can update ebpf/rss.bpf.skeleton.h by using the most recent > bpftool where I've added the BPFTOOL as the generator name[1]. Won't hurt, but no rush. > Thanks > > [1] https://git.kernel.org/pub/scm/linux/kernel/git/bpf/bpf-next.git/commit/?id=56c3e749d08a