From: "Toke Høiland-Jørgensen" <toke@toke.dk>
To: trix@redhat.com, kvalo@kernel.org, davem@davemloft.net,
kuba@kernel.org, pabeni@redhat.com
Cc: linux-wireless@vger.kernel.org, netdev@vger.kernel.org,
linux-kernel@vger.kernel.org, Tom Rix <trix@redhat.com>
Subject: Re: [PATCH v2] ath9k: initialize arrays at compile time
Date: Mon, 28 Mar 2022 17:45:19 +0200 [thread overview]
Message-ID: <878rsu5be8.fsf@toke.dk> (raw)
In-Reply-To: <20220328130727.3090827-1-trix@redhat.com>
trix@redhat.com writes:
> From: Tom Rix <trix@redhat.com>
>
> Early clearing of arrays with
> memset(array, 0, size);
> is equivilent to initializing the array in its decl with
> array[size] = {};
>
> Convert the memsets to initializations.
>
> Signed-off-by: Tom Rix <trix@redhat.com>
The changes LGTM. However, the patch doesn't apply cleanly; could you
please rebase against the ath-next branch[0] and resubmit?
-Toke
[0] https://git.kernel.org/pub/scm/linux/kernel/git/kvalo/ath.git/log/?h=ath-next
prev parent reply other threads:[~2022-03-28 15:46 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-03-28 13:07 [PATCH v2] ath9k: initialize arrays at compile time trix
2022-03-28 13:39 ` Kalle Valo
2022-03-28 14:08 ` Toke Høiland-Jørgensen
2022-03-28 14:17 ` Kalle Valo
2022-03-28 15:45 ` Toke Høiland-Jørgensen [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=878rsu5be8.fsf@toke.dk \
--to=toke@toke.dk \
--cc=davem@davemloft.net \
--cc=kuba@kernel.org \
--cc=kvalo@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-wireless@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=trix@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.