From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <igt-dev-bounces@lists.freedesktop.org>
Received: from mga06.intel.com (mga06.intel.com [134.134.136.31])
 by gabe.freedesktop.org (Postfix) with ESMTPS id D647510EB7C
 for <igt-dev@lists.freedesktop.org>; Sat, 12 Feb 2022 01:23:59 +0000 (UTC)
Date: Fri, 11 Feb 2022 17:23:39 -0800
Message-ID: <878rug27z8.wl-ashutosh.dixit@intel.com>
From: "Dixit, Ashutosh" <ashutosh.dixit@intel.com>
In-Reply-To: <20220211161314.16602-1-anshuman.gupta@intel.com>
References: <20220211161314.16602-1-anshuman.gupta@intel.com>
MIME-Version: 1.0 (generated by SEMI-EPG 1.14.7 - "Harue")
Content-Type: text/plain; charset=US-ASCII
Subject: Re: [igt-dev] [PATCH i-g-t] tests: i915_pm_rpm : Dump
 i915_runtime_pm_status
List-Unsubscribe: <https://lists.freedesktop.org/mailman/options/igt-dev>,
 <mailto:igt-dev-request@lists.freedesktop.org?subject=unsubscribe>
List-Archive: <https://lists.freedesktop.org/archives/igt-dev>
List-Post: <mailto:igt-dev@lists.freedesktop.org>
List-Help: <mailto:igt-dev-request@lists.freedesktop.org?subject=help>
List-Subscribe: <https://lists.freedesktop.org/mailman/listinfo/igt-dev>,
 <mailto:igt-dev-request@lists.freedesktop.org?subject=subscribe>
Errors-To: igt-dev-bounces@lists.freedesktop.org
Sender: "igt-dev" <igt-dev-bounces@lists.freedesktop.org>
To: Anshuman Gupta <anshuman.gupta@intel.com>
Cc: igt-dev@lists.freedesktop.org
List-ID: <igt-dev@lists.freedesktop.org>

On Fri, 11 Feb 2022 08:13:14 -0800, Anshuman Gupta wrote:
>
> Dump i915_runtime_pm_status conditionally whenever runtime pm status
> got active and it was expected to be suspended.
>
> Signed-off-by: Anshuman Gupta <anshuman.gupta@intel.com>
> ---
>  tests/i915/i915_pm_rpm.c | 13 ++++++++++---
>  1 file changed, 10 insertions(+), 3 deletions(-)
>
> diff --git a/tests/i915/i915_pm_rpm.c b/tests/i915/i915_pm_rpm.c
> index 648b0cffb..d1ba69af4 100644
> --- a/tests/i915/i915_pm_rpm.c
> +++ b/tests/i915/i915_pm_rpm.c
> @@ -201,10 +201,17 @@ static bool wait_for_pc8_status(enum pc8_status status)
>
>  static bool wait_for_suspended(void)
>  {
> -	if (has_pc8 && !has_runtime_pm)
> +	bool suspended = false;

Nit but maybe let's move this into the else, I'll move and merge it:

Reviewed-by: Ashutosh Dixit <ashutosh.dixit@intel.com>

> +
> +	if (has_pc8 && !has_runtime_pm) {
>		return wait_for_pc8_status(PC8_ENABLED);
> -	else
> -		return igt_wait_for_pm_status(IGT_RUNTIME_PM_STATUS_SUSPENDED);
> +	} else {
> +		suspended = igt_wait_for_pm_status(IGT_RUNTIME_PM_STATUS_SUSPENDED);
> +		if (!suspended)
> +			igt_debugfs_dump(drm_fd, "i915_runtime_pm_status");
> +
> +		return suspended;
> +	}
>  }
>
>  static bool wait_for_active(void)
> --
> 2.26.2
>