From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 1FF4FC433EF for ; Fri, 19 Nov 2021 14:17:35 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 06F1361B1B for ; Fri, 19 Nov 2021 14:17:35 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231529AbhKSOUg convert rfc822-to-8bit (ORCPT ); Fri, 19 Nov 2021 09:20:36 -0500 Received: from mail.kernel.org ([198.145.29.99]:58308 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S235781AbhKSOUf (ORCPT ); Fri, 19 Nov 2021 09:20:35 -0500 Received: from disco-boy.misterjones.org (disco-boy.misterjones.org [51.254.78.96]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id BF1DD619E3; Fri, 19 Nov 2021 14:17:33 +0000 (UTC) Received: from sofa.misterjones.org ([185.219.108.64] helo=why.misterjones.org) by disco-boy.misterjones.org with esmtpsa (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.94.2) (envelope-from ) id 1mo4hn-006Ys1-Tk; Fri, 19 Nov 2021 14:17:32 +0000 Date: Fri, 19 Nov 2021 14:17:31 +0000 Message-ID: <878rxk6xhg.wl-maz@kernel.org> From: Marc Zyngier To: Sai Prakash Ranjan Cc: Will Deacon , , Catalin Marinas , , , , , , , , Prasad Sodagudi Subject: Re: [PATCHv4 1/2] tracing: Add register read/write tracing support In-Reply-To: <6148397c-0565-d1ca-2f53-d15adcb9b6b8@quicinc.com> References: <4bd519d008cac6b319be7c5ce144e741f7210031.1636973694.git.quic_saipraka@quicinc.com> <87bl2g6z2v.wl-maz@kernel.org> <6148397c-0565-d1ca-2f53-d15adcb9b6b8@quicinc.com> User-Agent: Wanderlust/2.15.9 (Almost Unreal) SEMI-EPG/1.14.7 (Harue) FLIM-LB/1.14.9 (=?UTF-8?B?R29qxY0=?=) APEL-LB/10.8 EasyPG/1.0.0 Emacs/27.1 (x86_64-pc-linux-gnu) MULE/6.0 (HANACHIRUSATO) MIME-Version: 1.0 (generated by SEMI-EPG 1.14.7 - "Harue") Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8BIT X-SA-Exim-Connect-IP: 185.219.108.64 X-SA-Exim-Rcpt-To: quic_saipraka@quicinc.com, will@kernel.org, rostedt@goodmis.org, catalin.marinas@arm.com, quic_psodagud@quicinc.com, gregkh@linuxfoundation.org, arnd@arndb.de, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, linux-arm-msm@vger.kernel.org, mingo@redhat.com, psodagud@codeaurora.org X-SA-Exim-Mail-From: maz@kernel.org X-SA-Exim-Scanned: No (on disco-boy.misterjones.org); SAEximRunCond expanded to false Precedence: bulk List-ID: X-Mailing-List: linux-arm-msm@vger.kernel.org On Fri, 19 Nov 2021 14:07:09 +0000, Sai Prakash Ranjan wrote: > > On 11/19/2021 7:13 PM, Marc Zyngier wrote: > > On Mon, 15 Nov 2021 11:33:29 +0000, > > Sai Prakash Ranjan wrote: > >> From: Prasad Sodagudi > >> [...] > >> Reason why we wouldn't need value along with mmio write log is > >> that value can be easily deduced from the caller_name+offset which is > >> printed already by the rwmmio trace events which gives the exact > >> location of mmio writes and the value is easily known from the driver. > > That's a very narrow view of what can be written in an MMIO > > registers. We write dynamic values at all times, and if we are able to > > trace MMIO writes, then the value written out must be part of the trace. > > > > I'd rather you try and get to the bottom of this issue rather than > > paper over it. > > > > Thanks, > > > > M. > > > > Sure, idea was to put it out in the open if anyone has any idea as > to what might be happening there since the version where directly > instrumenting the raw read/write accessors in arm64/asm/io.h was > working fine casting doubts if this has to do something with > inlining as Arnd mentioned before. Yup. I wouldn't be surprised if MMIO accessors were getting directly inlined at the wrong location and creating havoc. For example: writel(readl(addr1) | 1, addr2); If you're not careful about capturing the result of the read rather than the read itself, you can end-up with something really funky. No idea if that's what is happening, but a disassembly of the generated code could tell you. M. -- Without deviation from the norm, progress is not possible. From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 3D23EC433F5 for ; Fri, 19 Nov 2021 14:18:55 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 02FD56108B for ; Fri, 19 Nov 2021 14:18:54 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.1 mail.kernel.org 02FD56108B Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=kernel.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To: Subject:Cc:To:From:Message-ID:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=2D9bZ2lIOIU9MlOuPTlTQRzS6QIPHlHQ0RDbpM1gfj8=; b=j8KNoPCCEE8sFT 7dJrLiCNSGVMLDd+KKbqyevY6qHTep9bV34dWP40qI9ClHRCnzYZe8JsZCqkxYs1U0xklGUxD0z5A kmK8LoTTHW5B30Cv8GFFMzH2b+37lxfnttLohSZ8XRMMLZpmJ7a6A36G9oDmv8kitLfpdet/z9A+l WWwNWNuSVloq6/SVnXKtt5q5W4TSwgq4RmUHOS/Ac3UVOJF4x2b1vQmDbP+lsEjlN0jSznL+MZLgm lfzqTbaYjQHdiW9ZLhTB11IRyhoPJRorGURMzjnziUDcj+82PGktJXrgypqtfCZwk4tg83F9FZz5H MnjRmp/5l20xEB3AtFiQ==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1mo4ht-00AdhY-RF; Fri, 19 Nov 2021 14:17:38 +0000 Received: from mail.kernel.org ([198.145.29.99]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1mo4hq-00AdgU-1c for linux-arm-kernel@lists.infradead.org; Fri, 19 Nov 2021 14:17:35 +0000 Received: from disco-boy.misterjones.org (disco-boy.misterjones.org [51.254.78.96]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id BF1DD619E3; Fri, 19 Nov 2021 14:17:33 +0000 (UTC) Received: from sofa.misterjones.org ([185.219.108.64] helo=why.misterjones.org) by disco-boy.misterjones.org with esmtpsa (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.94.2) (envelope-from ) id 1mo4hn-006Ys1-Tk; Fri, 19 Nov 2021 14:17:32 +0000 Date: Fri, 19 Nov 2021 14:17:31 +0000 Message-ID: <878rxk6xhg.wl-maz@kernel.org> From: Marc Zyngier To: Sai Prakash Ranjan Cc: Will Deacon , , Catalin Marinas , , , , , , , , Prasad Sodagudi Subject: Re: [PATCHv4 1/2] tracing: Add register read/write tracing support In-Reply-To: <6148397c-0565-d1ca-2f53-d15adcb9b6b8@quicinc.com> References: <4bd519d008cac6b319be7c5ce144e741f7210031.1636973694.git.quic_saipraka@quicinc.com> <87bl2g6z2v.wl-maz@kernel.org> <6148397c-0565-d1ca-2f53-d15adcb9b6b8@quicinc.com> User-Agent: Wanderlust/2.15.9 (Almost Unreal) SEMI-EPG/1.14.7 (Harue) FLIM-LB/1.14.9 (=?UTF-8?B?R29qxY0=?=) APEL-LB/10.8 EasyPG/1.0.0 Emacs/27.1 (x86_64-pc-linux-gnu) MULE/6.0 (HANACHIRUSATO) MIME-Version: 1.0 (generated by SEMI-EPG 1.14.7 - "Harue") X-SA-Exim-Connect-IP: 185.219.108.64 X-SA-Exim-Rcpt-To: quic_saipraka@quicinc.com, will@kernel.org, rostedt@goodmis.org, catalin.marinas@arm.com, quic_psodagud@quicinc.com, gregkh@linuxfoundation.org, arnd@arndb.de, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, linux-arm-msm@vger.kernel.org, mingo@redhat.com, psodagud@codeaurora.org X-SA-Exim-Mail-From: maz@kernel.org X-SA-Exim-Scanned: No (on disco-boy.misterjones.org); SAEximRunCond expanded to false X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20211119_061734_149804_686D6776 X-CRM114-Status: GOOD ( 27.30 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org T24gRnJpLCAxOSBOb3YgMjAyMSAxNDowNzowOSArMDAwMCwKU2FpIFByYWthc2ggUmFuamFuIDxx dWljX3NhaXByYWthQHF1aWNpbmMuY29tPiB3cm90ZToKPiAKPiBPbiAxMS8xOS8yMDIxIDc6MTMg UE0sIE1hcmMgWnluZ2llciB3cm90ZToKPiA+IE9uIE1vbiwgMTUgTm92IDIwMjEgMTE6MzM6Mjkg KzAwMDAsCj4gPiBTYWkgUHJha2FzaCBSYW5qYW4gPHF1aWNfc2FpcHJha2FAcXVpY2luYy5jb20+ IHdyb3RlOgo+ID4+IEZyb206IFByYXNhZCBTb2RhZ3VkaSA8cHNvZGFndWRAY29kZWF1cm9yYS5v cmc+Cj4gPj4gCgpbLi4uXQoKPiA+PiBSZWFzb24gd2h5IHdlIHdvdWxkbid0IG5lZWQgdmFsdWUg YWxvbmcgd2l0aCBtbWlvIHdyaXRlIGxvZyBpcwo+ID4+IHRoYXQgdmFsdWUgY2FuIGJlIGVhc2ls eSBkZWR1Y2VkIGZyb20gdGhlIGNhbGxlcl9uYW1lK29mZnNldCB3aGljaCBpcwo+ID4+IHByaW50 ZWQgYWxyZWFkeSBieSB0aGUgcndtbWlvIHRyYWNlIGV2ZW50cyB3aGljaCBnaXZlcyB0aGUgZXhh Y3QKPiA+PiBsb2NhdGlvbiBvZiBtbWlvIHdyaXRlcyBhbmQgdGhlIHZhbHVlIGlzIGVhc2lseSBr bm93biBmcm9tIHRoZSBkcml2ZXIuCj4gPiBUaGF0J3MgYSB2ZXJ5IG5hcnJvdyB2aWV3IG9mIHdo YXQgY2FuIGJlIHdyaXR0ZW4gaW4gYW4gTU1JTwo+ID4gcmVnaXN0ZXJzLiBXZSB3cml0ZSBkeW5h bWljIHZhbHVlcyBhdCBhbGwgdGltZXMsIGFuZCBpZiB3ZSBhcmUgYWJsZSB0bwo+ID4gdHJhY2Ug TU1JTyB3cml0ZXMsIHRoZW4gdGhlIHZhbHVlIHdyaXR0ZW4gb3V0IG11c3QgYmUgcGFydCBvZiB0 aGUgdHJhY2UuCj4gPiAKPiA+IEknZCByYXRoZXIgeW91IHRyeSBhbmQgZ2V0IHRvIHRoZSBib3R0 b20gb2YgdGhpcyBpc3N1ZSByYXRoZXIgdGhhbgo+ID4gcGFwZXIgb3ZlciBpdC4KPiA+IAo+ID4g VGhhbmtzLAo+ID4gCj4gPiAJTS4KPiA+IAo+IAo+IFN1cmUsIGlkZWEgd2FzIHRvIHB1dCBpdCBv dXQgaW4gdGhlIG9wZW4gaWYgYW55b25lIGhhcyBhbnkgaWRlYSBhcwo+IHRvIHdoYXQgbWlnaHQg YmUgaGFwcGVuaW5nIHRoZXJlIHNpbmNlIHRoZSB2ZXJzaW9uIHdoZXJlIGRpcmVjdGx5Cj4gaW5z dHJ1bWVudGluZyB0aGUgcmF3IHJlYWQvd3JpdGUgYWNjZXNzb3JzIGluIGFybTY0L2FzbS9pby5o IHdhcwo+IHdvcmtpbmcgZmluZSBjYXN0aW5nIGRvdWJ0cyBpZiB0aGlzIGhhcyB0byBkbyBzb21l dGhpbmcgd2l0aAo+IGlubGluaW5nIGFzIEFybmQgbWVudGlvbmVkIGJlZm9yZS4KCll1cC4gSSB3 b3VsZG4ndCBiZSBzdXJwcmlzZWQgaWYgTU1JTyBhY2Nlc3NvcnMgd2VyZSBnZXR0aW5nIGRpcmVj dGx5CmlubGluZWTCoGF0IHRoZSB3cm9uZyBsb2NhdGlvbiBhbmQgY3JlYXRpbmcgaGF2b2MuIEZv ciBleGFtcGxlOgoKCXdyaXRlbChyZWFkbChhZGRyMSkgfCAxLCBhZGRyMik7CgpJZiB5b3UncmUg bm90IGNhcmVmdWwgYWJvdXQgY2FwdHVyaW5nIHRoZSByZXN1bHQgb2YgdGhlIHJlYWQgcmF0aGVy CnRoYW4gdGhlIHJlYWQgaXRzZWxmLCB5b3UgY2FuIGVuZC11cCB3aXRoIHNvbWV0aGluZyByZWFs bHkgZnVua3kuIE5vCmlkZWEgaWYgdGhhdCdzIHdoYXQgaXMgaGFwcGVuaW5nLCBidXQgYSBkaXNh c3NlbWJseSBvZiB0aGUgZ2VuZXJhdGVkCmNvZGUgY291bGQgdGVsbCB5b3UuCgoJTS4KCi0tIApX aXRob3V0IGRldmlhdGlvbiBmcm9tIHRoZSBub3JtLCBwcm9ncmVzcyBpcyBub3QgcG9zc2libGUu CgpfX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fXwpsaW51eC1h cm0ta2VybmVsIG1haWxpbmcgbGlzdApsaW51eC1hcm0ta2VybmVsQGxpc3RzLmluZnJhZGVhZC5v cmcKaHR0cDovL2xpc3RzLmluZnJhZGVhZC5vcmcvbWFpbG1hbi9saXN0aW5mby9saW51eC1hcm0t a2VybmVsCg==