From: Richard Palethorpe <rpalethorpe@suse.de>
To: Li Wang <liwang@redhat.com>
Cc: ltp@lists.linux.it
Subject: Re: [LTP] [PATCH v4 1/3] lib: adding .supported_archs field in tst_test structure
Date: Tue, 16 Nov 2021 10:30:29 +0000 [thread overview]
Message-ID: <878rxobdc5.fsf@suse.de> (raw)
In-Reply-To: <CAEemH2fJHN5i0W9poB6H2JWXUNRBjriXp21VG4x8r5n4oMvhbw@mail.gmail.com>
Hello Li,
Li Wang <liwang@redhat.com> writes:
>
> > +#ifndef TST_ARCH_H__
> > +#define TST_ARCH_H__
> > +
> > +enum tst_arch_type {
> > + TST_UNKNOWN,
> > + TST_I386,
>
> I would still probably name this TST_X86, Linux does not support i386
> anymore, the remaining 32bit distributions usually require at least i586
> or i686...
>
> Sure, If go with that TST_X86, we just need to do modifications based on
> V4 like below, right? What else am I missing here?
Cyril made another comment about static keyword usage on patch 2. Could
you please roll a V5?
--
Thank you,
Richard.
--
Mailing list info: https://lists.linux.it/listinfo/ltp
prev parent reply other threads:[~2021-11-16 10:32 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-11-09 13:09 [LTP] [PATCH v4 1/3] lib: adding .supported_archs field in tst_test structure Li Wang
2021-11-09 13:09 ` [LTP] [PATCH v4 2/3] testcase: make use of .supported_archs Li Wang
2021-11-09 16:23 ` Cyril Hrubis
2021-11-16 10:27 ` Richard Palethorpe
2021-11-09 13:09 ` [LTP] [PATCH v4 3/3] max_map_count: replace ifdefs by tst_arch Li Wang
2021-11-09 16:24 ` Cyril Hrubis
2021-11-09 16:11 ` [LTP] [PATCH v4 1/3] lib: adding .supported_archs field in tst_test structure Cyril Hrubis
2021-11-12 6:41 ` Li Wang
2021-11-16 10:30 ` Richard Palethorpe [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=878rxobdc5.fsf@suse.de \
--to=rpalethorpe@suse.de \
--cc=liwang@redhat.com \
--cc=ltp@lists.linux.it \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.