Re: [PATCH v2 2/2] board: mntre: imx8mq: Add MNT Reform 2 board support

[Vagrant Cascadian <vagrant@debian.org>]

[-- Attachment #1: Type: text/plain, Size: 3538 bytes --]

On 2021-09-02, Patrick Wildt wrote:
> The MNT Reform 2 is a modular DIY laptop.  In its initial version it
> is based on the BoundaryDevices i.MX8MQ SoM.  Some parts have been
> lifted from BoundaryDevices official U-Boot downstream project.

Thanks for working on this!

I'm struggling a bit getting it to actually boot; how is this supposed
to be installed to the device?

I've built with the two applied patches on a patched v2021.10, copying
various firmware parts from:

  https://source.mnt.re/reform/reform-boundary-uboot/-/blob/master/bl31-iMX8MQ.bin
  https://source.mnt.re/reform/reform-boundary-uboot/-/blob/master/lpddr4_pmu_train_1d_dmem.bin
  https://source.mnt.re/reform/reform-boundary-uboot/-/blob/master/lpddr4_pmu_train_1d_imem.bin
  https://source.mnt.re/reform/reform-boundary-uboot/-/blob/master/lpddr4_pmu_train_2d_dmem.bin
  https://source.mnt.re/reform/reform-boundary-uboot/-/blob/master/lpddr4_pmu_train_2d_imem.bin

  export BL31=bl31-iMX8MQ.bin

  make imx8mq_reform2_defconfig
  make
  make flash.bin

Then grepping various other README's from imx8mq devices, I tried two
different processes:

  dd if=flash.bin of=/dev/sd[x] bs=1K seek=33

and:

  dd if=flash.bin of=/dev/sd[x] bs=1024 seek=33 conv=sync
  dd if=u-boot.itb of=/dev/sd[x] bs=1024 seek=384 conv=sync

Both simply hanging with:

  U-Boot SPL 2021.10 (Jan 01 1970 - 00:00:01 +0000)

Is the flash.bin step unecessary? I see DDR timing code in the patch
series; are corresponding lpddr4*.bin no longer necessary?

I also tried building with an old version of arm-trusted-firmware
(v2.2), as that was the most recent upstream version that successfully
built. This seems to be a fork of ATF that has support for iMX8MQ, but
it is unclear which branch/tag/etc. should be used with the mnt/reform:

  https://source.codeaurora.org/external/imx/imx-atf


It would be nice to include a board README in the next patch revision to
spell out some of the details of exactly which other projects and
versions/comments/branches are expected to work with MNT Reform2.


I would be nice if you could CC me on future patch series revisions to
be able to test. Thanks!


live well,
  vagrant


> Signed-off-by: Patrick Wildt <patrick@blueri.se>
> ---
>  arch/arm/dts/imx8mq-mnt-reform2-u-boot.dtsi   |   11 +
>  arch/arm/mach-imx/imx8m/Kconfig               |    6 +
>  board/mntre/imx8mq_reform2/Kconfig            |   12 +
>  board/mntre/imx8mq_reform2/MAINTAINERS        |    7 +
>  board/mntre/imx8mq_reform2/Makefile           |   12 +
>  board/mntre/imx8mq_reform2/imx8mq_reform2.c   |  213 ++++
>  board/mntre/imx8mq_reform2/lpddr4_timing.c    | 1014 +++++++++++++++++
>  .../mntre/imx8mq_reform2/lpddr4_timing_ch2.h  |   95 ++
>  board/mntre/imx8mq_reform2/spl.c              |  260 +++++
>  configs/imx8mq_reform2_defconfig              |   67 ++
>  include/configs/imx8mq_reform2.h              |  151 +++
>  11 files changed, 1848 insertions(+)
>  create mode 100644 arch/arm/dts/imx8mq-mnt-reform2-u-boot.dtsi
>  create mode 100644 board/mntre/imx8mq_reform2/Kconfig
>  create mode 100644 board/mntre/imx8mq_reform2/MAINTAINERS
>  create mode 100644 board/mntre/imx8mq_reform2/Makefile
>  create mode 100644 board/mntre/imx8mq_reform2/imx8mq_reform2.c
>  create mode 100644 board/mntre/imx8mq_reform2/lpddr4_timing.c
>  create mode 100644 board/mntre/imx8mq_reform2/lpddr4_timing_ch2.h
>  create mode 100644 board/mntre/imx8mq_reform2/spl.c
>  create mode 100644 configs/imx8mq_reform2_defconfig
>  create mode 100644 include/configs/imx8mq_reform2.h

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 227 bytes --]