Re: [igt-dev] [PATCH i-g-t] lib/i915: Fix gem_has_execlists to match description

["Dixit, Ashutosh" <ashutosh.dixit@intel.com>]

On Fri, 15 Oct 2021 16:38:45 -0700, Ashutosh Dixit wrote:
>
> Driver is using execlists if it is not using GuC submission.
> GEM_SUBMISSION_EXECLISTS flag indicates if execlist submission is
> available, not if it is being used by the driver.
>
> Signed-off-by: Ashutosh Dixit <ashutosh.dixit@intel.com>
> ---
>  lib/i915/gem_submission.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/lib/i915/gem_submission.c b/lib/i915/gem_submission.c
> index 2627b802cfb..4312a73bd85 100644
> --- a/lib/i915/gem_submission.c
> +++ b/lib/i915/gem_submission.c
> @@ -153,7 +153,7 @@ bool gem_has_semaphores(int fd)
>   */
>  bool gem_has_execlists(int fd)
>  {
> -	return gem_submission_method(fd) & GEM_SUBMISSION_EXECLISTS;
> +	return !gem_has_guc_submission(fd);

Could the reviewers also check if anything needs to be done for these two
call sites for gem_has_execlists(). Thanks!

*** tests/i915/gem_ctx_shared.c:
disjoint_timelines[162]        igt_require(gem_has_execlists(i915));

*** tests/i915/gem_watchdog.c:
virtual[225]                   igt_require(gem_has_execlists(i915));