From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Sender: List-Post: List-Help: List-Unsubscribe: List-Subscribe: Received: from lists.oasis-open.org (oasis-open.org [10.110.1.242]) by lists.oasis-open.org (Postfix) with ESMTP id 6250198640D for ; Wed, 13 Oct 2021 09:44:31 +0000 (UTC) From: Cornelia Huck In-Reply-To: <20211013093316.ehxp5xizo5sy52ct@vireshk-i7> References: <325276eec77c6ab3bd28382386055b821754396b.1634037711.git.viresh.kumar@linaro.org> <87bl3twa15.fsf@redhat.com> <20211013093316.ehxp5xizo5sy52ct@vireshk-i7> Date: Wed, 13 Oct 2021 11:44:03 +0200 Message-ID: <878ryxw97g.fsf@redhat.com> MIME-Version: 1.0 Subject: [virtio-dev] Re: [PATCH V5 2/2] virtio: i2c: Allow zero-length transactions Content-Type: text/plain To: Viresh Kumar Cc: "Michael S. Tsirkin" , Jie Deng , Wolfram Sang , Paolo Bonzini , Vincent Guittot , Jason Wang , Bill Mills , Alex =?utf-8?Q?Benn=C3=A9e?= , virtio-dev@lists.oasis-open.org, stratos-dev@op-lists.linaro.org, Gerd Hoffmann , Arnd Bergmann List-ID: On Wed, Oct 13 2021, Viresh Kumar wrote: > On 13-10-21, 11:26, Cornelia Huck wrote: >> On Tue, Oct 12 2021, Viresh Kumar wrote: >> > @@ -124,13 +140,23 @@ \subsubsection{Device Operation: Operation Status}\label{sec:Device Types / I2C >> > >> > \drivernormative{\subsubsection}{Device Operation}{Device Types / I2C Adapter Device / Device Operation} >> > >> > +A driver SHOULD implement the VIRTIO_I2C_F_ZERO_LENGTH_REQUEST feature. >> >> Make this MUST, or maybe "MUST accept"? The central point of the feature >> flag (at least for me) was to be able to change the semantics and format >> without things breaking silently. > > Right. > >> I don't think we need to keep old >> driver revisions compliant? > > No, we don't. Thinking some more, we'll also probably want the driver to reject any device that does not offer the feature. Just keep those old device/driver revisions to themselves :) --------------------------------------------------------------------- To unsubscribe, e-mail: virtio-dev-unsubscribe@lists.oasis-open.org For additional commands, e-mail: virtio-dev-help@lists.oasis-open.org