From: Markus Armbruster <armbru@redhat.com>
To: "Daniel P. Berrangé" <berrange@redhat.com>
Cc: Eduardo Habkost <ehabkost@redhat.com>,
Eric Blake <eblake@redhat.com>,
qemu-devel@nongnu.org,
"Dr. David Alan Gilbert" <dgilbert@redhat.com>
Subject: Re: [PATCH 0/5] Stop adding HMP-only commands, allow QMP for all
Date: Thu, 09 Sep 2021 10:13:32 +0200 [thread overview]
Message-ID: <878s06p3o3.fsf@dusky.pond.sub.org> (raw)
In-Reply-To: <87lf46pd62.fsf@dusky.pond.sub.org> (Markus Armbruster's message of "Thu, 09 Sep 2021 06:48:21 +0200")
Markus Armbruster <armbru@redhat.com> writes:
[...]
> Limitations:
>
> 1. If we convert a long-running HMP command to this technique, we print
> its output only after it completed its work. We also end up with a
> long-running QMP command, which is bad, because it stops the main
> loop and makes the QMP monitor unresponsive (except for OOB commands,
> if the client is careful). The former can be mitigated with
> 'coroutine': true. The latter can't.
>
> 2. We can't prompt for input.
>
> The only current use I can see is HMP "change vnc passwd" prompting
> for a password. Except you currently have to say "change vnc passwd
> wtf" to get it to prompt (suspect logic error in commit cfb5387a1de).
Subject: [PATCH 1/2] hmp: Unbreak "change vnc"
Message-Id: <20210909081219.308065-2-armbru@redhat.com>
>
>
> [...]
next prev parent reply other threads:[~2021-09-09 8:16 UTC|newest]
Thread overview: 28+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-09-08 10:37 [PATCH 0/5] Stop adding HMP-only commands, allow QMP for all Daniel P. Berrangé
2021-09-08 10:37 ` [PATCH 1/5] docs/devel: document expectations for QAPI data modelling for QMP Daniel P. Berrangé
2021-09-08 17:42 ` Eric Blake
2021-09-09 9:33 ` Markus Armbruster
2021-09-10 12:46 ` Daniel P. Berrangé
2021-09-10 13:45 ` Markus Armbruster
2021-09-10 13:52 ` Daniel P. Berrangé
2021-09-08 10:37 ` [PATCH 2/5] hw/core: introduce 'format_state' callback to replace 'dump_state' Daniel P. Berrangé
2021-09-08 10:37 ` [PATCH 3/5] target/i386: convert to use format_state instead of dump_state Daniel P. Berrangé
2021-09-08 12:17 ` Ján Tomko
2021-09-08 18:05 ` Eric Blake
2021-09-08 22:06 ` Daniel P. Berrangé
2021-09-09 9:55 ` Daniel P. Berrangé
2021-09-08 10:37 ` [PATCH 4/5] qapi: introduce x-query-registers QMP command Daniel P. Berrangé
2021-09-08 18:06 ` Eric Blake
2021-09-09 9:05 ` Markus Armbruster
2021-09-09 10:01 ` Daniel P. Berrangé
2021-09-08 10:37 ` [PATCH 5/5] monitor: rewrite 'info registers' in terms of 'x-query-registers' Daniel P. Berrangé
2021-09-08 11:01 ` Philippe Mathieu-Daudé
2021-09-08 11:02 ` Daniel P. Berrangé
2021-09-08 12:18 ` [PATCH 0/5] Stop adding HMP-only commands, allow QMP for all Ján Tomko
2021-09-08 15:09 ` Markus Armbruster
2021-09-08 15:24 ` Daniel P. Berrangé
2021-09-09 4:48 ` Markus Armbruster
2021-09-09 8:13 ` Markus Armbruster [this message]
2021-09-09 8:40 ` Daniel P. Berrangé
2021-09-08 16:15 ` Philippe Mathieu-Daudé
2021-09-09 6:15 ` Paolo Bonzini
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=878s06p3o3.fsf@dusky.pond.sub.org \
--to=armbru@redhat.com \
--cc=berrange@redhat.com \
--cc=dgilbert@redhat.com \
--cc=eblake@redhat.com \
--cc=ehabkost@redhat.com \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.