From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-11.7 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,INCLUDES_CR_TRAILER,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 547F1C4338F for ; Fri, 20 Aug 2021 10:07:06 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 335A6610F9 for ; Fri, 20 Aug 2021 10:07:06 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S237085AbhHTKHm (ORCPT ); Fri, 20 Aug 2021 06:07:42 -0400 Received: from mail.kernel.org ([198.145.29.99]:55966 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S232244AbhHTKHl (ORCPT ); Fri, 20 Aug 2021 06:07:41 -0400 Received: by mail.kernel.org (Postfix) with ESMTPSA id DD9476024A; Fri, 20 Aug 2021 10:07:01 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1629454024; bh=4wOWt2TLJnChpQZUoUnZ7pdN3g/0c/c11ETk2UqFr7w=; h=References:From:To:Cc:Subject:Date:In-reply-to:From; b=Z9iuAsW3c17hodu6Hgq6226o2iKkjrnDSLYW/eEIFf5COL+zNpvEOaf49CqrpDiMp 2VtLuppafClyPPIzOHDdpOxerJxfrGOH0DncrlkR5dtR6Yd2Ki2g8+XklrDzt5snOt sAABGBYzV6REPEMdCg9yNSZ2vq23ArlwH2s0atAN0G0J9Q/WLpOclelAGDEpPSyW7W HUoSYTBIu6Zkw2IWj7XOqt7ZHe9+vRaILNXUDYrw7NW8VM1j38hegdj8zM3kHNy3aZ ivfRB1sb46h9nrBsIdVGD1h99d4LI5ZTLXQ/A31qv1hDldEejZgPyVpusnr6ksjEU0 wGlW/8wThl4Cg== References: <20210819154818.18334-1-lutovinova@ispras.ru> User-agent: mu4e 1.6.3; emacs 27.2 From: Felipe Balbi To: Nadezda Lutovinova Cc: Greg Kroah-Hartman , Shawn Guo , Sascha Hauer , Pengutronix Kernel Team , Fabio Estevam , NXP Linux Team , linux-usb@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, ldv-project@linuxtesting.org Subject: Re: [PATCH] usb: dwc3: imx8mp: request irq after initializing dwc3 Date: Fri, 20 Aug 2021 13:06:33 +0300 In-reply-to: <20210819154818.18334-1-lutovinova@ispras.ru> Message-ID: <878s0wfn0c.fsf@kernel.org> MIME-Version: 1.0 Content-Type: text/plain Precedence: bulk List-ID: X-Mailing-List: linux-usb@vger.kernel.org Nadezda Lutovinova writes: > If IRQ occurs between calling devm_request_threaded_irq() and > initializing dwc3_imx->dwc3, then null pointer dereference occurs > since dwc3_imx->dwc3 is used in dwc3_imx8mp_interrupt(). > > The patch puts registration of the interrupt handler after > initializing of neccesery data. > > Found by Linux Driver Verification project (linuxtesting.org). > > Signed-off-by: Nadezda Lutovinova Acked-by: Felipe Balbi -- balbi From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-9.7 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,INCLUDES_CR_TRAILER,MAILING_LIST_MULTI,SPF_HELO_NONE, SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id DCA00C43214 for ; Fri, 20 Aug 2021 10:08:56 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id ADF9F610F9 for ; Fri, 20 Aug 2021 10:08:56 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.1 mail.kernel.org ADF9F610F9 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=kernel.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:Message-ID:In-reply-to: Date:Subject:Cc:To:From:References:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=yR6j+YOFCpQdPogMjlnY0b7vi+GRPVLU8DZTMdy/OOE=; b=yJ7n8Mmpm2gmYf Ts2VtkqF1UpO2NJW5QJW1G1I5u4D4jkoCgQquDA/tP1GkrlrTmUnEA0TdjgC1PPeTqPuRfNDyEsZU FfhlY+hR/+ETxT09spGVTBqg+6m/f7v3N32zXDrDW5txYpSF8GMoqS28elS6t61cBo4bwhQYLsjTT lZnyEAT9tdy6fitqRhUmiJAup01QTuldxVi8qludtUXnHYHY0vh9rMILJA+JpbnMGMSe/MCQNPOlo GAqM6lB8IrJR9UcnNjim4SavP0MqaasiWtdJlgZ/JTfJ8Hv2sg33DKiV26rxc236mPdfmxfp6KE49 tk/UF22Rz5POp8kmMc+Q==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1mH1QZ-00Ad4p-Ro; Fri, 20 Aug 2021 10:07:08 +0000 Received: from mail.kernel.org ([198.145.29.99]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1mH1QW-00Ad4K-S4 for linux-arm-kernel@lists.infradead.org; Fri, 20 Aug 2021 10:07:06 +0000 Received: by mail.kernel.org (Postfix) with ESMTPSA id DD9476024A; Fri, 20 Aug 2021 10:07:01 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1629454024; bh=4wOWt2TLJnChpQZUoUnZ7pdN3g/0c/c11ETk2UqFr7w=; h=References:From:To:Cc:Subject:Date:In-reply-to:From; b=Z9iuAsW3c17hodu6Hgq6226o2iKkjrnDSLYW/eEIFf5COL+zNpvEOaf49CqrpDiMp 2VtLuppafClyPPIzOHDdpOxerJxfrGOH0DncrlkR5dtR6Yd2Ki2g8+XklrDzt5snOt sAABGBYzV6REPEMdCg9yNSZ2vq23ArlwH2s0atAN0G0J9Q/WLpOclelAGDEpPSyW7W HUoSYTBIu6Zkw2IWj7XOqt7ZHe9+vRaILNXUDYrw7NW8VM1j38hegdj8zM3kHNy3aZ ivfRB1sb46h9nrBsIdVGD1h99d4LI5ZTLXQ/A31qv1hDldEejZgPyVpusnr6ksjEU0 wGlW/8wThl4Cg== References: <20210819154818.18334-1-lutovinova@ispras.ru> User-agent: mu4e 1.6.3; emacs 27.2 From: Felipe Balbi To: Nadezda Lutovinova Cc: Greg Kroah-Hartman , Shawn Guo , Sascha Hauer , Pengutronix Kernel Team , Fabio Estevam , NXP Linux Team , linux-usb@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, ldv-project@linuxtesting.org Subject: Re: [PATCH] usb: dwc3: imx8mp: request irq after initializing dwc3 Date: Fri, 20 Aug 2021 13:06:33 +0300 In-reply-to: <20210819154818.18334-1-lutovinova@ispras.ru> Message-ID: <878s0wfn0c.fsf@kernel.org> MIME-Version: 1.0 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20210820_030704_961284_4ED0F3EE X-CRM114-Status: UNSURE ( 6.85 ) X-CRM114-Notice: Please train this message. X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org Nadezda Lutovinova writes: > If IRQ occurs between calling devm_request_threaded_irq() and > initializing dwc3_imx->dwc3, then null pointer dereference occurs > since dwc3_imx->dwc3 is used in dwc3_imx8mp_interrupt(). > > The patch puts registration of the interrupt handler after > initializing of neccesery data. > > Found by Linux Driver Verification project (linuxtesting.org). > > Signed-off-by: Nadezda Lutovinova Acked-by: Felipe Balbi -- balbi _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel