From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-13.8 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,INCLUDES_PATCH, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 56CFFC4338F for ; Mon, 16 Aug 2021 08:58:47 +0000 (UTC) Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 18B7661B46 for ; Mon, 16 Aug 2021 08:58:47 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.1 mail.kernel.org 18B7661B46 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=linux.intel.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=lists.freedesktop.org Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id F2FA989D63; Mon, 16 Aug 2021 08:58:45 +0000 (UTC) Received: from mga03.intel.com (mga03.intel.com [134.134.136.65]) by gabe.freedesktop.org (Postfix) with ESMTPS id 189C789D63 for ; Mon, 16 Aug 2021 08:58:42 +0000 (UTC) X-IronPort-AV: E=McAfee;i="6200,9189,10077"; a="215852691" X-IronPort-AV: E=Sophos;i="5.84,324,1620716400"; d="scan'208";a="215852691" Received: from fmsmga002.fm.intel.com ([10.253.24.26]) by orsmga103.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 16 Aug 2021 01:58:42 -0700 X-IronPort-AV: E=Sophos;i="5.84,324,1620716400"; d="scan'208";a="530283933" Received: from ifridman-mobl.ger.corp.intel.com (HELO localhost) ([10.251.210.77]) by fmsmga002-auth.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 16 Aug 2021 01:58:39 -0700 From: Jani Nikula To: Jackie Liu , keescook@chromium.org, daniel@ffwll.ch, mripard@kernel.org Cc: dri-devel@lists.freedesktop.org, liuyun01@kylinos.cn Subject: Re: [PATCH v2] drm/fb: Fix randconfig builds In-Reply-To: <20210816085231.2455369-1-liu.yun@linux.dev> Organization: Intel Finland Oy - BIC 0357606-4 - Westendinkatu 7, 02160 Espoo References: <20210816085231.2455369-1-liu.yun@linux.dev> Date: Mon, 16 Aug 2021 11:58:36 +0300 Message-ID: <878s11kbpf.fsf@intel.com> MIME-Version: 1.0 Content-Type: text/plain X-BeenThere: dri-devel@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Direct Rendering Infrastructure - Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" On Mon, 16 Aug 2021, Jackie Liu wrote: > From: Jackie Liu > > When CONFIG_DRM_FBDEV_EMULATION is compiled to y and CONFIG_FB is m, the > compilation will fail. we need make that dependency explicit. > > Fixes: f611b1e7624c ("drm: Avoid circular dependencies for CONFIG_FB") > Reported-by: k2ci > Signed-off-by: Jackie Liu Why do you send this while the discussion is still ongoing? Now this *requires* FB=y even if it *could* be FB=m when DRM_KMS_HELPER=m. BR, Jani. > --- > drivers/gpu/drm/Kconfig | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/gpu/drm/Kconfig b/drivers/gpu/drm/Kconfig > index 7ff89690a976..cd129d96e649 100644 > --- a/drivers/gpu/drm/Kconfig > +++ b/drivers/gpu/drm/Kconfig > @@ -98,7 +98,7 @@ config DRM_DEBUG_DP_MST_TOPOLOGY_REFS > config DRM_FBDEV_EMULATION > bool "Enable legacy fbdev support for your modesetting driver" > depends on DRM > - depends on FB > + depends on FB && FB != m > select DRM_KMS_HELPER > select FB_CFB_FILLRECT > select FB_CFB_COPYAREA -- Jani Nikula, Intel Open Source Graphics Center