From: Marc Zyngier <maz@kernel.org>
To: Mark Kettenis <openbsd@xs4all.nl>
Cc: "Alyssa Rosenzweig" <alyssa@rosenzweig.io>,
linux-pci@vger.kernel.org, "Bjorn Helgaas" <bhelgaas@google.com>,
"Rob Herring" <robh+dt@kernel.org>,
"Lorenzo Pieralisi" <lorenzo.pieralisi@arm.com>,
"Krzysztof Wilczyński" <kw@linux.com>,
"Stan Skowronek" <stan@corellium.com>,
"Mark Kettenis" <kettenis@openbsd.org>,
"Sven Peter" <sven@svenpeter.dev>,
"Hector Martin" <marcan@marcan.st>,
devicetree@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [RFC PATCH 1/2] dt-bindings: PCI: Add Apple PCI controller
Date: Sun, 15 Aug 2021 10:12:44 +0100 [thread overview]
Message-ID: <878s131377.wl-maz@kernel.org> (raw)
In-Reply-To: <1566004903.6140692.1629015053757@ox-webmail.xs4all.nl>
Hi Mark,
On Sun, 15 Aug 2021 09:10:53 +0100,
Mark Kettenis <openbsd@xs4all.nl> wrote:
>
> Hi Marc,
>
> What can I do to make progress with my binding proposal? It seems we're stuck
> on the MSI issue where you and robh disagree. I still think your idea of
> describing the MSIs as a range makes much more sense than describing them
> individually and bunching them together with the host bridge port interrupts.
>
It looks like I missed an email from Rob, which explains why we're in
limbo (it was left unread and unmarked, which in my flow means "read
once I have too much time on my hands"). Apologies for that, I'll try
and reply tonight (travelling at the moment).
> Op 15-08-2021 09:09 schreef Marc Zyngier <maz@kernel.org>:
>
> Hi Alyssa,
>
> On Sun, 15 Aug 2021 05:25:24 +0100,
> Alyssa Rosenzweig <alyssa@rosenzweig.io> wrote:
>
> Document the properties used by the Apple PCI controller. This is a
> fairly standard PCI controller, although it is not derived from any
> known non-Apple IP.
>
> Signed-off-by: Alyssa Rosenzweig <alyssa@rosenzweig.io>
>
> I would rather you post something as an extension to Mark's work, for
> multiple reasons:
>
> - Mark's patch is still being discussed, and is the current
> reference (specially given that it is already in use in OpenBSD and
> u-boot).
>
> - we cannot have multiple bindings. There can only be one, shared
> across implementations. Otherwise, you need a different kernel
> depending on whether you are booting from m1n1 or u-boot.
>
> - what you have here is vastly inconsistent (you are describing the
> MSIs twice, using two different methods).
>
> That's probably my fault. The current u-boot device tree is a bit of a
> Frankenstein thing to ease the transition from my initial binding to the
> current proposal. I should clean that up at some point.
That would certainly help. There are a lot of moving pieces at the
moment, and it is getting hard to get a clear picture of what is using
what.
Thanks,
M.
--
Without deviation from the norm, progress is not possible.
next prev parent reply other threads:[~2021-08-15 9:12 UTC|newest]
Thread overview: 28+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-08-15 4:25 [RFC PATCH 0/2] Add PCI driver for the Apple M1 Alyssa Rosenzweig
2021-08-15 4:25 ` [RFC PATCH 1/2] dt-bindings: PCI: Add Apple PCI controller Alyssa Rosenzweig
2021-08-15 7:09 ` Marc Zyngier
[not found] ` <1566004903.6140692.1629015053757@ox-webmail.xs4all.nl>
2021-08-15 9:12 ` Marc Zyngier [this message]
2021-08-16 1:34 ` Alyssa Rosenzweig
2021-08-22 18:03 ` Mark Kettenis
2021-08-15 4:25 ` [RFC PATCH 2/2] PCI: apple: Add driver for the Apple M1 Alyssa Rosenzweig
2021-08-15 5:55 ` kernel test robot
2021-08-15 7:42 ` Marc Zyngier
2021-08-15 9:19 ` Marc Zyngier
2021-08-16 1:45 ` Alyssa Rosenzweig
2021-08-15 12:33 ` Sven Peter
2021-08-15 16:49 ` Marc Zyngier
2021-08-16 6:37 ` Sven Peter
2021-08-18 11:43 ` Hector Martin
2021-08-18 14:22 ` Mark Kettenis
2021-08-16 1:31 ` Alyssa Rosenzweig
2021-08-16 21:56 ` Marc Zyngier
2021-08-17 7:34 ` Arnd Bergmann
2021-08-17 8:12 ` Marc Zyngier
2021-08-17 7:35 ` Sven Peter
2021-08-15 7:43 ` Sven Peter
2021-08-15 21:40 ` Alyssa Rosenzweig
2021-08-15 7:56 ` kernel test robot
2021-08-15 15:14 ` kernel test robot
2021-08-15 20:57 ` Rob Herring
2021-08-15 21:33 ` Alyssa Rosenzweig
[not found] ` <CAHp75VeKeGgUgALLztA3Q3jizF2=OkSzU9bzaPmTHO9Pad=QOQ@mail.gmail.com>
2021-08-16 3:20 ` Alyssa Rosenzweig
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=878s131377.wl-maz@kernel.org \
--to=maz@kernel.org \
--cc=alyssa@rosenzweig.io \
--cc=bhelgaas@google.com \
--cc=devicetree@vger.kernel.org \
--cc=kettenis@openbsd.org \
--cc=kw@linux.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pci@vger.kernel.org \
--cc=lorenzo.pieralisi@arm.com \
--cc=marcan@marcan.st \
--cc=openbsd@xs4all.nl \
--cc=robh+dt@kernel.org \
--cc=stan@corellium.com \
--cc=sven@svenpeter.dev \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.