From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-3.6 required=3.0 tests=BAYES_00,DKIM_INVALID, DKIM_SIGNED,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE, SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 918EAC433ED for ; Mon, 26 Apr 2021 05:20:43 +0000 (UTC) Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 29F4C60FEE for ; Mon, 26 Apr 2021 05:20:43 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 29F4C60FEE Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=redhat.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Received: from localhost ([::1]:46604 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1latfm-0004lz-4R for qemu-devel@archiver.kernel.org; Mon, 26 Apr 2021 01:20:42 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:51034) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1laten-0004Kx-QT for qemu-devel@nongnu.org; Mon, 26 Apr 2021 01:19:41 -0400 Received: from us-smtp-delivery-124.mimecast.com ([216.205.24.124]:23434) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1latel-0007Q4-06 for qemu-devel@nongnu.org; Mon, 26 Apr 2021 01:19:40 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1619414377; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=LWdelH5TMbLDs46XXbhwaSiVoKkMYcfMwfECD5hsn6U=; b=BqArjP83v1ohDlxAJ+mn9lhzKQiIPK/lbKRKqMNeRPvu3vt1FS36RBel6iMDP5eKN0+pqh rykDxl0KcAiBEomw7DoLscSfZNTWdGmCIt+t1oSVNFxxLd1+pL4yg0ZxeGoolcGWxPKeDo 63135BD6Y+rlpk5ZaLUm0LBJQhFbOM8= Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-389-aF0t65NTOEWLp7d_APr9Mw-1; Mon, 26 Apr 2021 01:19:35 -0400 X-MC-Unique: aF0t65NTOEWLp7d_APr9Mw-1 Received: from smtp.corp.redhat.com (int-mx07.intmail.prod.int.phx2.redhat.com [10.5.11.22]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id 6A96218397A3; Mon, 26 Apr 2021 05:19:34 +0000 (UTC) Received: from blackfin.pond.sub.org (ovpn-114-17.ams2.redhat.com [10.36.114.17]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 9B27110016FD; Mon, 26 Apr 2021 05:19:30 +0000 (UTC) Received: by blackfin.pond.sub.org (Postfix, from userid 1000) id 20BE3113525D; Mon, 26 Apr 2021 07:19:29 +0200 (CEST) From: Markus Armbruster To: Peter Maydell Subject: Re: Resetting non-qdev children in a 3-phase reset device References: <87y2datpyw.fsf@dusky.pond.sub.org> <5570bf5a-3cab-c30c-2c21-0ab02543199e@amsat.org> <2f4155ca-ee84-75f0-8b35-aac6b18ee4f0@amsat.org> <3dcb8efa-8f6b-0f45-a753-cc58d3bf9855@amsat.org> <87im4cb6ag.fsf@dusky.pond.sub.org> Date: Mon, 26 Apr 2021 07:19:29 +0200 In-Reply-To: (Peter Maydell's message of "Sun, 25 Apr 2021 19:33:25 +0100") Message-ID: <878s5539ni.fsf@dusky.pond.sub.org> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.1 (gnu/linux) MIME-Version: 1.0 X-Scanned-By: MIMEDefang 2.84 on 10.5.11.22 Authentication-Results: relay.mimecast.com; auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=armbru@redhat.com X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Received-SPF: pass client-ip=216.205.24.124; envelope-from=armbru@redhat.com; helo=us-smtp-delivery-124.mimecast.com X-Spam_score_int: -29 X-Spam_score: -3.0 X-Spam_bar: --- X-Spam_report: (-3.0 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.219, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_LOW=-0.7, RCVD_IN_MSPIKE_H4=-0.01, RCVD_IN_MSPIKE_WL=-0.01, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Damien Hedde , Eduardo Habkost , "Michael S. Tsirkin" , QEMU Developers , Philippe =?utf-8?Q?Mathieu-Daud=C3=A9?= , Paolo Bonzini Errors-To: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Sender: "Qemu-devel" Peter Maydell writes: > On Sat, 24 Apr 2021 at 14:04, Philippe Mathieu-Daud=C3=A9 wrote: >> I now understand better the diag288 case, but I still don't understand >> the TYPE_APIC one. It has no DeviceClass::reset(), its abstract parent >> TYPE_APIC_COMMON register apic_reset_common() but being TYPE_DEVICE it >> is not on a qbus. It is somehow connected to the X86CPU object, but the >> single call to apic_init_reset() is from do_cpu_init() - not a reset >> method -. > > pc_machine_reset() calls device_legacy_reset(cpu->apic_state) > which is to say it invokes the DeviceState::reset method, > which is either kvm_apic_reset or apic_reset_common. device_legacy_reset() is deprecated: /** * device_legacy_reset: * * Reset a single device (by calling the reset method). * Note: This function is deprecated and will be removed when it become= s unused. * Please use device_cold_reset() now. */ void device_legacy_reset(DeviceState *dev); Good to know, but how do we get from here to there? If we could simply replace one call by the other, surely we'd have done it already.