Re: [PATCH] arm64: boot: dts: qcom: sm8150: add SPI nodes

[Felipe Balbi <balbi@kernel.org>]

[-- Attachment #1: Type: text/plain, Size: 1254 bytes --]

Dmitry Baryshkov <dmitry.baryshkov@linaro.org> writes:

> On Thu, 15 Apr 2021 at 14:02, Felipe Balbi <balbi@kernel.org> wrote:
>>
>> Dmitry Baryshkov <dmitry.baryshkov@linaro.org> writes:
>>
>> > On Thu, 15 Apr 2021 at 13:39, Felipe Balbi <balbi@kernel.org> wrote:
>> >>
>> >> From: Felipe Balbi <felipe.balbi@microsoft.com>
>> >>
>> >> Add missing SPI nodes for SM8150.
>> >>
>> >> Signed-off-by: Felipe Balbi <felipe.balbi@microsoft.com>
>> >
>> > I'd suggest switching to gpio-cs as implemented for sc7180 and sm8250.
>> > At least I'd propose to split the pinctrl into data+clock and CS
>> > configurations, so that the CS implementation can be easily selected
>> > on the board level.
>>
>> I can do that, sure. What do we gain from it, though? The possibility of
>> using more chip selects? It also sounds to me like this could be done as
>> a separate patch.
>
> I'd refer to the original discussion for sc7180:
> https://lore.kernel.org/linux-arm-msm/20200624170746.1.I997a428f58ef9d48b37a27a028360f34e66c00ec@changeid/

Thanks, an interesting discussion indeed. I'll wait for more reviews, if
the rest of folks think we should have the option, I can send an extra
patch or modify $subject. No worries.

-- 
balbi

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 857 bytes --]