From: "Aurélien Aptel" <aaptel@suse.com>
To: Shyam Prasad N <nspmangalore@gmail.com>,
Steve French <smfrench@gmail.com>
Cc: Pavel Shilovsky <piastryyy@gmail.com>,
Paulo Alcantara <pc@cjr.nz>, CIFS <linux-cifs@vger.kernel.org>
Subject: Re: [PATCH] cifs: On cifs_reconnect, resolve the hostname again.
Date: Thu, 08 Apr 2021 10:41:46 +0200 [thread overview]
Message-ID: <878s5t4185.fsf@suse.com> (raw)
In-Reply-To: <CANT5p=rq+jXGyZG-23dpOVOomObXmXEdr9FsO-=-vX9tH+kkCA@mail.gmail.com>
Shyam Prasad N <nspmangalore@gmail.com> writes:
> The intel bot identified an issue with the earlier version of the fix,
> when not compiled with DFS.
> Here's an updated version with that fix too.
Ah I guess that's why resolving wasn't done on reconnect outside of DFS:
it requires the DNS resolver which requires upcalling i.e. having
keys-utils, request-conf.conf and dns_resolver key installed and
properly configured on the system to be able to reconnect.
Maybe we should fallback to retrying the same ip if resolving isn't
available.
Cheers,
--
Aurélien Aptel / SUSE Labs Samba Team
GPG: 1839 CB5F 9F5B FB9B AA97 8C99 03C8 A49B 521B D5D3
SUSE Software Solutions Germany GmbH, Maxfeldstr. 5, 90409 Nürnberg, DE
GF: Felix Imendörffer, Mary Higgins, Sri Rasiah HRB 247165 (AG München)
next prev parent reply other threads:[~2021-04-08 8:41 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-04-05 15:33 [PATCH] cifs: On cifs_reconnect, resolve the hostname again Shyam Prasad N
2021-04-05 15:54 ` Paulo Alcantara
2021-04-05 16:06 ` Shyam Prasad N
2021-04-06 16:34 ` Pavel Shilovsky
2021-04-07 3:43 ` Steve French
2021-04-07 17:43 ` Shyam Prasad N
2021-04-07 19:00 ` Steve French
2021-04-08 2:25 ` Steve French
2021-04-08 8:41 ` Aurélien Aptel [this message]
2021-04-08 10:50 ` Shyam Prasad N
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=878s5t4185.fsf@suse.com \
--to=aaptel@suse.com \
--cc=linux-cifs@vger.kernel.org \
--cc=nspmangalore@gmail.com \
--cc=pc@cjr.nz \
--cc=piastryyy@gmail.com \
--cc=smfrench@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.