From: Kalle Valo <kvalo@codeaurora.org>
To: Hao Chen <chenhaoa@uniontech.com>
Cc: tony0620emma@gmail.com, davem@davemloft.net, kuba@kernel.org,
linux-wireless@vger.kernel.org, netdev@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] rtw88: 8822ce: fix wifi disconnect after S3/S4 on HONOR laptop
Date: Sat, 20 Feb 2021 11:07:34 +0200 [thread overview]
Message-ID: <878s7jjeeh.fsf@codeaurora.org> (raw)
In-Reply-To: <20210220084602.22386-1-chenhaoa@uniontech.com> (Hao Chen's message of "Sat, 20 Feb 2021 16:46:02 +0800")
Hao Chen <chenhaoa@uniontech.com> writes:
> When the laptop HONOR MagicBook 14 sleep to S3/S4, the laptop can't
> resume.
> The dmesg of kernel report:
> "[ 99.990168] pcieport 0000:00:01.2: can't change power state
> from D3hot to D0 (config space inaccessible)
> [ 99.993334] rtw_pci 0000:01:00.0: can't change power state
> from D3hot to D0 (config space inaccessible)
> [ 104.435004] rtw_pci 0000:01:00.0: mac power on failed
> [ 104.435010] rtw_pci 0000:01:00.0: failed to power on mac"
> When try to pointer the driver.pm to NULL, the problem is fixed.
> This driver hasn't implemented pm ops yet.It makes the sleep and
> wake procedure expected when pm's ops not NULL.
But why rtw_pci_suspend() and rtw_pci_resume() are empty? Should we just
remove them if they cause issues for the users? And if they are really
needed there should be a comment in the functions explaining the
situation.
> Fixed: commit e3037485c68e ("rtw88: new Realtek 802.11ac driver")
This should be:
Fixes: e3037485c68e ("rtw88: new Realtek 802.11ac driver")
--
https://patchwork.kernel.org/project/linux-wireless/list/
https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches
next prev parent reply other threads:[~2021-02-20 9:08 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-02-20 8:46 [PATCH] rtw88: 8822ce: fix wifi disconnect after S3/S4 on HONOR laptop Hao Chen
2021-02-20 9:07 ` Kalle Valo [this message]
[not found] ` <1323517535.1654941.1613976259730.JavaMail.xmail@bj-wm-cp-15>
2021-02-22 7:27 ` Kalle Valo
2021-02-22 11:20 ` Pkshih
2021-02-22 12:36 ` Hao Chen
2021-02-21 6:51 ` Leon Romanovsky
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=878s7jjeeh.fsf@codeaurora.org \
--to=kvalo@codeaurora.org \
--cc=chenhaoa@uniontech.com \
--cc=davem@davemloft.net \
--cc=kuba@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-wireless@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=tony0620emma@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.