From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-14.0 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER, INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 973B6C433DB for ; Fri, 29 Jan 2021 15:28:56 +0000 (UTC) Received: from merlin.infradead.org (merlin.infradead.org [205.233.59.134]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 51ABA64DE9 for ; Fri, 29 Jan 2021 15:28:56 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 51ABA64DE9 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=bootlin.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=merlin.20170209; h=Sender:Content-Transfer-Encoding: Content-Type:List-Subscribe:List-Help:List-Post:List-Archive:List-Unsubscribe :List-Id:MIME-Version:Message-ID:Date:References:In-Reply-To:Subject:To:From: Reply-To:Cc:Content-ID:Content-Description:Resent-Date:Resent-From: Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=396UsbtqpMmWijVUUdrgaCgHafgqaWS58XgJ2slTIag=; b=zUP3uQa9A0EM1J+zCztIcjtlkK k5YgXLWRjJv/qskFZsG8qlRg3fI+W33FhMKAw+fQtE7+188ebQt1FVKtB8rXoma+CN3l6+d+bYM5n HzUzA6iJOIM7R7YpTG8XIKXVGuTMjaRMh+dwS2qCzVP3TeaYMyxMGdGHykt6B4QD4KvpsiwEjWwT4 D0pPE3YZqGGSXFTJFrITSlMAqN92QZryPOJmNetlWrdZC9qUDJ1SvoNTRImQmHpf/rUIPeZ6xRjRZ jWGwPzODJkVqr5+QREPS2/WvkHZVQhswERjqtKbkIv+2oBT2raL/vYTFqo1ysPvAcKhOtUu3fg/gj SPusKwjg==; Received: from localhost ([::1] helo=merlin.infradead.org) by merlin.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1l5Vgi-0004Rm-2e; Fri, 29 Jan 2021 15:27:56 +0000 Received: from relay1-d.mail.gandi.net ([217.70.183.193]) by merlin.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1l5Vge-0004QV-4G for linux-arm-kernel@lists.infradead.org; Fri, 29 Jan 2021 15:27:53 +0000 X-Originating-IP: 90.65.91.141 Received: from localhost (lfbn-lyo-1-1912-141.w90-65.abo.wanadoo.fr [90.65.91.141]) (Authenticated sender: gregory.clement@bootlin.com) by relay1-d.mail.gandi.net (Postfix) with ESMTPSA id EB8C3240003; Fri, 29 Jan 2021 15:27:50 +0000 (UTC) From: Gregory CLEMENT To: Rosen Penev , linux-arm-kernel@lists.infradead.org Subject: Re: [PATCH 2/2] ARM: dts: armada388-helios4: assign pinctrl to each fan In-Reply-To: <20201203022321.19952-2-rosenp@gmail.com> References: <20201203022321.19952-1-rosenp@gmail.com> <20201203022321.19952-2-rosenp@gmail.com> Date: Fri, 29 Jan 2021 16:27:50 +0100 Message-ID: <878s8bu5jd.fsf@BL-laptop> MIME-Version: 1.0 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20210129_102752_304293_1AC329C5 X-CRM114-Status: GOOD ( 14.53 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org Hi Rosen, > Split up the pins for each fan. This is needed in order to control them > > Fixes: ced8025b569e ("ARM: dts: armada388-helios4") > > Signed-off-by: Rosen Penev Applied on mvebu/dt Thanks, Gregory > --- > arch/arm/boot/dts/armada-388-helios4.dts | 13 ++++++++++--- > 1 file changed, 10 insertions(+), 3 deletions(-) > > diff --git a/arch/arm/boot/dts/armada-388-helios4.dts b/arch/arm/boot/dts/armada-388-helios4.dts > index 5a6af7e83e44..ec134e22bae3 100644 > --- a/arch/arm/boot/dts/armada-388-helios4.dts > +++ b/arch/arm/boot/dts/armada-388-helios4.dts > @@ -127,11 +127,15 @@ > fan1: j10-pwm { > compatible = "pwm-fan"; > pwms = <&gpio1 9 40000>; /* Target freq:25 kHz */ > + pinctrl-names = "default"; > + pinctrl-0 = <&helios_fan1_pins>; > }; > > fan2: j17-pwm { > compatible = "pwm-fan"; > pwms = <&gpio1 23 40000>; /* Target freq:25 kHz */ > + pinctrl-names = "default"; > + pinctrl-0 = <&helios_fan2_pins>; > }; > > usb2_phy: usb2-phy { > @@ -302,9 +306,12 @@ > "mpp54"; > marvell,function = "gpio"; > }; > - helios_fan_pins: helios-fan-pins { > - marvell,pins = "mpp41", "mpp43", > - "mpp48", "mpp55"; > + helios_fan1_pins: helios_fan1_pins { > + marvell,pins = "mpp41", "mpp43"; > + marvell,function = "gpio"; > + }; > + helios_fan2_pins: helios_fan2_pins { > + marvell,pins = "mpp48", "mpp55"; > marvell,function = "gpio"; > }; > microsom_spi1_cs_pins: spi1-cs-pins { > -- > 2.17.1 > -- Gregory Clement, Bootlin Embedded Linux and Kernel engineering http://bootlin.com _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel